From: Kevin Decherf Date: Sun, 7 Jan 2018 16:25:26 +0000 (+0100) Subject: ContentProxy: fix a corner case when entry.url is empty in updateEntry X-Git-Tag: 2.3.4~8^2~8 X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=4a81360efcdfe4bab8d75f7227c9cf5bfd514189;p=github%2Fwallabag%2Fwallabag.git ContentProxy: fix a corner case when entry.url is empty in updateEntry Signed-off-by: Kevin Decherf --- diff --git a/src/Wallabag/CoreBundle/Helper/ContentProxy.php b/src/Wallabag/CoreBundle/Helper/ContentProxy.php index d4ea608f..f0d8c1b4 100644 --- a/src/Wallabag/CoreBundle/Helper/ContentProxy.php +++ b/src/Wallabag/CoreBundle/Helper/ContentProxy.php @@ -66,6 +66,14 @@ class ContentProxy // so we'll be able to refetch it in the future $content['url'] = !empty($content['url']) ? $content['url'] : $url; + // In one case (at least in tests), url is empty here + // so we set it using $url provided in the updateEntry call. + // Not sure what are the other possible cases where this property is empty + if (empty($entry->getUrl()) && !empty($url)) + { + $entry->setUrl($url); + } + $this->stockEntry($entry, $content); }