From: Jeremy Benoist <jeremy.benoist@gmail.com>
Date: Mon, 13 Jan 2020 13:26:10 +0000 (+0100)
Subject: Ensure ENV is well defined when using make
X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;h=49eb5405debb49d19c58f966b4fceac9ea9571ae;hp=68fd40e4fce33b19f946f54388a4016ab32998e0;p=github%2Fwallabag%2Fwallabag.git

Ensure ENV is well defined when using make

This command should fail before calling other commands (which will fail to because the environment is wrong):

```
ENV=toto make install
```
---

diff --git a/GNUmakefile b/GNUmakefile
index 865b35e8..db87c5d2 100755
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -2,7 +2,17 @@ SHELL=bash
 TMP_FOLDER=/tmp
 RELEASE_FOLDER=wllbg-release
 
-ENV ?= prod
+# ensure the ENV variable is well defined
+ifeq ($(origin ENV), prod)
+	# all good ("prod" is a valid env)
+else ifeq ($(origin ENV), dev)
+	# all good ("dev" is a valid env)
+else ifeq ($(origin ENV), test)
+	# all good ("test" is a valid env)
+else
+	# not good, force it to "prod"
+	override ENV = prod
+endif
 
 help: ## Display this help menu
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'