From: Jérémy Benoist Date: Wed, 27 Nov 2019 13:04:11 +0000 (+0100) Subject: Fix tests X-Git-Url: https://git.immae.eu/?a=commitdiff_plain;ds=sidebyside;h=6a0d49ab7a8ac9e00f9df34b37b6d3e1ab40f2a9;p=github%2Fwallabag%2Fwallabag.git Fix tests --- diff --git a/tests/Wallabag/AnnotationBundle/Controller/AnnotationControllerTest.php b/tests/Wallabag/AnnotationBundle/Controller/AnnotationControllerTest.php index 74e9ba8f..260edd77 100644 --- a/tests/Wallabag/AnnotationBundle/Controller/AnnotationControllerTest.php +++ b/tests/Wallabag/AnnotationBundle/Controller/AnnotationControllerTest.php @@ -107,7 +107,7 @@ class AnnotationControllerTest extends WallabagAnnotationTestCase $this->assertSame('my annotation', $annotation->getText()); } - public function testCouldNotSetAnnotationWithoutQuote() + public function testAllowEmptyQuote() { $em = $this->client->getContainer()->get('doctrine.orm.entity_manager'); @@ -126,15 +126,42 @@ class AnnotationControllerTest extends WallabagAnnotationTestCase ]); $this->client->request('POST', '/api/annotations/' . $entry->getId() . '.json', [], [], $headers, $content); - $this->assertSame(400, $this->client->getResponse()->getStatusCode()); + $this->assertSame(200, $this->client->getResponse()->getStatusCode()); + + $content = json_decode($this->client->getResponse()->getContent(), true); + + $this->assertSame('Big boss', $content['user']); + $this->assertSame('v1.0', $content['annotator_schema_version']); + $this->assertSame('my annotation', $content['text']); + $this->assertSame('', $content['quote']); + } + + public function testAllowOmmittedQuote() + { + $em = $this->client->getContainer()->get('doctrine.orm.entity_manager'); + + /** @var Entry $entry */ + $entry = $em + ->getRepository('WallabagCoreBundle:Entry') + ->findOneByUsernameAndNotArchived('admin'); + + $headers = ['CONTENT_TYPE' => 'application/json']; + $content = json_encode([ + 'text' => 'my new annotation', + 'ranges' => [ + ['start' => '', 'startOffset' => 25, 'end' => '', 'endOffset' => 32], + ], + ]); + $this->client->request('POST', '/api/annotations/' . $entry->getId() . '.json', [], [], $headers, $content); + + $this->assertSame(200, $this->client->getResponse()->getStatusCode()); $content = json_decode($this->client->getResponse()->getContent(), true); - $this->assertCount( - 1, - $content['errors']['children']['quote']['errors'], - 'The quote field should contains an error' - ); + $this->assertSame('Big boss', $content['user']); + $this->assertSame('v1.0', $content['annotator_schema_version']); + $this->assertSame('my new annotation', $content['text']); + $this->assertSame('', $content['quote']); } /**