Server: check the host key is not present in configurations

The parameter was renamed to hostname

diff --git a/server.js b/server.js
index 317b6ed77c3b791b3891a7ad11e328fccd0e8e74..18d9a087c9d66a5533a48d56f0b29455a226d40f 100644 (file)
--- a/server.js
+++ b/server.js
@@ -26,9 +26,14 @@ database.connect()
 // ----------- Checker -----------
 const checker = require('./server/initializers/checker')
 
-const miss = checker.checkConfig()
-if (miss.length !== 0) {
-  throw new Error('Miss some configurations keys : ' + miss)
+const missed = checker.checkMissedConfig()
+if (missed.length !== 0) {
+  throw new Error('Miss some configurations keys : ' + missed)
+}
+
+const errorMessage = checker.checkConfig()
+if (errorMessage !== null) {
+  throw new Error(errorMessage)
 }
 
 // ----------- PeerTube modules -----------

diff --git a/server/initializers/checker.js b/server/initializers/checker.js
index 4ecabac77fcf230fcd7cff857f10bd24ce2ae0b2..dad8525fa72e10492aaf0d40c6d4a43f53e0c481 100644 (file)
--- a/server/initializers/checker.js
+++ b/server/initializers/checker.js
@@ -8,12 +8,25 @@ const User = mongoose.model('User')
 
 const checker = {
   checkConfig,
+  checkMissedConfig,
   clientsExist,
   usersExist
 }
 
-// Check the config files
+// Some checks on configuration files
 function checkConfig () {
+  if (config.has('webserver.host')) {
+    let errorMessage = '`host` config key was renamed to `hostname` but it seems you still have a `host` key in your configuration files!'
+    errorMessage += ' Please ensure to rename your `host` configuration to `hostname`.'
+
+    return errorMessage
+  }
+
+  return null
+}
+
+// Check the config files
+function checkMissedConfig () {
   const required = [ 'listen.port',
     'webserver.https', 'webserver.hostname', 'webserver.port',
     'database.hostname', 'database.port', 'database.suffix',