Add ability to disable unknown infohash log

diff --git a/config/default.yaml b/config/default.yaml
index f7c9b620c9d5967f770356730ed4a36701c186bd..8e5d133554787bfd00e87d7ba424a54dbc1830e3 100644 (file)
--- a/config/default.yaml
+++ b/config/default.yaml
@@ -174,6 +174,7 @@ log:
     max_files: 20
   anonymize_ip: false
   log_ping_requests: true
+  log_tracker_unknown_infohash: true
   prettify_sql: false
 
 trending:

diff --git a/config/production.yaml.example b/config/production.yaml.example
index a36f4979bf8a48c872988791147f5e9d9cec7c5f..ef03582216c932e0f3ff313ae741b92f88c6ab08 100644 (file)
--- a/config/production.yaml.example
+++ b/config/production.yaml.example
@@ -1,5 +1,5 @@
 listen:
-  hostname: 'localhost'
+  hostname: '127.0.0.1'
   port: 9000
 
 # Correspond to your reverse proxy server_name/listen configuration (i.e., your public PeerTube instance URL)
@@ -91,11 +91,13 @@ defaults:
     licence: null
 
   p2p:
-    # Enable P2P by default
+    # Enable P2P by default in PeerTube client
     # Can be enabled/disabled by anonymous users and logged in users
     webapp:
       enabled: true
 
+    # Enable P2P by default in PeerTube embed
+    # Can be enabled/disabled by URL option
     embed:
       enabled: true
 
@@ -135,7 +137,7 @@ object_storage:
   region: 'us-east-1'
 
   # Set this ACL on each uploaded object
-  upload_acl: 'public'
+  upload_acl: 'public-read'
 
   credentials:
     # You can also use AWS_ACCESS_KEY_ID env variable
@@ -170,6 +172,7 @@ log:
     max_files: 20
   anonymize_ip: false
   log_ping_requests: true
+  log_tracker_unknown_infohash: true
   prettify_sql: false
 
 trending:
@@ -225,7 +228,7 @@ security:
     enabled: true
 
 tracker:
-  # If you disable the tracker, you disable the P2P aspect of PeerTube
+  # If you disable the tracker, you disable the P2P on your PeerTube instance
   enabled: true
   # Only handle requests on your videos
   # If you set this to false it means you have a public tracker

diff --git a/server/controllers/tracker.ts b/server/controllers/tracker.ts
index 6d60639b880e66da7a213abe58b0273881d46736..914d52b726a7a46f5bbd09b1adb064430bed44c1 100644 (file)
--- a/server/controllers/tracker.ts
+++ b/server/controllers/tracker.ts
@@ -69,12 +69,16 @@ const trackerServer = new TrackerServer({
 })
 
 if (CONFIG.TRACKER.ENABLED !== false) {
-
   trackerServer.on('error', function (err) {
     logger.error('Error in tracker.', { err })
   })
 
   trackerServer.on('warning', function (err) {
+    if (CONFIG.LOG.LOG_TRACKER_UNKNOWN_INFOHASH) {
+      const message = err.message || ''
+      if (message.includes('Uknown infoHash')) return
+    }
+
     logger.warn('Warning in tracker.', { err })
   })
 }

diff --git a/server/initializers/config.ts b/server/initializers/config.ts
index c76a839bc76f6b58c9c49b0df69d19572cba72eb..754585981dd8f284acda08c9797f2243bf482640 100644 (file)
--- a/server/initializers/config.ts
+++ b/server/initializers/config.ts
@@ -164,6 +164,7 @@ const CONFIG = {
     },
     ANONYMIZE_IP: config.get<boolean>('log.anonymize_ip'),
     LOG_PING_REQUESTS: config.get<boolean>('log.log_ping_requests'),
+    LOG_TRACKER_UNKNOWN_INFOHASH: config.get<boolean>('log.log_tracker_unknown_infohash'),
     PRETTIFY_SQL: config.get<boolean>('log.prettify_sql')
   },
   TRENDING: {