Review

diff --git a/app/DoctrineMigrations/Version20170606155640.php b/app/DoctrineMigrations/Version20170606155640.php
index 1b23404487dca0c4969d089795d3618b567639ef..e9b504283448108c16a4f4a7c6d3c5c8b5ceba3e 100644 (file)
--- a/app/DoctrineMigrations/Version20170606155640.php
+++ b/app/DoctrineMigrations/Version20170606155640.php
@@ -8,7 +8,8 @@ use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
- * Add api_user_registration in craue_config_setting.
+ * Remove wallabag_url from craue_config_setting.
+ * It has been moved into the parameters.yml
  */
 class Version20170606155640 extends AbstractMigration implements ContainerAwareInterface
 {

diff --git a/app/config/parameters.yml.dist b/app/config/parameters.yml.dist
index c00ffb0e8de7986f946c46b31fa5fe0e9fdf1d1a..d827219a687bf32989123e41f7aa7b46d2737f25 100644 (file)
--- a/app/config/parameters.yml.dist
+++ b/app/config/parameters.yml.dist
@@ -23,7 +23,7 @@ parameters:
     # with PostgreSQL and SQLite, you must set "utf8"
     database_charset: utf8mb4
 
-    domain_name: wallabag.me
+    domain_name: http://your-wallabag-url-instance.com
 
     mailer_transport: smtp
     mailer_host: 127.0.0.1

diff --git a/app/config/parameters_test.yml b/app/config/parameters_test.yml
index 92f0364fb162f9c57086c2c5114610c142f500b9..010785e67c5de8e378ba978602eb96dc60864960 100644 (file)
--- a/app/config/parameters_test.yml
+++ b/app/config/parameters_test.yml
@@ -8,4 +8,3 @@ parameters:
     test_database_path: "%env(TEST_DATABASE_PATH)%"
     env(TEST_DATABASE_PATH): "%kernel.root_dir%/../data/db/wallabag_test.sqlite"
     test_database_charset: utf8
-    domain_name: 'http://v2.wallabag.org'

diff --git a/app/config/wallabag.yml b/app/config/wallabag.yml
index d03450a09ca9a09490075d7a11b9fe93b6fc80a8..51b7e4e3034fcb9bf344d9e378ad2b6e5e284db1 100644 (file)
--- a/app/config/wallabag.yml
+++ b/app/config/wallabag.yml
@@ -26,7 +26,6 @@ wallabag_core:
     fetching_error_message: |
         wallabag can't retrieve contents for this article. Please <a href="http://doc.wallabag.org/en/user/errors_during_fetching.html#how-can-i-help-to-fix-that">troubleshoot this issue</a>.
     api_limit_mass_actions: 10
-    domain_name: '%domain_name%'
     default_internal_settings:
         -
             name: share_public

diff --git a/src/Wallabag/CoreBundle/DependencyInjection/Configuration.php b/src/Wallabag/CoreBundle/DependencyInjection/Configuration.php
index a6f53714ee9b102b519503343d60fa6445713fec..33df92d3c8dc202671951d04e1f66ec9cb9b258f 100644 (file)
--- a/src/Wallabag/CoreBundle/DependencyInjection/Configuration.php
+++ b/src/Wallabag/CoreBundle/DependencyInjection/Configuration.php
@@ -63,8 +63,6 @@ class Configuration implements ConfigurationInterface
                         ->end()
                     ->end()
                 ->end()
-                ->scalarNode('domain_name')
-                ->end()
             ->end()
         ;
 

diff --git a/src/Wallabag/CoreBundle/DependencyInjection/WallabagCoreExtension.php b/src/Wallabag/CoreBundle/DependencyInjection/WallabagCoreExtension.php
index d0b4351e99fa43a651fd3d6cb836aeffff01166d..b4d8a3866a59db84a4b993c59a4498c3fb9957f4 100644 (file)
--- a/src/Wallabag/CoreBundle/DependencyInjection/WallabagCoreExtension.php
+++ b/src/Wallabag/CoreBundle/DependencyInjection/WallabagCoreExtension.php
@@ -29,7 +29,6 @@ class WallabagCoreExtension extends Extension
         $container->setParameter('wallabag_core.fetching_error_message_title', $config['fetching_error_message_title']);
         $container->setParameter('wallabag_core.api_limit_mass_actions', $config['api_limit_mass_actions']);
         $container->setParameter('wallabag_core.default_internal_settings', $config['default_internal_settings']);
-        $container->setParameter('wallabag_core.domain_name', $config['domain_name']);
 
         $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.yml');

diff --git a/src/Wallabag/CoreBundle/Resources/config/services.yml b/src/Wallabag/CoreBundle/Resources/config/services.yml
index 6e2c976156c9dda366b48581bba7624c4f5a1d27..8b00700f654421622bae8cd5513903c4a4bc0b2d 100644 (file)
--- a/src/Wallabag/CoreBundle/Resources/config/services.yml
+++ b/src/Wallabag/CoreBundle/Resources/config/services.yml
@@ -195,7 +195,7 @@ services:
         arguments:
             - "@wallabag_core.entry.download_images.client"
             - "%kernel.root_dir%/../web/assets/images"
-            - '%wallabag_core.domain_name%'
+            - '%domain_name%'
             - "@logger"
 
     wallabag_core.entry.download_images.client:

diff --git a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
index cc7b3672c73e6ddc98f6d7ce33a73c7cbdae52ee..581ee9523029cd4a2d5287a5d53f777c72617f53 100644 (file)
--- a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
+++ b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
@@ -1000,7 +1000,7 @@ class EntryControllerTest extends WallabagCoreTestCase
         $this->assertEquals($url, $entry->getUrl());
         $this->assertContains('Perpignan', $entry->getTitle());
         // instead of checking for the filename (which might change) check that the image is now local
-        $this->assertContains('http://v2.wallabag.org/assets/images/', $entry->getContent());
+        $this->assertContains('http://your-wallabag-url-instance.com/assets/images/', $entry->getContent());
 
         $client->getContainer()->get('craue_config')->set('download_images_enabled', 0);
     }