add ansible-lint test and fix warning

diff --git a/.travis.yml b/.travis.yml
index 2b452f94769d8ec64496bede6b038191a6f84a04..c1686319642f9ca34fd1dff205381f6f57fc5fff 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -18,6 +18,7 @@ install:
 script:
   # Basic role syntax check
   - ansible-playbook tests/test.yml -i tests/inventory --syntax-check
+  - ansible-lint .
 
 notifications:
   slack: fretlink:pTIylIN7zkwRFuL3aHERmsbB

diff --git a/tasks/addon.yml b/tasks/addon.yml
index f6a4d14b5a36d44aa4c6bcdef9ca2d59e5253b80..5e7102c20ccdae357d5fe6a53f12f6c871dc1d25 100644 (file)
--- a/tasks/addon.yml
+++ b/tasks/addon.yml
@@ -2,6 +2,7 @@
   shell: "clever env | grep {{ addon.env_prefix }} | sed -e 's/{{ addon.env_prefix }}_//' -e 's/=/: \"/' -e 's/$/\"/' > {{ clever_app_confdir }}/{{ addon.name }}_env.yml"
   environment:
     CONFIGURATION_FILE: "{{ clever_login_file }}"
+  changed_when: False
 
 - name: Include addon var for {{ addon.name }}
   include_vars:

diff --git a/tasks/deploy.yml b/tasks/deploy.yml
index 54c04ac06879936595394dc7794fa9810f8c2386..5e773b4e2b50678ee369fd09d10dfab951552341 100644 (file)
--- a/tasks/deploy.yml
+++ b/tasks/deploy.yml
@@ -16,13 +16,18 @@
   shell: "clever env import < {{ clever_app_confdir }}/env"
   environment:
     CONFIGURATION_FILE: "{{ clever_login_file }}"
+  changed_when: false
 
 #TODO: Improve ssh-key validation
 - name: Accept Clever-Cloud servers
   shell: "ssh-keyscan -H push-par-clevercloud-customers.services.clever-cloud.com >> ~/.ssh/known_hosts"
+  tags:
+    - skip_ansible_lint
 
 - name: Push to Clever-Cloud to trigger deployment
   command: "git push --force git+ssh://git@push-par-clevercloud-customers.services.clever-cloud.com/{{ clever_app }}.git HEAD:refs/heads/master"
+  tags:
+    - skip_ansible_lint
 
 - name: Watch deployment status
   command: clever-wait-deploy.sh
@@ -31,6 +36,7 @@
   register: long_command
   environment:
     CONFIGURATION_FILE: "{{ clever_login_file }}"
+  changed_when: False
 
 # Waits up to 15 minutes
 - name: Wait for deployment completion

diff --git a/tasks/login.yml b/tasks/login.yml
index 0eb310f4c29d0cc575f2c4c1ca8a543ef1389c71..bed5dbc5565b16c4a4d17063eb0bc8be38546651 100644 (file)
--- a/tasks/login.yml
+++ b/tasks/login.yml
@@ -10,6 +10,8 @@
   no_log: true
 
 - name: Link app
-  shell: clever link {{ clever_app }}
+  command: clever link {{ clever_app }}
+  args:
+    creates: "{{ clever_app_root }}/.clever.json"
   environment:
     CONFIGURATION_FILE: "{{ clever_login_file }}"

diff --git a/tasks/setup.yml b/tasks/setup.yml
index 0dfcddf8f43451e06b69959221ab8138a4f03338..f85a635400e2dd0c499ff7cc77976f3978040d82 100644 (file)
--- a/tasks/setup.yml
+++ b/tasks/setup.yml
@@ -2,6 +2,7 @@
   command: clever --version
   register: clever_returned_version
   ignore_errors: true
+  changed_when: False
 
 - name: Ensure user path exists
   file: