Add test on AP hooks

diff --git a/client/src/app/+videos/+video-edit/shared/video-edit.component.ts b/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
index e3bd5fe71e743ec447488686fd242b82ef474a9c..2bc0e6bb415ecc49603a6b06679764a17be48d76 100644 (file)
--- a/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
+++ b/client/src/app/+videos/+video-edit/shared/video-edit.component.ts
@@ -240,11 +240,11 @@ export class VideoEditComponent implements OnInit, OnDestroy {
       this.schedulerInterval = setInterval(() => this.minScheduledDate = new Date(), 1000 * 60) // Update every minute
     })
 
-    const updateForm = (values: any) => {
+    const updateFormForPlugins = (values: any) => {
       this.form.patchValue(values)
       this.cd.detectChanges()
     }
-    this.hooks.runAction('action:video-edit.init', 'video-edit', { type: this.type, updateForm })
+    this.hooks.runAction('action:video-edit.init', 'video-edit', { type: this.type, updateForm: updateFormForPlugins })
 
     this.form.valueChanges.subscribe(() => {
       this.hooks.runAction('action:video-edit.form.updated', 'video-edit', { type: this.type, formValues: this.form.value })

diff --git a/server/lib/activitypub/send/send-update.ts b/server/lib/activitypub/send/send-update.ts
index 5a66294e6a6104d26b992223c652dff3e36b0586..379e2d9d84b544643233afb33e33826672fc2a93 100644 (file)
--- a/server/lib/activitypub/send/send-update.ts
+++ b/server/lib/activitypub/send/send-update.ts
@@ -59,7 +59,7 @@ async function sendUpdateActor (accountOrChannel: MChannelDefault | MAccountDefa
   logger.info('Creating job to update actor %s.', byActor.url)
 
   const url = getUpdateActivityPubUrl(byActor.url, byActor.updatedAt.toISOString())
-  const accountOrChannelObject = (accountOrChannel as any).toActivityPubObject() // FIXME: typescript bug?
+  const accountOrChannelObject = await (accountOrChannel as any).toActivityPubObject() // FIXME: typescript bug?
   const audience = getAudience(byActor)
   const updateActivity = buildUpdateActivity(url, byActor, accountOrChannelObject, audience)
 

diff --git a/server/models/video/video.ts b/server/models/video/video.ts
index 7fe2ec2938795cae5c6d0cbebe5f10e2f2384dce..aa9c62e36e5d1847377bdce41ce8a53e91e44568 100644 (file)
--- a/server/models/video/video.ts
+++ b/server/models/video/video.ts
@@ -1717,7 +1717,7 @@ export class VideoModel extends Model<Partial<AttributesOnly<VideoModel>>> {
   toActivityPubObject (this: MVideoAP): Promise<VideoObject> {
     return Hooks.wrapObject(
       videoModelToActivityPubObject(this),
-      'filter:activity-pub.video.jsonld.build.result',
+      'filter:activity-pub.video.json-ld.build.result',
       { video: this }
     )
   }

diff --git a/server/tests/fixtures/peertube-plugin-test/main.js b/server/tests/fixtures/peertube-plugin-test/main.js
index f01da0226f78ae22bb239523bc7a87dd670467f6..6d06ec17d1a8f3e7d3dc33d926999418d6fcac0a 100644 (file)
--- a/server/tests/fixtures/peertube-plugin-test/main.js
+++ b/server/tests/fixtures/peertube-plugin-test/main.js
@@ -207,6 +207,18 @@ async function register ({ registerHook, registerSetting, settingsManager, stora
 
   // ---------------------------------------------------------------------------
 
+  registerHook({
+    target: 'filter:activity-pub.activity.context.build.result',
+    handler: context => context.concat([ 'https://example.com/new-context' ])
+  })
+
+  registerHook({
+    target: 'filter:activity-pub.video.json-ld.build.result',
+    handler: (jsonld, { video }) => ({ ...jsonld, videoName: video.name })
+  })
+
+  // ---------------------------------------------------------------------------
+
   registerHook({
     target: 'filter:api.video-threads.list.params',
     handler: obj => addToCount(obj)

diff --git a/server/tests/plugins/filter-hooks.ts b/server/tests/plugins/filter-hooks.ts
index a7e052d06c5fb6edaa5d8e3cd0f87e5afcf67dde..ab3a6a093be41711ebb80a7ca0d734da691ae1e2 100644 (file)
--- a/server/tests/plugins/filter-hooks.ts
+++ b/server/tests/plugins/filter-hooks.ts
@@ -14,6 +14,7 @@ import {
   cleanupTests,
   createMultipleServers,
   doubleFollow,
+  makeActivityPubGetRequest,
   makeGetRequest,
   makeRawRequest,
   PeerTubeServer,
@@ -846,6 +847,22 @@ describe('Test plugin filter hooks', function () {
     })
   })
 
+  describe('Activity Pub', function () {
+
+    it('Should run filter:activity-pub.activity.context.build.result', async function () {
+      const { body } = await makeActivityPubGetRequest(servers[0].url, '/w/' + videoUUID)
+      expect(body.type).to.equal('Video')
+
+      expect(body['@context'].some(c => c === 'https://example.com/new-context')).to.be.true
+    })
+
+    it('Should run filter:activity-pub.video.json-ld.build.result', async function () {
+      const { body } = await makeActivityPubGetRequest(servers[0].url, '/w/' + videoUUID)
+      expect(body.name).to.equal('default video 0')
+      expect(body.videoName).to.equal('default video 0')
+    })
+  })
+
   after(async function () {
     await cleanupTests(servers)
   })

diff --git a/shared/models/plugins/server/server-hook.model.ts b/shared/models/plugins/server/server-hook.model.ts
index 7881beaa29011f77d4f5e91d2cae0a81f3f677a8..ca83672d02e0edf9f094339fef54d3b4e3b8a7b6 100644 (file)
--- a/shared/models/plugins/server/server-hook.model.ts
+++ b/shared/models/plugins/server/server-hook.model.ts
@@ -119,7 +119,7 @@ export const serverFilterHookObject = {
 
   // Filter the result of video JSON LD builder
   // You may also need to use filter:activity-pub.activity.context.build.result to also update JSON LD context
-  'filter:activity-pub.video.jsonld.build.result': true
+  'filter:activity-pub.video.json-ld.build.result': true
 }
 
 export type ServerFilterHookName = keyof typeof serverFilterHookObject