]> git.immae.eu Git - github/Chocobozzz/PeerTube.git/commitdiff
Add more hints regarding live port
authorChocobozzz <me@florianbigard.com>
Mon, 11 Jan 2021 08:20:44 +0000 (09:20 +0100)
committerChocobozzz <me@florianbigard.com>
Mon, 11 Jan 2021 08:20:44 +0000 (09:20 +0100)
client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html
client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.ts
client/src/app/core/server/server.service.ts
config/default.yaml
config/production.yaml.example
server/controllers/api/config.ts
shared/models/server/server-config.model.ts

index af8a4e18dd73cd1c36518cf60af5ecdab9f24362..013784c6c5d2adc81f2d699f2f5ee04615e6d538 100644 (file)
                     <ng-container i18n>Allow live streaming</ng-container>
                   </ng-template>
 
-                  <ng-container ngProjectAs="description" i18n>
-                    ⚠️ Enabling live streaming requires trust in your users and extra moderation work
+                  <ng-container ngProjectAs="description">
+                    <div i18n>⚠️ Enabling live streaming requires trust in your users and extra moderation work</div>
+                    <div i18n>If enabled, your server needs to accept incoming TCP traffic on port {{ liveRTMPPort }}</div>
                   </ng-container>
 
                   <ng-container ngProjectAs="extra">
index c3a833843b83933d45dea101161e84673379d27f..f74229af016f7a4d676ad53dda525bc3f0dc58a2 100644 (file)
@@ -119,6 +119,10 @@ export class EditCustomConfigComponent extends FormReactive implements OnInit, A
       .map(t => t.name)
   }
 
+  get liveRTMPPort () {
+    return this.serverConfig.live.rtmp.port
+  }
+
   getTotalTranscodingThreads () {
     const transcodingEnabled = this.form.value['transcoding']['enabled']
     const transcodingThreads = this.form.value['transcoding']['threads']
index 1abf87118fdeaa2a827cb6212e1f1fdad8685fba..b1d8fcf8339b6dd46a9809b765143c39666b0a9b 100644 (file)
@@ -83,6 +83,9 @@ export class ServerService {
       transcoding: {
         enabled: false,
         enabledResolutions: []
+      },
+      rtmp: {
+        port: 1935
       }
     },
     avatar: {
index 9d428f764fde075c2eedbd7c2b0a0bac06c7e8c8..01e5c8480ce9d6114720b4dba739210be72d35e4 100644 (file)
@@ -264,6 +264,7 @@ live:
   # /!\ transcoding.enabled (and not live.transcoding.enabled) has to be true to create a replay
   allow_replay: false
 
+  # Your firewall should accept traffic from this port in TCP if you enable live
   rtmp:
     port: 1935
 
index bcf727d82541ee03489d4ba282956b6a8dea345a..a5cdedf35e8c8bcecc9a96b2f2f38c465d0ce289 100644 (file)
@@ -278,6 +278,7 @@ live:
   # /!\ transcoding.enabled (and not live.transcoding.enabled) has to be true to create a replay
   allow_replay: true
 
+  # Your firewall should accept traffic from this port in TCP if you enable live
   rtmp:
     port: 1935
 
index eb9f5f4b474d97bdbb4f85f00964c07a96e36fb5..2401e2ff428a4b64b7c54e554718596d27b8f988 100644 (file)
@@ -126,6 +126,10 @@ async function getConfig (req: express.Request, res: express.Response) {
       transcoding: {
         enabled: CONFIG.LIVE.TRANSCODING.ENABLED,
         enabledResolutions: getEnabledResolutions('live')
+      },
+
+      rtmp: {
+        port: CONFIG.LIVE.RTMP.PORT
       }
     },
     import: {
index a01fcbe418f8c937552da15827328fb0a7a74239..2dcf98f4f3183891c4331c5c644621062fb4888a 100644 (file)
@@ -111,6 +111,10 @@ export interface ServerConfig {
 
       enabledResolutions: number[]
     }
+
+    rtmp: {
+      port: number
+    }
   }
 
   import: {