Logging: improve formatting to enable fail2ban parsing

Fixes #436

Modifications:
- remove calls to strval() on safe data
- update the date format: 'Y/m/d_H:i:s' => 'Y/m/d H:i:s'

Signed-off-by: VirtualTam <virtualtam@flibidi.net>

diff --git a/application/Utils.php b/application/Utils.php
index a9a10ece572a02e36c151931c719be739894faaa..cb30595f13cac0c977ce2aa0f7cdf554d345a3fe 100644 (file)
--- a/application/Utils.php
+++ b/application/Utils.php
@@ -6,14 +6,19 @@
 /**
  * Logs a message to a text file
  *
+ * The log format is compatible with fail2ban.
+ *
  * @param string $logFile  where to write the logs
  * @param string $clientIp the client's remote IPv4/IPv6 address
  * @param string $message  the message to log
  */
 function logm($logFile, $clientIp, $message)
 {
-    $line = strval(date('Y/m/d_H:i:s')).' - '.$clientIp.' - '.strval($message).'\n';
-    file_put_contents($logFile, $line, FILE_APPEND);
+    file_put_contents(
+        $logFile,
+        date('Y/m/d H:i:s').' - '.$clientIp.' - '.strval($message).'\n',
+        FILE_APPEND
+    );
 }
 
 /**

diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
index 869a9695be1b2075eac0e6f0e9eadcdc170ed5b7..f3bb556ec5d0e7f851822a6d4d4cc71d9257c210 100644 (file)
--- a/tests/UtilsTest.php
+++ b/tests/UtilsTest.php
@@ -22,7 +22,7 @@ class UtilsTest extends PHPUnit_Framework_TestCase
     protected static $testLogFile = 'tests.log';
 
     // Expected log date format
-    protected static $dateFormat = 'Y/m/d_H:i:s';
+    protected static $dateFormat = 'Y/m/d H:i:s';
     
 
     /**