]> git.immae.eu Git - github/wallabag/wallabag.git/commitdiff
Merge branch 'dev' into register
authorThomas Citharel <tcit@tcit.fr>
Fri, 13 Feb 2015 18:15:31 +0000 (19:15 +0100)
committerThomas Citharel <tcit@tcit.fr>
Fri, 13 Feb 2015 18:15:31 +0000 (19:15 +0100)
1  2 
inc/poche/Poche.class.php
inc/poche/Routing.class.php
inc/poche/config.inc.default.php

index 36c8693c15380d75940d6e2485682e4cbcfd548b,8ade91b4852900e8b20da18666d02bfb60d2a1d8..cd7578e3401ad4966e6f74ac013b9714c8717f5b
@@@ -74,17 -74,50 +74,51 @@@ class Poch
      /**
       * Creates a new user
       */
-     public function createNewUser($username, $password, $email = "")
+     public function createNewUser($username, $password, $email = "", $internalRegistration = false)
      {
 +        Tools::logm('Trying to create a new user...');
          if (!empty($username) && !empty($password)){
              $newUsername = filter_var($username, FILTER_SANITIZE_STRING);
              $email = filter_var($email, FILTER_SANITIZE_STRING);
              if (!$this->store->userExists($newUsername)){
                  if ($this->store->install($newUsername, Tools::encodeString($password . $newUsername), $email)) {
-                     Tools::logm('The new user ' . $newUsername . ' has been installed');
-                     $this->messages->add('s', sprintf(_('The new user %s has been installed. Do you want to <a href="?logout">logout ?</a>'), $newUsername));
-                     Tools::redirect();
+                     if ($email != "") { // if email is filled
+                         if (SEND_CONFIRMATION_EMAIL && function_exists('mail')) {
+                             // if internal registration
+                             $body_internal = _('Hi,') . "\r\n\r\n" . sprintf(_('Someone just created a wallabag account for you on %1$s.'), Tools::getPocheUrl()) . 
+                             "\r\n\r\n" . sprintf(_('Your login is %1$s.'), $newUsername) ."\r\n\r\n" .
+                             _('Note : The password has been chosen by the person who created your account. Get in touch with that person to know your password and change it as soon as possible') . "\r\n\r\n" .
+                             _('Have fun with it !') . "\r\n\r\n" .
+                             _('This is an automatically generated message, no one will answer if you respond to it.');
+                             
+                             // if external (public) registration
+                             $body = "Hi, " . $newUsername . "\r\n\r\nYou've just created a wallabag account on " . Tools::getPocheUrl() . ".\r\nHave fun with it !";
+                             $body = $internalRegistration ? $body_internal : $body;
+                             $body = wordwrap($body, 70, "\r\n"); // cut lines with more than 70 caracters (MIME standard)
+                             if (mail($email, sprintf(_('Your new wallabag account on %1$s'), Tools::getPocheUrl()), $body, 
+                                 'X-Mailer: PHP/' . phpversion() .  "\r\n" . 
+                                 'Content-type: text/plain; charset=UTF-8' . "\r\n" .
+                                 "From: " . $newUsername . "@" . gethostname() . "\r\n")) {
+                                 Tools::logm('The user ' . $newUsername . ' has been emailed');
+                                 $this->messages->add('i', sprintf(_('The new user %1$s has been sent an email at %2$s. You may have to check spam folder.'), $newUsername, $email));
+                                 
+                             } else {
+                                 Tools::logm('A problem has been encountered while sending an email');
+                                 $this->messages->add('e', _('A problem has been encountered while sending an email'));
+                             }
+                         } else {
+                             Tools::logm('The user has been created, but the server did not authorize sending emails');
+                             $this->messages->add('i', _('The server did not authorize sending a confirmation email'));
+                         }
+                 } else {
+                     Tools::logm('The user has been created, but no email was saved, so no confimation email was sent');
+                     $this->messages->add('i', _('The user was created, but no email was sent because email was not filled in'));
+                 }
+                 Tools::logm('The new user ' . $newUsername . ' has been installed');
+                 $this->messages->add('s', sprintf(_('The new user %s has been installed. Do you want to <a href="?logout">logout ?</a>'), $newUsername));
+                 Tools::redirect();
                  }
                  else {
                      Tools::logm('error during adding new user');
                  Tools::redirect();
              }
          }
 +        else {
 +            Tools::logm('Password or username were empty');
 +        }
      }
  
      /**
                  }
  
                  if ($autoclose == TRUE) {
-                   Tools::redirect('?view=home');
+                     Tools::redirect('?view=home&closewin=true');
                  } else {
-                   Tools::redirect('?view=home&closewin=true');
+                     Tools::redirect('?view=home');
                  }
                  return $last_id;
                  break;
                  $this->messages->add('s', _('The tag has been successfully deleted'));
                  Tools::redirect();
                  break;
+             case 'reload_article' :
+                 Tools::logm('reload article');
+                 $id = $_GET['id'];
+                 $entry = $this->store->retrieveOneById($id, $this->user->getId());
+                 Tools::logm('reload url ' . $entry['url']);
+                 $url = new Url(base64_encode($entry['url']));
+                 $this->action('add', $url);
+                 break;
+                 
+             /* For some unknown reason I can't get displayView() to work here (it redirects to home view afterwards). So here's a dirty fix which redirects directly to URL */
+             case 'random':
+                 $id = 0;
+                 while ($this->store->retrieveOneById($id,$this->user->getId()) == null) {
+                     $count = $this->store->getEntriesByViewCount($view, $this->user->getId());
+                     $id = rand(1,$count);
+                 }
+                 Tools::logm('get a random article');
+                 Tools::redirect('?view=view&id=' . $id);
+                 //$this->displayView('view', $id);
+                 break;
              default:
                  break;
          }
                  $purifier = $this->_getPurifier();
                  foreach($items as $item) {
                      $url = new Url(base64_encode($item['url']));
-                     Tools::logm('Fetching article ' . $item['id']);
-                     $content = Tools::getPageContent($url);
-                     $title = (($content['rss']['channel']['item']['title'] != '') ? $content['rss']['channel']['item']['title'] : _('Untitled'));
-                     $body = (($content['rss']['channel']['item']['description'] != '') ? $content['rss']['channel']['item']['description'] : _('Undefined'));
-                     // clean content to prevent xss attack
-                     $title = $purifier->purify($title);
-                     $body = $purifier->purify($body);
-                     $this->store->updateContentAndTitle($item['id'], $title, $body, $this->user->getId());
-                     Tools::logm('Article ' . $item['id'] . ' updated.');
+                     if( $url->isCorrect() )
+                     {
+                         Tools::logm('Fetching article ' . $item['id']);
+                         $content = Tools::getPageContent($url);
+                         $title = (($content['rss']['channel']['item']['title'] != '') ? $content['rss']['channel']['item']['title'] : _('Untitled'));
+                         $body = (($content['rss']['channel']['item']['description'] != '') ? $content['rss']['channel']['item']['description'] : _('Undefined'));
+                         // clean content to prevent xss attack
+                         $title = $purifier->purify($title);
+                         $body = $purifier->purify($body);
+                         $this->store->updateContentAndTitle($item['id'], $title, $body, $this->user->getId());
+                         Tools::logm('Article ' . $item['id'] . ' updated.');
+                     } else
+                     {
+                         Tools::logm('Unvalid URL (' . $item['url'] .')  to fetch for article ' . $item['id']);
+                     }
                  }
              }
          }
index 8d6abefde615b931e7cde4a351095653286f9542,82ff20d67b3ff2318638dd25e768c0c8a373fb87..e9b67771791c59ce1ffd0f4616da489b491a8e13
@@@ -33,6 -33,7 +33,7 @@@ class Routin
          $this->view         = Tools::checkVar('view', 'home');
          $this->action       = Tools::checkVar('action');
          $this->id           = Tools::checkVar('id');
+         $this->autoclose    = Tools::checkVar('autoclose',FALSE);
          $_SESSION['sort']   = Tools::checkVar('sort', 'id');
          $this->url          = new Url((isset ($_GET['url'])) ? $_GET['url'] : '');
      }
          $tplVars = array();
  
          if (\Session::isLogged()) {
-             $this->wallabag->action($this->action, $this->url, $this->id);
+             $this->wallabag->action($this->action, $this->url, $this->id, FALSE, $this->autoclose);
              $tplFile = Tools::getTplFile($this->view);
              $tplVars = array_merge($this->vars, $this->wallabag->displayView($this->view, $this->id));
 +        } elseif(ALLOW_REGISTER && isset($_GET['registerform'])) {
 +            Tools::logm('register');
 +            $tplFile = Tools::getTplFile('register');
 +        } elseif (ALLOW_REGISTER && isset($_GET['register'])){
 +            $this->wallabag->createNewUser($_POST['newusername'], $_POST['password4newuser']);
 +            Tools::redirect();
          } elseif(isset($_SERVER['PHP_AUTH_USER'])) {
              if($this->wallabag->store->userExists($_SERVER['PHP_AUTH_USER'])) {
                  $this->wallabag->login($this->referer);
              $tag_id = (isset($_GET['tag_id']) ? intval($_GET['tag_id']) : 0);
              $limit = (isset($_GET['limit']) ? intval($_GET['limit']) : 0);
              $this->wallabag->generateFeeds($_GET['token'], filter_var($_GET['user_id'],FILTER_SANITIZE_NUMBER_INT), $tag_id, $_GET['type'], $limit);
 -        }
 +        } //elseif (ALLOW_REGISTER && isset($_GET['register'])) {
 +            //$this->wallabag->register
 +        //}
          
          //allowed ONLY to logged in user
          if (\Session::isLogged() === true) 
                  // update password
                  $this->wallabag->updatePassword($_POST['password'], $_POST['password_repeat']);
              } elseif (isset($_GET['newuser'])) {
-                 $this->wallabag->createNewUser($_POST['newusername'], $_POST['password4newuser']);
+                 $this->wallabag->createNewUser($_POST['newusername'], $_POST['password4newuser'], $_POST['newuseremail'], true);
              } elseif (isset($_GET['deluser'])) {
                  $this->wallabag->deleteUser($_POST['password4deletinguser']);
              } elseif (isset($_GET['epub'])) {
index 000faf1c5e62f0a2547808362a6dc0e1f4e813a5,0fd9bc0e513008c16e491d139c5bb60147038c62..e569dddd692c8c34e28f556fab120f50bf3309a4
@@@ -33,8 -33,6 +33,8 @@@
  @define ('MODE_DEMO', FALSE);
  @define ('DEBUG_POCHE', FALSE);
  
 +@define ('ALLOW_REGISTER', TRUE);
 +
  //default level of error reporting in application. Developers should override it in their config.inc.php: set to E_ALL.
  @define ('ERROR_REPORTING', E_ALL & ~E_NOTICE);
  
@@@ -46,6 -44,7 +46,7 @@@
  @define ('SHARE_MAIL', TRUE);
  @define ('SHARE_SHAARLI', FALSE);
  @define ('SHAARLI_URL', 'http://myshaarliurl.com');
+ @define ('SHARE_EVERNOTE', FALSE);
  @define ('SHARE_DIASPORA', FALSE);
  @define ('DIASPORA_URL', 'http://diasporapod.com'); # Don't add a / at the end
  @define ('FLATTR', TRUE);
  @define ('MOBI', FALSE);
  @define ('PDF', FALSE);
  
+ // registration
+ @define ('SEND_CONFIRMATION_EMAIL', TRUE); // TO BE CHANGED DEPENDING ON POLL
  // display or not print link in article view
  @define ('SHOW_PRINTLINK', '1');
  // display or not percent of read in article view. Affects only default theme.
  @define ('SHOW_READPERCENT', '1');
+ @define ('RELOAD_ARTICLE', TRUE);
  @define ('ABS_PATH', 'assets/');
  
  @define ('DEFAULT_THEME', 'baggy');