If the response content isn't the one expected, instead of checking into the whole DOM (with node tag, etc ..) we only check the text.
So if it fails, phpunit will display only the text, not all node tag. It'll be easier to read.
public function deleteTaggingRuleAction(TaggingRule $rule)
{
if ($this->getUser()->getId() != $rule->getConfig()->getUser()->getId()) {
public function deleteTaggingRuleAction(TaggingRule $rule)
{
if ($this->getUser()->getId() != $rule->getConfig()->getUser()->getId()) {
- throw $this->createAccessDeniedException('You can not access this tagging ryle.');
+ throw $this->createAccessDeniedException('You can not access this tagging rule.');
}
$em = $this->getDoctrine()->getManager();
}
$em = $this->getDoctrine()->getManager();
$crawler = $client->request('GET', '/config');
$crawler = $client->request('GET', '/config');
- if (500 == $client->getResponse()->getStatusCode()) {
- var_export($client->getResponse()->getContent());
- die();
- }
-
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('button[id=rss_config_save]')->form();
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$form = $crawler->filter('button[id=rss_config_save]')->form();
$form = $crawler->filter('button[id=tagging_rule_save]')->form();
$form = $crawler->filter('button[id=tagging_rule_save]')->form();
- $client->submit($form, $data);
+ $crawler = $client->submit($form, $data);
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$this->assertEquals(200, $client->getResponse()->getStatusCode());
+ $this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(array('_text')));
+
foreach ($messages as $message) {
foreach ($messages as $message) {
- $this->assertContains($message, $client->getResponse()->getContent());
+ $this->assertContains($message, $body[0]);
->getRepository('WallabagCoreBundle:TaggingRule')
->findAll()[0];
->getRepository('WallabagCoreBundle:TaggingRule')
->findAll()[0];
- $client->request('GET', '/tagging-rule/delete/'.$rule->getId());
+ $crawler = $client->request('GET', '/tagging-rule/delete/'.$rule->getId());
+
$this->assertEquals(403, $client->getResponse()->getStatusCode());
$this->assertEquals(403, $client->getResponse()->getStatusCode());
- $this->assertContains('You can not access this tagging ryle', $client->getResponse()->getContent());
+ $this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(array('_text')));
+ $this->assertContains('You can not access this tagging rule', $body[0]);
}
public function testDemoMode()
}
public function testDemoMode()
$client = $this->getClient();
$client->request('GET', '/unread/list');
$client = $this->getClient();
$client->request('GET', '/unread/list');
- $client->followRedirect();
+ $crawler = $client->followRedirect();
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$this->assertEquals(200, $client->getResponse()->getStatusCode());
- $this->assertContains('quickstart.intro.paragraph_1', $client->getResponse()->getContent());
+ $this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(array('_text')));
+ $this->assertContains('quickstart.intro.paragraph_1', $body[0]);
// Test if quickstart is disabled when user has 1 entry
$crawler = $client->request('GET', '/new');
// Test if quickstart is disabled when user has 1 entry
$crawler = $client->request('GET', '/new');
$this->assertEquals(302, $client->getResponse()->getStatusCode());
$client->followRedirect();
$this->assertEquals(302, $client->getResponse()->getStatusCode());
$client->followRedirect();
- $client->request('GET', '/unread/list');
- $this->assertContains('entry.list.number_on_the_page', $client->getResponse()->getContent());
+ $crawler = $client->request('GET', '/unread/list');
+ $this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(array('_text')));
+ $this->assertContains('entry.list.number_on_the_page', $body[0]);
}
public function testGetNew()
}
public function testGetNew()
->getRepository('WallabagCoreBundle:Entry')
->findByUrlAndUserId($this->url, $this->getLoggedInUserId());
->getRepository('WallabagCoreBundle:Entry')
->findByUrlAndUserId($this->url, $this->getLoggedInUserId());
- $client->request('GET', '/view/'.$content->getId());
+ $crawler = $client->request('GET', '/view/'.$content->getId());
$this->assertEquals(200, $client->getResponse()->getStatusCode());
$this->assertEquals(200, $client->getResponse()->getStatusCode());
- $this->assertContains($content->getTitle(), $client->getResponse()->getContent());
+ $this->assertGreaterThan(1, $body = $crawler->filter('body')->extract(array('_text')));
+ $this->assertContains($content->getTitle(), $body[0]);