]> git.immae.eu Git - github/shaarli/Shaarli.git/commit - index.php
Refactor bookmark import using a generic Netscape parser
authorVirtualTam <virtualtam@flibidi.net>
Thu, 28 Jul 2016 20:54:33 +0000 (22:54 +0200)
committerArthurHoaro <arthur@hoa.ro>
Sat, 5 Nov 2016 13:29:52 +0000 (14:29 +0100)
commitd6d8558723ed20a49cd602cb0adbc7f112254bd8
tree071e3b9ff4c3d167dedea291cfcd6cd3c9d5d44e
parent05d8c485ec4df9a0016fa19d75f279795e23fc7b
Refactor bookmark import using a generic Netscape parser

Relates to #607
Relates to #608
Relates to #493 (abandoned)

Additions:
- use Composer's autoload to load 3rd-party dependencies under vendor/

Modifications:
- [import] replace the current parser with a generic, stable parser
  - move code to application/NetscapeBookmarkUtils
  - improve status report after parsing
- [router] use the same endpoint for both bookmark upload and import dialog
- [template] update bookmark import options
  - allow adding tags to all imported links
  - allow selecting the visibility (privacy) of imported links
- [tests] ensure bookmarks are properly parsed and imported in the LinkDB
  - reuse reference input from the parser's test data

See:
- https://github.com/shaarli/netscape-bookmark-parser
- https://getcomposer.org/doc/01-basic-usage.md#autoloading

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
application/NetscapeBookmarkUtils.php
index.php
tests/NetscapeBookmarkUtils/BookmarkExportTest.php [moved from tests/NetscapeBookmarkUtilsTest.php with 97% similarity]
tests/NetscapeBookmarkUtils/BookmarkImportTest.php [new file with mode: 0644]
tests/NetscapeBookmarkUtils/input/empty.htm [new file with mode: 0644]
tests/NetscapeBookmarkUtils/input/netscape_basic.htm [new file with mode: 0644]
tests/NetscapeBookmarkUtils/input/netscape_nested.htm [new file with mode: 0644]
tests/NetscapeBookmarkUtils/input/no_doctype.htm [new file with mode: 0644]
tests/NetscapeBookmarkUtils/input/same_date.htm [new file with mode: 0644]
tpl/import.html