X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=tests%2FPluginManagerTest.php;h=a5d5dbe988ea22ad525ed74a71b5c3d421c2d7ec;hb=5cacf290f01076587e8d7ac82feef855e4a2d10f;hp=348082c763c2dde8a25c474ae0979248a6a9ad0e;hpb=dea0ba28f950867532eae572e7bcda49e81bbcf0;p=github%2Fshaarli%2FShaarli.git

diff --git a/tests/PluginManagerTest.php b/tests/PluginManagerTest.php
index 348082c7..a5d5dbe9 100644
--- a/tests/PluginManagerTest.php
+++ b/tests/PluginManagerTest.php
@@ -1,15 +1,12 @@
 <?php
+namespace Shaarli\Plugin;
 
-/**
- * Plugin Manager tests
- */
-
-require_once 'application/PluginManager.php';
+use Shaarli\Config\ConfigManager;
 
 /**
  * Unit tests for Plugins
  */
-class PluginManagerTest extends PHPUnit_Framework_TestCase
+class PluginManagerTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * Path to tests plugin.
@@ -24,62 +21,88 @@ class PluginManagerTest extends PHPUnit_Framework_TestCase
     private static $pluginName = 'test';
 
     /**
-     * Test plugin loading and hook execution.
-     *
-     * @return void
+     * @var PluginManager $pluginManager Plugin Mananger instance.
      */
-    public function testPlugin()
+    protected $pluginManager;
+
+    public function setUp(): void
     {
-        $pluginManager = PluginManager::getInstance();
+        $conf = new ConfigManager('');
+        $this->pluginManager = new PluginManager($conf);
+    }
 
+    /**
+     * Test plugin loading and hook execution.
+     */
+    public function testPlugin(): void
+    {
         PluginManager::$PLUGINS_PATH = self::$pluginPath;
-        $pluginManager->load(array(self::$pluginName));
+        $this->pluginManager->load(array(self::$pluginName));
 
         $this->assertTrue(function_exists('hook_test_random'));
 
         $data = array(0 => 'woot');
-        $pluginManager->executeHooks('random', $data);
+        $this->pluginManager->executeHooks('random', $data);
         $this->assertEquals('woot', $data[1]);
 
         $data = array(0 => 'woot');
-        $pluginManager->executeHooks('random', $data, array('target' => 'test'));
+        $this->pluginManager->executeHooks('random', $data, array('target' => 'test'));
         $this->assertEquals('page test', $data[1]);
 
         $data = array(0 => 'woot');
-        $pluginManager->executeHooks('random', $data, array('loggedin' => true));
+        $this->pluginManager->executeHooks('random', $data, array('loggedin' => true));
         $this->assertEquals('loggedin', $data[1]);
     }
 
     /**
-     * Test missing plugin loading.
-     *
-     * @return void
+     * Test plugin loading and hook execution with an error: raise an incompatibility error.
      */
-    public function testPluginNotFound()
+    public function testPluginWithPhpError(): void
     {
-        $pluginManager = PluginManager::getInstance();
+        PluginManager::$PLUGINS_PATH = self::$pluginPath;
+        $this->pluginManager->load(array(self::$pluginName));
+
+        $this->assertTrue(function_exists('hook_test_error'));
 
-        $pluginManager->load(array());
+        $data = [];
+        $this->pluginManager->executeHooks('error', $data);
 
-        $pluginManager->load(array('nope', 'renope'));
+        $this->assertSame(
+            'test [plugin incompatibility]: Class \'Unknown\' not found',
+            $this->pluginManager->getErrors()[0]
+        );
     }
 
     /**
-     * Test plugin metadata loading.
+     * Test missing plugin loading.
      */
-    public function testGetPluginsMeta()
+    public function testPluginNotFound(): void
     {
-        $pluginManager = PluginManager::getInstance();
+        $this->pluginManager->load(array());
+        $this->pluginManager->load(array('nope', 'renope'));
+        $this->addToAssertionCount(1);
+    }
 
+    /**
+     * Test plugin metadata loading.
+     */
+    public function testGetPluginsMeta(): void
+    {
         PluginManager::$PLUGINS_PATH = self::$pluginPath;
-        $pluginManager->load(array(self::$pluginName));
+        $this->pluginManager->load(array(self::$pluginName));
 
         $expectedParameters = array(
-            'pop' => '',
-            'hip' => '',
+            'pop' => array(
+                'value' => '',
+                'desc'  => 'pop description',
+            ),
+            'hip' => array(
+                'value' => '',
+                'desc' => '',
+            ),
         );
-        $meta = $pluginManager->getPluginsMeta();
+        $meta = $this->pluginManager->getPluginsMeta();
         $this->assertEquals('test plugin', $meta[self::$pluginName]['description']);
         $this->assertEquals($expectedParameters, $meta[self::$pluginName]['parameters']);
     }
-}
\ No newline at end of file
+}