X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=tests%2FLinkDBTest.php;h=43652e72c502fbd695e362755a8cc92d53b65c7c;hb=628b97cbdf276785eb9ff4f7a124e81e67d2f76c;hp=bbe4e026963785c75193fd5287b838cbdfd4d491;hpb=4a5827ff5adadcd8c1ef9231e485f77c0c376c03;p=github%2Fshaarli%2FShaarli.git diff --git a/tests/LinkDBTest.php b/tests/LinkDBTest.php index bbe4e026..43652e72 100644 --- a/tests/LinkDBTest.php +++ b/tests/LinkDBTest.php @@ -3,13 +3,12 @@ * Link datastore tests */ +require_once 'application/Cache.php'; +require_once 'application/FileUtils.php'; require_once 'application/LinkDB.php'; require_once 'application/Utils.php'; require_once 'tests/utils/ReferenceLinkDB.php'; -define('PHPPREFIX', ''); - /** * Unitary tests for LinkDB @@ -17,10 +16,21 @@ define('PHPSUFFIX', ' */ ?>'); class LinkDBTest extends PHPUnit_Framework_TestCase { // datastore to test write operations - protected static $testDatastore = 'tests/datastore.php'; - protected static $dummyDatastoreSHA1 = 'e3edea8ea7bb50be4bcb404df53fbb4546a7156e'; + protected static $testDatastore = 'sandbox/datastore.php'; + + /** + * @var ReferenceLinkDB instance. + */ protected static $refDB = null; + + /** + * @var LinkDB public LinkDB instance. + */ protected static $publicLinkDB = null; + + /** + * @var LinkDB private LinkDB instance. + */ protected static $privateLinkDB = null; /** @@ -38,11 +48,10 @@ class LinkDBTest extends PHPUnit_Framework_TestCase public static function setUpBeforeClass() { self::$refDB = new ReferenceLinkDB(); - self::$refDB->write(self::$testDatastore, PHPPREFIX, PHPSUFFIX); + self::$refDB->write(self::$testDatastore); - $GLOBALS['config']['DATASTORE'] = self::$testDatastore; - self::$publicLinkDB = new LinkDB(false); - self::$privateLinkDB = new LinkDB(true); + self::$publicLinkDB = new LinkDB(self::$testDatastore, false, false); + self::$privateLinkDB = new LinkDB(self::$testDatastore, true, false); } /** @@ -50,7 +59,6 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ protected function setUp() { - $GLOBALS['config']['DATASTORE'] = self::$testDatastore; if (file_exists(self::$testDatastore)) { unlink(self::$testDatastore); } @@ -76,7 +84,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testConstructLoggedIn() { - new LinkDB(true); + new LinkDB(self::$testDatastore, true, false); $this->assertFileExists(self::$testDatastore); } @@ -85,20 +93,19 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testConstructLoggedOut() { - new LinkDB(false); + new LinkDB(self::$testDatastore, false, false); $this->assertFileExists(self::$testDatastore); } /** * Attempt to instantiate a LinkDB whereas the datastore is not writable * - * @expectedException PHPUnit_Framework_Error_Warning - * @expectedExceptionMessageRegExp /failed to open stream: No such file or directory/ + * @expectedException IOException + * @expectedExceptionMessageRegExp /Error accessing\nnull/ */ public function testConstructDatastoreNotWriteable() { - $GLOBALS['config']['DATASTORE'] = 'null/store.db'; - new LinkDB(false); + new LinkDB('null/store.db', false, false); } /** @@ -106,7 +113,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testCheckDBNew() { - $linkDB = new LinkDB(false); + $linkDB = new LinkDB(self::$testDatastore, false, false); unlink(self::$testDatastore); $this->assertFileNotExists(self::$testDatastore); @@ -115,10 +122,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase $this->assertFileExists(self::$testDatastore); // ensure the correct data has been written - $this->assertEquals( - self::$dummyDatastoreSHA1, - sha1_file(self::$testDatastore) - ); + $this->assertGreaterThan(0, filesize(self::$testDatastore)); } /** @@ -126,19 +130,17 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testCheckDBLoad() { - $linkDB = new LinkDB(false); - $this->assertEquals( - self::$dummyDatastoreSHA1, - sha1_file(self::$testDatastore) - ); + $linkDB = new LinkDB(self::$testDatastore, false, false); + $datastoreSize = filesize(self::$testDatastore); + $this->assertGreaterThan(0, $datastoreSize); $checkDB = self::getMethod('checkDB'); $checkDB->invokeArgs($linkDB, array()); // ensure the datastore is left unmodified $this->assertEquals( - self::$dummyDatastoreSHA1, - sha1_file(self::$testDatastore) + $datastoreSize, + filesize(self::$testDatastore) ); } @@ -147,8 +149,8 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testReadEmptyDB() { - file_put_contents(self::$testDatastore, PHPPREFIX.'S7QysKquBQA='.PHPSUFFIX); - $emptyDB = new LinkDB(false); + file_put_contents(self::$testDatastore, ''); + $emptyDB = new LinkDB(self::$testDatastore, false, false); $this->assertEquals(0, sizeof($emptyDB)); $this->assertEquals(0, count($emptyDB)); } @@ -180,7 +182,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase */ public function testSaveDB() { - $testDB = new LinkDB(true); + $testDB = new LinkDB(self::$testDatastore, true, false); $dbSize = sizeof($testDB); $link = array( @@ -192,13 +194,9 @@ class LinkDBTest extends PHPUnit_Framework_TestCase 'tags'=>'unit test' ); $testDB[$link['linkdate']] = $link; + $testDB->savedb('tests'); - // TODO: move PageCache to a proper class/file - function invalidateCaches() {} - - $testDB->savedb(); - - $testDB = new LinkDB(true); + $testDB = new LinkDB(self::$testDatastore, true, false); $this->assertEquals($dbSize + 1, sizeof($testDB)); } @@ -217,18 +215,35 @@ class LinkDBTest extends PHPUnit_Framework_TestCase ); } + /** + * Count existing links - public links hidden + */ + public function testCountHiddenPublic() + { + $linkDB = new LinkDB(self::$testDatastore, false, true); + + $this->assertEquals( + 0, + $linkDB->count() + ); + $this->assertEquals( + 0, + $linkDB->count() + ); + } + /** * List the days for which links have been posted */ public function testDays() { $this->assertEquals( - ['20121206', '20130614', '20150310'], + array('20121206', '20130614', '20150310'), self::$publicLinkDB->days() ); $this->assertEquals( - ['20121206', '20130614', '20141125', '20150310'], + array('20121206', '20130614', '20141125', '20150310'), self::$privateLinkDB->days() ); } @@ -241,7 +256,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase $link = self::$publicLinkDB->getLinkFromUrl('http://mediagoblin.org/'); $this->assertNotEquals(false, $link); - $this->assertEquals( + $this->assertContains( 'A free software media publishing platform', $link['description'] ); @@ -264,7 +279,7 @@ class LinkDBTest extends PHPUnit_Framework_TestCase public function testAllTags() { $this->assertEquals( - [ + array( 'web' => 3, 'cartoon' => 2, 'gnu' => 2, @@ -273,13 +288,18 @@ class LinkDBTest extends PHPUnit_Framework_TestCase 'media' => 1, 'software' => 1, 'stallman' => 1, - 'free' => 1 - ], + 'free' => 1, + '-exclude' => 1, + // The DB contains a link with `sTuff` and another one with `stuff` tag. + // They need to be grouped with the first case found (`sTuff`). + 'sTuff' => 2, + 'hashtag' => 2, + ), self::$publicLinkDB->allTags() ); $this->assertEquals( - [ + array( 'web' => 4, 'cartoon' => 3, 'gnu' => 2, @@ -292,218 +312,125 @@ class LinkDBTest extends PHPUnit_Framework_TestCase 'html' => 1, 'w3c' => 1, 'css' => 1, - 'Mercurial' => 1 - ], + 'Mercurial' => 1, + 'sTuff' => 2, + '-exclude' => 1, + '.hidden' => 1, + 'hashtag' => 2, + 'tag1' => 1, + 'tag2' => 1, + 'tag3' => 1, + 'tag4' => 1, + ), self::$privateLinkDB->allTags() ); } /** - * Filter links using a tag + * Test real_url without redirector. */ - public function testFilterOneTag() + public function testLinkRealUrlWithoutRedirector() { - $this->assertEquals( - 3, - sizeof(self::$publicLinkDB->filterTags('web', false)) - ); - - $this->assertEquals( - 4, - sizeof(self::$privateLinkDB->filterTags('web', false)) - ); + $db = new LinkDB(self::$testDatastore, false, false); + foreach($db as $link) { + $this->assertEquals($link['url'], $link['real_url']); + } } /** - * Filter links using a tag - case-sensitive + * Test real_url with redirector. */ - public function testFilterCaseSensitiveTag() + public function testLinkRealUrlWithRedirector() { - $this->assertEquals( - 0, - sizeof(self::$privateLinkDB->filterTags('mercurial', true)) - ); + $redirector = 'http://redirector.to?'; + $db = new LinkDB(self::$testDatastore, false, false, $redirector); + foreach($db as $link) { + $this->assertStringStartsWith($redirector, $link['real_url']); + $this->assertNotFalse(strpos($link['real_url'], urlencode('://'))); + } - $this->assertEquals( - 1, - sizeof(self::$privateLinkDB->filterTags('Mercurial', true)) - ); + $db = new LinkDB(self::$testDatastore, false, false, $redirector, false); + foreach($db as $link) { + $this->assertStringStartsWith($redirector, $link['real_url']); + $this->assertFalse(strpos($link['real_url'], urlencode('://'))); + } } /** - * Filter links using a tag combination + * Test filter with string. */ - public function testFilterMultipleTags() + public function testFilterString() { - $this->assertEquals( - 1, - sizeof(self::$publicLinkDB->filterTags('dev cartoon', false)) - ); - + $tags = 'dev cartoon'; + $request = array('searchtags' => $tags); $this->assertEquals( 2, - sizeof(self::$privateLinkDB->filterTags('dev cartoon', false)) + count(self::$privateLinkDB->filterSearch($request, true, false)) ); } /** - * Filter links using a non-existent tag + * Test filter with string. */ - public function testFilterUnknownTag() - { - $this->assertEquals( - 0, - sizeof(self::$publicLinkDB->filterTags('null', false)) - ); - } - - /** - * Return links for a given day - */ - public function testFilterDay() + public function testFilterArray() { + $tags = array('dev', 'cartoon'); + $request = array('searchtags' => $tags); $this->assertEquals( 2, - sizeof(self::$publicLinkDB->filterDay('20121206')) - ); - - $this->assertEquals( - 3, - sizeof(self::$privateLinkDB->filterDay('20121206')) - ); - } - - /** - * 404 - day not found - */ - public function testFilterUnknownDay() - { - $this->assertEquals( - 0, - sizeof(self::$publicLinkDB->filterDay('19700101')) - ); - - $this->assertEquals( - 0, - sizeof(self::$privateLinkDB->filterDay('19700101')) + count(self::$privateLinkDB->filterSearch($request, true, false)) ); } /** - * Use an invalid date format + * Test hidden tags feature: + * tags starting with a dot '.' are only visible when logged in. */ - public function testFilterInvalidDay() + public function testHiddenTags() { - $this->assertEquals( - 0, - sizeof(self::$privateLinkDB->filterDay('Rainy day, dream away')) - ); - - // TODO: check input format - $this->assertEquals( - 6, - sizeof(self::$privateLinkDB->filterDay('20')) - ); - } - - /** - * Retrieve a link entry with its hash - */ - public function testFilterSmallHash() - { - $links = self::$privateLinkDB->filterSmallHash('IuWvgA'); - + $tags = '.hidden'; + $request = array('searchtags' => $tags); $this->assertEquals( 1, - sizeof($links) + count(self::$privateLinkDB->filterSearch($request, true, false)) ); - $this->assertEquals( - 'MediaGoblin', - $links['20130614_184135']['title'] - ); - - } - - /** - * No link for this hash - */ - public function testFilterUnknownSmallHash() - { $this->assertEquals( 0, - sizeof(self::$privateLinkDB->filterSmallHash('Iblaah')) - ); - } - - /** - * Full-text search - result from a link's URL - */ - public function testFilterFullTextURL() - { - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('ars.userfriendly.org')) + count(self::$publicLinkDB->filterSearch($request, true, false)) ); } /** - * Full-text search - result from a link's title only + * Test filterHash() with a valid smallhash. */ - public function testFilterFullTextTitle() - { - // use miscellaneous cases - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('userfriendly -')) - ); - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('UserFriendly -')) - ); - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('uSeRFrIendlY -')) - ); - - // use miscellaneous case and offset - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('RFrIendL')) - ); - } - - /** - * Full-text search - result from the link's description only - */ - public function testFilterFullTextDescription() + public function testFilterHashValid() { + $request = smallHash('20150310_114651'); $this->assertEquals( 1, - sizeof(self::$publicLinkDB->filterFullText('media publishing')) + count(self::$publicLinkDB->filterHash($request)) ); } /** - * Full-text search - result from the link's tags only + * Test filterHash() with an invalid smallhash. + * + * @expectedException LinkNotFoundException */ - public function testFilterFullTextTags() + public function testFilterHashInValid1() { - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('gnu')) - ); + $request = 'blabla'; + self::$publicLinkDB->filterHash($request); } /** - * Full-text search - result set from mixed sources + * Test filterHash() with an empty smallhash. + * + * @expectedException LinkNotFoundException */ - public function testFilterFullTextMixed() + public function testFilterHashInValid() { - $this->assertEquals( - 2, - sizeof(self::$publicLinkDB->filterFullText('free software')) - ); + self::$publicLinkDB->filterHash(''); } } -?>