X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=src%2FWallabag%2FCoreBundle%2FTests%2FHelper%2FContentProxyTest.php;h=d29984e97f94f7729ec9648c7982c73372abd8ce;hb=1930c19d8214c05ceefac5ac011a6b6e7e4a983d;hp=71a004ffe71a52cf56dced1339710254e97607bc;hpb=f1e29e69cb0ba5a0f05190c62e7a4afd43d03436;p=github%2Fwallabag%2Fwallabag.git diff --git a/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php b/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php index 71a004ff..d29984e9 100644 --- a/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php +++ b/src/Wallabag/CoreBundle/Tests/Helper/ContentProxyTest.php @@ -2,15 +2,19 @@ namespace Wallabag\CoreBundle\Tests\Helper; -use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; +use Psr\Log\NullLogger; use Wallabag\CoreBundle\Entity\Entry; -use Wallabag\CoreBundle\Entity\User; use Wallabag\CoreBundle\Helper\ContentProxy; +use Wallabag\UserBundle\Entity\User; -class ContentProxyTest extends KernelTestCase +class ContentProxyTest extends \PHPUnit_Framework_TestCase { public function testWithEmptyContent() { + $tagger = $this->getTaggerMock(); + $tagger->expects($this->once()) + ->method('tag'); + $graby = $this->getMockBuilder('Graby\Graby') ->setMethods(array('fetchContent')) ->disableOriginalConstructor() @@ -18,9 +22,15 @@ class ContentProxyTest extends KernelTestCase $graby->expects($this->any()) ->method('fetchContent') - ->willReturn(array('html' => false, 'title' => '', 'url' => '', 'content_type' => '')); + ->willReturn(array( + 'html' => false, + 'title' => '', + 'url' => '', + 'content_type' => '', + 'language' => '', + )); - $proxy = new ContentProxy($graby); + $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); $this->assertEquals('http://0.0.0.0', $entry->getUrl()); @@ -28,10 +38,17 @@ class ContentProxyTest extends KernelTestCase $this->assertEquals('

Unable to retrieve readable content.

', $entry->getContent()); $this->assertEmpty($entry->getPreviewPicture()); $this->assertEmpty($entry->getMimetype()); + $this->assertEmpty($entry->getLanguage()); + $this->assertEquals(0.0, $entry->getReadingTime()); + $this->assertEquals('0.0.0.0', $entry->getDomainName()); } public function testWithEmptyContentButOG() { + $tagger = $this->getTaggerMock(); + $tagger->expects($this->once()) + ->method('tag'); + $graby = $this->getMockBuilder('Graby\Graby') ->setMethods(array('fetchContent')) ->disableOriginalConstructor() @@ -39,20 +56,37 @@ class ContentProxyTest extends KernelTestCase $graby->expects($this->any()) ->method('fetchContent') - ->willReturn(array('html' => false, 'title' => '', 'url' => '', 'content_type' => '', 'open_graph' => array('og_title' => 'my title', 'og_description' => 'desc'))); + ->willReturn(array( + 'html' => false, + 'title' => '', + 'url' => '', + 'content_type' => '', + 'language' => '', + 'open_graph' => array( + 'og_title' => 'my title', + 'og_description' => 'desc', + ), + )); - $proxy = new ContentProxy($graby); - $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); + $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); + $entry = $proxy->updateEntry(new Entry(new User()), 'http://domain.io'); - $this->assertEquals('http://0.0.0.0', $entry->getUrl()); + $this->assertEquals('http://domain.io', $entry->getUrl()); $this->assertEquals('my title', $entry->getTitle()); $this->assertEquals('

Unable to retrieve readable content.

But we found a short description:

desc', $entry->getContent()); $this->assertEmpty($entry->getPreviewPicture()); + $this->assertEmpty($entry->getLanguage()); $this->assertEmpty($entry->getMimetype()); + $this->assertEquals(0.0, $entry->getReadingTime()); + $this->assertEquals('domain.io', $entry->getDomainName()); } public function testWithContent() { + $tagger = $this->getTaggerMock(); + $tagger->expects($this->once()) + ->method('tag'); + $graby = $this->getMockBuilder('Graby\Graby') ->setMethods(array('fetchContent')) ->disableOriginalConstructor() @@ -61,10 +95,11 @@ class ContentProxyTest extends KernelTestCase $graby->expects($this->any()) ->method('fetchContent') ->willReturn(array( - 'html' => 'this is my content', + 'html' => str_repeat('this is my content', 325), 'title' => 'this is my title', 'url' => 'http://1.1.1.1', 'content_type' => 'text/html', + 'language' => 'fr', 'open_graph' => array( 'og_title' => 'my OG title', 'og_description' => 'OG desc', @@ -72,13 +107,29 @@ class ContentProxyTest extends KernelTestCase ), )); - $proxy = new ContentProxy($graby); + $proxy = new ContentProxy($graby, $tagger, $this->getLogger()); $entry = $proxy->updateEntry(new Entry(new User()), 'http://0.0.0.0'); $this->assertEquals('http://1.1.1.1', $entry->getUrl()); $this->assertEquals('this is my title', $entry->getTitle()); - $this->assertEquals('this is my content', $entry->getContent()); + $this->assertContains('this is my content', $entry->getContent()); $this->assertEquals('http://3.3.3.3/cover.jpg', $entry->getPreviewPicture()); $this->assertEquals('text/html', $entry->getMimetype()); + $this->assertEquals('fr', $entry->getLanguage()); + $this->assertEquals(4.0, $entry->getReadingTime()); + $this->assertEquals('1.1.1.1', $entry->getDomainName()); + } + + private function getTaggerMock() + { + return $this->getMockBuilder('Wallabag\CoreBundle\Helper\RuleBasedTagger') + ->setMethods(array('tag')) + ->disableOriginalConstructor() + ->getMock(); + } + + private function getLogger() + { + return new NullLogger(); } }