X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=src%2FWallabag%2FCoreBundle%2FController%2FTagController.php;h=16ded948eedc8db07f06355f34c96507f9888409;hb=48f9a9632d2823be38883628ddfe62344cc282b1;hp=72822479794efa8ce426c4ca72c364834a9217f0;hpb=25203e5081c8da21869db1d16610f83f888249b5;p=github%2Fwallabag%2Fwallabag.git diff --git a/src/Wallabag/CoreBundle/Controller/TagController.php b/src/Wallabag/CoreBundle/Controller/TagController.php index 72822479..16ded948 100644 --- a/src/Wallabag/CoreBundle/Controller/TagController.php +++ b/src/Wallabag/CoreBundle/Controller/TagController.php @@ -4,20 +4,18 @@ namespace Wallabag\CoreBundle\Controller; use Pagerfanta\Adapter\ArrayAdapter; use Pagerfanta\Exception\OutOfRangeCurrentPageException; -use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; +use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter; use Symfony\Bundle\FrameworkBundle\Controller\Controller; use Symfony\Component\HttpFoundation\Request; +use Symfony\Component\Routing\Annotation\Route; use Wallabag\CoreBundle\Entity\Entry; use Wallabag\CoreBundle\Entity\Tag; use Wallabag\CoreBundle\Form\Type\NewTagType; -use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter; +use Wallabag\CoreBundle\Form\Type\RenameTagType; class TagController extends Controller { /** - * @param Request $request - * @param Entry $entry - * * @Route("/new-tag/{entry}", requirements={"entry" = "\d+"}, name="new_tag") * * @return \Symfony\Component\HttpFoundation\Response @@ -65,7 +63,7 @@ class TagController extends Controller $em->flush(); // remove orphan tag in case no entries are associated to it - if (count($tag->getEntries()) === 0) { + if (0 === \count($tag->getEntries())) { $em->remove($tag); $em->flush(); } @@ -84,33 +82,24 @@ class TagController extends Controller */ public function showTagAction() { - $repository = $this->get('wallabag_core.entry_repository'); $tags = $this->get('wallabag_core.tag_repository') - ->findAllTags($this->getUser()->getId()); - - $flatTags = []; + ->findAllFlatTagsWithNbEntries($this->getUser()->getId()); + $nbEntriesUntagged = $this->get('wallabag_core.entry_repository') + ->countUntaggedEntriesByUser($this->getUser()->getId()); + $renameForms = []; foreach ($tags as $tag) { - $nbEntries = $repository->countAllEntriesByUserIdAndTagId( - $this->getUser()->getId(), - $tag->getId() - ); - - $flatTags[] = [ - 'id' => $tag->getId(), - 'label' => $tag->getLabel(), - 'slug' => $tag->getSlug(), - 'nbEntries' => $nbEntries, - ]; + $renameForms[$tag['id']] = $this->createForm(RenameTagType::class, new Tag())->createView(); } return $this->render('WallabagCoreBundle:Tag:tags.html.twig', [ - 'tags' => $flatTags, + 'tags' => $tags, + 'renameForms' => $renameForms, + 'nbEntriesUntagged' => $nbEntriesUntagged, ]); } /** - * @param Tag $tag * @param int $page * * @Route("/tag/list/{slug}/{page}", name="tag_entries", defaults={"page" = "1"}) @@ -144,7 +133,61 @@ class TagController extends Controller 'form' => null, 'entries' => $entries, 'currentPage' => $page, - 'tag' => $tag->getSlug(), + 'tag' => $tag, ]); } + + /** + * Rename a given tag with a new label + * Create a new tag with the new name and drop the old one. + * + * @Route("/tag/rename/{slug}", name="tag_rename") + * @ParamConverter("tag", options={"mapping": {"slug": "slug"}}) + * + * @return \Symfony\Component\HttpFoundation\Response + */ + public function renameTagAction(Tag $tag, Request $request) + { + $form = $this->createForm(RenameTagType::class, new Tag()); + $form->handleRequest($request); + + $redirectUrl = $this->get('wallabag_core.helper.redirect')->to($request->headers->get('referer'), '', true); + + if ($form->isSubmitted() && $form->isValid()) { + $newTag = new Tag(); + $newTag->setLabel($form->get('label')->getData()); + + if ($newTag->getLabel() === $tag->getLabel()) { + return $this->redirect($redirectUrl); + } + + $tagFromRepo = $this->get('wallabag_core.tag_repository')->findOneByLabel($newTag->getLabel()); + + if (null !== $tagFromRepo) { + $newTag = $tagFromRepo; + } + + $entries = $this->get('wallabag_core.entry_repository')->findAllByTagId( + $this->getUser()->getId(), + $tag->getId() + ); + foreach ($entries as $entry) { + $this->get('wallabag_core.tags_assigner')->assignTagsToEntry( + $entry, + $newTag->getLabel(), + [$newTag] + ); + $entry->removeTag($tag); + } + + $this->getDoctrine()->getManager()->flush(); + + $this->get('session')->getFlashBag()->add( + 'notice', + 'flashes.tag.notice.tag_renamed' + ); + } + + return $this->redirect($redirectUrl); + } }