X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=src%2FWallabag%2FCoreBundle%2FController%2FEntryController.php;h=4a7a0644a364b851942537b2b9fe44c65d2c3357;hb=9b9b05008a96a45bbf6da4c0c1c1b1244b83c6af;hp=5378486ae458d5a68208368ba503db89b0c4d099;hpb=2a94b1d1b74b4e776e76a522621b67b45d115fe7;p=github%2Fwallabag%2Fwallabag.git diff --git a/src/Wallabag/CoreBundle/Controller/EntryController.php b/src/Wallabag/CoreBundle/Controller/EntryController.php index 5378486a..4a7a0644 100644 --- a/src/Wallabag/CoreBundle/Controller/EntryController.php +++ b/src/Wallabag/CoreBundle/Controller/EntryController.php @@ -7,23 +7,23 @@ use Symfony\Bundle\FrameworkBundle\Controller\Controller; use Symfony\Component\HttpFoundation\Request; use Wallabag\CoreBundle\Entity\Entry; use Wallabag\CoreBundle\Service\Extractor; -use Wallabag\CoreBundle\Helper\Url; +use Wallabag\CoreBundle\Form\Type\NewEntryType; +use Wallabag\CoreBundle\Form\Type\EditEntryType; class EntryController extends Controller { /** - * @param Request $request + * @param Request $request + * * @Route("/new", name="new_entry") + * * @return \Symfony\Component\HttpFoundation\Response */ public function addEntryAction(Request $request) { $entry = new Entry($this->getUser()); - $form = $this->createFormBuilder($entry) - ->add('url', 'url') - ->add('save', 'submit') - ->getForm(); + $form = $this->createForm(new NewEntryType(), $entry); $form->handleRequest($request); @@ -51,9 +51,46 @@ class EntryController extends Controller } /** - * Shows unread entries for current user + * Edit an entry content. + * + * @param Request $request + * @param Entry $entry + * + * @Route("/edit/{id}", requirements={"id" = "\d+"}, name="edit") + * + * @return \Symfony\Component\HttpFoundation\Response + */ + public function editEntryAction(Request $request, Entry $entry) + { + $this->checkUserAction($entry); + + $form = $this->createForm(new EditEntryType(), $entry); + + $form->handleRequest($request); + + if ($form->isValid()) { + $em = $this->getDoctrine()->getManager(); + $em->persist($entry); + $em->flush(); + + $this->get('session')->getFlashBag()->add( + 'notice', + 'Entry updated' + ); + + return $this->redirect($this->generateUrl('view', array('id' => $entry->getId()))); + } + + return $this->render('WallabagCoreBundle:Entry:edit.html.twig', array( + 'form' => $form->createView(), + )); + } + + /** + * Shows unread entries for current user. * * @Route("/unread", name="unread") + * * @return \Symfony\Component\HttpFoundation\Response */ public function showUnreadAction() @@ -70,9 +107,10 @@ class EntryController extends Controller } /** - * Shows read entries for current user + * Shows read entries for current user. * * @Route("/archive", name="archive") + * * @return \Symfony\Component\HttpFoundation\Response */ public function showArchiveAction() @@ -89,9 +127,10 @@ class EntryController extends Controller } /** - * Shows starred entries for current user + * Shows starred entries for current user. * * @Route("/starred", name="starred") + * * @return \Symfony\Component\HttpFoundation\Response */ public function showStarredAction() @@ -108,14 +147,18 @@ class EntryController extends Controller } /** - * Shows entry content + * Shows entry content. + * + * @param Entry $entry * - * @param Entry $entry * @Route("/view/{id}", requirements={"id" = "\d+"}, name="view") + * * @return \Symfony\Component\HttpFoundation\Response */ public function viewAction(Entry $entry) { + $this->checkUserAction($entry); + return $this->render( 'WallabagCoreBundle:Entry:entry.html.twig', array('entry' => $entry) @@ -123,15 +166,19 @@ class EntryController extends Controller } /** - * Changes read status for an entry + * Changes read status for an entry. + * + * @param Request $request + * @param Entry $entry * - * @param Request $request - * @param Entry $entry * @Route("/archive/{id}", requirements={"id" = "\d+"}, name="archive_entry") + * * @return \Symfony\Component\HttpFoundation\RedirectResponse */ public function toggleArchiveAction(Request $request, Entry $entry) { + $this->checkUserAction($entry); + $entry->toggleArchive(); $this->getDoctrine()->getManager()->flush(); @@ -144,15 +191,19 @@ class EntryController extends Controller } /** - * Changes favorite status for an entry + * Changes favorite status for an entry. + * + * @param Request $request + * @param Entry $entry * - * @param Request $request - * @param Entry $entry * @Route("/star/{id}", requirements={"id" = "\d+"}, name="star_entry") + * * @return \Symfony\Component\HttpFoundation\RedirectResponse */ public function toggleStarAction(Request $request, Entry $entry) { + $this->checkUserAction($entry); + $entry->toggleStar(); $this->getDoctrine()->getManager()->flush(); @@ -165,18 +216,21 @@ class EntryController extends Controller } /** - * Deletes entry + * Deletes entry. + * + * @param Request $request + * @param Entry $entry * - * @param Request $request - * @param Entry $entry * @Route("/delete/{id}", requirements={"id" = "\d+"}, name="delete_entry") + * * @return \Symfony\Component\HttpFoundation\RedirectResponse */ public function deleteEntryAction(Request $request, Entry $entry) { + $this->checkUserAction($entry); + $em = $this->getDoctrine()->getManager(); - $entry->setDeleted(1); - $em->persist($entry); + $em->remove($entry); $em->flush(); $this->get('session')->getFlashBag()->add( @@ -186,4 +240,16 @@ class EntryController extends Controller return $this->redirect($request->headers->get('referer')); } + + /** + * Check if the logged user can manage the given entry. + * + * @param Entry $entry + */ + private function checkUserAction(Entry $entry) + { + if ($this->getUser()->getId() != $entry->getUser()->getId()) { + throw $this->createAccessDeniedException('You can not access this entry.'); + } + } }