X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fclient.ts;h=253a9562432a75e047839f0997caf03cf23dd3ba;hb=1f256e7d3cf056c2d999260155cdba58ae1b878b;hp=7bcb999eacd09520dffb3a7e0fd647d7ba78e697;hpb=e5024f5181b2e8ec23a58a821671000041b5bf2b;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/client.ts b/server/tests/client.ts index 7bcb999ea..253a95624 100644 --- a/server/tests/client.ts +++ b/server/tests/client.ts @@ -2,46 +2,51 @@ import 'mocha' import * as chai from 'chai' +import { omit } from 'lodash' import * as request from 'supertest' -import { Account, VideoPlaylistPrivacy } from '@shared/models' +import { HttpStatusCode } from '@shared/core-utils/miscs/http-error-codes' +import { Account, CustomConfig, HTMLServerConfig, ServerConfig, VideoPlaylistPrivacy } from '@shared/models' import { addVideoInPlaylist, cleanupTests, createVideoPlaylist, + doubleFollow, + flushAndRunMultipleServers, getAccount, + getConfig, getCustomConfig, getVideosList, + makeGetRequest, makeHTMLRequest, ServerInfo, + setAccessTokensToServers, setDefaultVideoChannel, updateCustomConfig, updateCustomSubConfig, - uploadVideo, updateMyUser, updateVideoChannel, - doubleFollow, - flushAndRunMultipleServers, - setAccessTokensToServers + uploadVideo, + waitJobs } from '../../shared/extra-utils' -import { HttpStatusCode } from '@shared/core-utils/miscs/http-error-codes' const expect = chai.expect -function checkIndexTags (html: string, title: string, description: string, css: string) { +function checkIndexTags (html: string, title: string, description: string, css: string, config: ServerConfig) { expect(html).to.contain('' + title + '') expect(html).to.contain('') expect(html).to.contain('') + + const htmlConfig: HTMLServerConfig = omit(config, 'signup') + expect(html).to.contain(``) } describe('Test a client controllers', function () { let servers: ServerInfo[] = [] - let server: ServerInfo let account: Account - let videoUUID: string - let videoOriginalUrl: string const videoName = 'my super name for server 1' - const videoDescription = 'my super description for server 1' + const videoDescription = 'my
super __description__ for *server* 1

' + const videoDescriptionPlainText = 'my super description for server 1' const playlistName = 'super playlist name' const playlistDescription = 'super playlist description' @@ -49,36 +54,32 @@ describe('Test a client controllers', function () { const channelDescription = 'my super channel description' + const watchVideoBasePaths = [ '/videos/watch/', '/w/' ] + const watchPlaylistBasePaths = [ '/videos/watch/playlist/', '/w/p/' ] + before(async function () { this.timeout(120000) servers = await flushAndRunMultipleServers(2) - const server = servers[0] await setAccessTokensToServers(servers) - { - const res = await uploadVideo(servers[0].url, servers[0].accessToken, { name: 'video' }) - videoUUID = res.body.video.uuid - videoOriginalUrl = res.body.video.url - } - await doubleFollow(servers[0], servers[1]) - await setDefaultVideoChannel([ server ]) + await setDefaultVideoChannel(servers) - await updateVideoChannel(server.url, server.accessToken, server.videoChannel.name, { description: channelDescription }) + await updateVideoChannel(servers[0].url, servers[0].accessToken, servers[0].videoChannel.name, { description: channelDescription }) // Video const videoAttributes = { name: videoName, description: videoDescription } - await uploadVideo(server.url, server.accessToken, videoAttributes) + await uploadVideo(servers[0].url, servers[0].accessToken, videoAttributes) - const resVideosRequest = await getVideosList(server.url) + const resVideosRequest = await getVideosList(servers[0].url) const videos = resVideosRequest.body.data expect(videos.length).to.equal(1) - server.video = videos[0] + servers[0].video = videos[0] // Playlist @@ -86,237 +87,296 @@ describe('Test a client controllers', function () { displayName: playlistName, description: playlistDescription, privacy: VideoPlaylistPrivacy.PUBLIC, - videoChannelId: server.videoChannel.id + videoChannelId: servers[0].videoChannel.id } - const resVideoPlaylistRequest = await createVideoPlaylist({ url: server.url, token: server.accessToken, playlistAttrs }) + const resVideoPlaylistRequest = await createVideoPlaylist({ url: servers[0].url, token: servers[0].accessToken, playlistAttrs }) const playlist = resVideoPlaylistRequest.body.videoPlaylist const playlistId = playlist.id playlistUUID = playlist.uuid await addVideoInPlaylist({ - url: server.url, - token: server.accessToken, + url: servers[0].url, + token: servers[0].accessToken, playlistId, - elementAttrs: { videoId: server.video.id } + elementAttrs: { videoId: servers[0].video.id } }) // Account - await updateMyUser({ url: server.url, accessToken: server.accessToken, description: 'my account description' }) + await updateMyUser({ url: servers[0].url, accessToken: servers[0].accessToken, description: 'my account description' }) - const resAccountRequest = await getAccount(server.url, `${server.user.username}@${server.host}`) + const resAccountRequest = await getAccount(servers[0].url, `${servers[0].user.username}@${servers[0].host}`) account = resAccountRequest.body + + await waitJobs(servers) }) describe('oEmbed', function () { + it('Should have valid oEmbed discovery tags for videos', async function () { - const path = '/videos/watch/' + server.video.uuid - const res = await request(server.url) - .get(path) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + for (const basePath of watchVideoBasePaths) { + const path = basePath + servers[0].video.uuid + const res = await request(servers[0].url) + .get(path) + .set('Accept', 'text/html') + .expect(HttpStatusCode.OK_200) - const port = server.port + const port = servers[0].port - const expectedLink = '` + const expectedLink = '` - expect(res.text).to.contain(expectedLink) + expect(res.text).to.contain(expectedLink) + } }) it('Should have valid oEmbed discovery tags for a playlist', async function () { - const res = await request(server.url) - .get('/videos/watch/playlist/' + playlistUUID) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + for (const basePath of watchPlaylistBasePaths) { + const res = await request(servers[0].url) + .get(basePath + playlistUUID) + .set('Accept', 'text/html') + .expect(HttpStatusCode.OK_200) - const port = server.port + const port = servers[0].port - const expectedLink = '` + const expectedLink = '` - expect(res.text).to.contain(expectedLink) + expect(res.text).to.contain(expectedLink) + } }) }) describe('Open Graph', function () { - it('Should have valid Open Graph tags on the account page', async function () { - const res = await request(server.url) - .get('/accounts/' + server.user.username) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) - - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - }) + async function accountPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - it('Should have valid Open Graph tags on the channel page', async function () { - const res = await request(server.url) - .get('/video-channels/' + server.videoChannel.name) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) - - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - }) + expect(text).to.contain(``) + expect(text).to.contain(``) + expect(text).to.contain('') + expect(text).to.contain(``) + } - it('Should have valid Open Graph tags on the watch page with video id', async function () { - const res = await request(server.url) - .get('/videos/watch/' + server.video.id) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + async function channelPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - expect(res.text).to.contain('') - expect(res.text).to.contain(``) + expect(text).to.contain(``) + expect(text).to.contain(``) + expect(text).to.contain('') + expect(text).to.contain(``) + } + + async function watchVideoPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain(``) + expect(text).to.contain(``) + expect(text).to.contain('') + expect(text).to.contain(``) + } + + async function watchPlaylistPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain(``) + expect(text).to.contain(``) + expect(text).to.contain('') + expect(text).to.contain(``) + } + + it('Should have valid Open Graph tags on the account page', async function () { + await accountPageTest('/accounts/' + servers[0].user.username) + await accountPageTest('/a/' + servers[0].user.username) + await accountPageTest('/@' + servers[0].user.username) }) - it('Should have valid Open Graph tags on the watch page with video uuid', async function () { - const res = await request(server.url) - .get('/videos/watch/' + server.video.uuid) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + it('Should have valid Open Graph tags on the channel page', async function () { + await channelPageTest('/video-channels/' + servers[0].videoChannel.name) + await channelPageTest('/c/' + servers[0].videoChannel.name) + await channelPageTest('/@' + servers[0].videoChannel.name) + }) - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - expect(res.text).to.contain('') - expect(res.text).to.contain(``) + it('Should have valid Open Graph tags on the watch page', async function () { + await watchVideoPageTest('/videos/watch/' + servers[0].video.id) + await watchVideoPageTest('/videos/watch/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.id) }) it('Should have valid Open Graph tags on the watch playlist page', async function () { - const res = await request(server.url) - .get('/videos/watch/playlist/' + playlistUUID) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) - - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - expect(res.text).to.contain('') - expect(res.text).to.contain(``) + await watchPlaylistPageTest('/videos/watch/playlist/' + playlistUUID) + await watchPlaylistPageTest('/w/p/' + playlistUUID) }) }) describe('Twitter card', async function () { - it('Should have valid twitter card on the watch video page', async function () { - const res = await request(server.url) - .get('/videos/watch/' + server.video.uuid) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + describe('Not whitelisted', function () { - expect(res.text).to.contain('') - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - }) + async function accountPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - it('Should have valid twitter card on the watch playlist page', async function () { - const res = await request(server.url) - .get('/videos/watch/playlist/' + playlistUUID) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + expect(text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain(``) + expect(text).to.contain(``) + } - expect(res.text).to.contain('') - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - }) + async function channelPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain(``) + expect(text).to.contain(``) + } - it('Should have valid twitter card on the account page', async function () { - const res = await request(server.url) - .get('/accounts/' + account.name) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + async function watchVideoPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - expect(res.text).to.contain('') - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) - }) + expect(text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain(``) + expect(text).to.contain(``) + } + + async function watchPlaylistPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain(``) + expect(text).to.contain(``) + } + + it('Should have valid twitter card on the watch video page', async function () { + await watchVideoPageTest('/videos/watch/' + servers[0].video.id) + await watchVideoPageTest('/videos/watch/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.id) + }) - it('Should have valid twitter card on the channel page', async function () { - const res = await request(server.url) - .get('/video-channels/' + server.videoChannel.name) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + it('Should have valid twitter card on the watch playlist page', async function () { + await watchPlaylistPageTest('/videos/watch/playlist/' + playlistUUID) + await watchPlaylistPageTest('/w/p/' + playlistUUID) + }) + + it('Should have valid twitter card on the account page', async function () { + await accountPageTest('/accounts/' + account.name) + await accountPageTest('/a/' + account.name) + await accountPageTest('/@' + account.name) + }) - expect(res.text).to.contain('') - expect(res.text).to.contain('') - expect(res.text).to.contain(``) - expect(res.text).to.contain(``) + it('Should have valid twitter card on the channel page', async function () { + await channelPageTest('/video-channels/' + servers[0].videoChannel.name) + await channelPageTest('/c/' + servers[0].videoChannel.name) + await channelPageTest('/@' + servers[0].videoChannel.name) + }) }) - it('Should have valid twitter card if Twitter is whitelisted', async function () { - const res1 = await getCustomConfig(server.url, server.accessToken) - const config = res1.body - config.services.twitter = { - username: '@Kuja', - whitelisted: true + describe('Whitelisted', function () { + + before(async function () { + const res = await getCustomConfig(servers[0].url, servers[0].accessToken) + const config = res.body as CustomConfig + config.services.twitter = { + username: '@Kuja', + whitelisted: true + } + + await updateCustomConfig(servers[0].url, servers[0].accessToken, config) + }) + + async function accountPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain('') + expect(text).to.contain('') + } + + async function channelPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text + + expect(text).to.contain('') + expect(text).to.contain('') } - await updateCustomConfig(server.url, server.accessToken, config) - const resVideoRequest = await request(server.url) - .get('/videos/watch/' + server.video.uuid) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + async function watchVideoPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - expect(resVideoRequest.text).to.contain('') - expect(resVideoRequest.text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain('') + } - const resVideoPlaylistRequest = await request(server.url) - .get('/videos/watch/playlist/' + playlistUUID) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + async function watchPlaylistPageTest (path: string) { + const res = await makeGetRequest({ url: servers[0].url, path, accept: 'text/html', statusCodeExpected: HttpStatusCode.OK_200 }) + const text = res.text - expect(resVideoPlaylistRequest.text).to.contain('') - expect(resVideoPlaylistRequest.text).to.contain('') + expect(text).to.contain('') + expect(text).to.contain('') + } - const resAccountRequest = await request(server.url) - .get('/accounts/' + account.name) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + it('Should have valid twitter card on the watch video page', async function () { + await watchVideoPageTest('/videos/watch/' + servers[0].video.id) + await watchVideoPageTest('/videos/watch/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.uuid) + await watchVideoPageTest('/w/' + servers[0].video.id) + }) - expect(resAccountRequest.text).to.contain('') - expect(resAccountRequest.text).to.contain('') + it('Should have valid twitter card on the watch playlist page', async function () { + await watchPlaylistPageTest('/videos/watch/playlist/' + playlistUUID) + await watchPlaylistPageTest('/w/p/' + playlistUUID) + }) - const resChannelRequest = await request(server.url) - .get('/video-channels/' + server.videoChannel.name) - .set('Accept', 'text/html') - .expect(HttpStatusCode.OK_200) + it('Should have valid twitter card on the account page', async function () { + await accountPageTest('/accounts/' + account.name) + await accountPageTest('/a/' + account.name) + await accountPageTest('/@' + account.name) + }) - expect(resChannelRequest.text).to.contain('') - expect(resChannelRequest.text).to.contain('') + it('Should have valid twitter card on the channel page', async function () { + await channelPageTest('/video-channels/' + servers[0].videoChannel.name) + await channelPageTest('/c/' + servers[0].videoChannel.name) + await channelPageTest('/@' + servers[0].videoChannel.name) + }) }) }) describe('Index HTML', function () { it('Should have valid index html tags (title, description...)', async function () { - const res = await makeHTMLRequest(server.url, '/videos/trending') + const resConfig = await getConfig(servers[0].url) + const res = await makeHTMLRequest(servers[0].url, '/videos/trending') const description = 'PeerTube, an ActivityPub-federated video streaming platform using P2P directly in your web browser.' - checkIndexTags(res.text, 'PeerTube', description, '') + checkIndexTags(res.text, 'PeerTube', description, '', resConfig.body) }) it('Should update the customized configuration and have the correct index html tags', async function () { - await updateCustomSubConfig(server.url, server.accessToken, { + await updateCustomSubConfig(servers[0].url, servers[0].accessToken, { instance: { name: 'PeerTube updated', shortDescription: 'my short description', description: 'my super description', terms: 'my super terms', - defaultClientRoute: '/videos/recently-added', defaultNSFWPolicy: 'blur', + defaultClientRoute: '/videos/recently-added', customizations: { javascript: 'alert("coucou")', css: 'body { background-color: red; }' @@ -324,24 +384,65 @@ describe('Test a client controllers', function () { } }) - const res = await makeHTMLRequest(server.url, '/videos/trending') + const resConfig = await getConfig(servers[0].url) + const res = await makeHTMLRequest(servers[0].url, '/videos/trending') - checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }') + checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', resConfig.body) }) it('Should have valid index html updated tags (title, description...)', async function () { - const res = await makeHTMLRequest(server.url, '/videos/trending') + const resConfig = await getConfig(servers[0].url) + const res = await makeHTMLRequest(servers[0].url, '/videos/trending') - checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }') + checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', resConfig.body) }) it('Should use the original video URL for the canonical tag', async function () { - const res = await makeHTMLRequest(servers[1].url, '/videos/watch/' + videoUUID) - expect(res.text).to.contain(``) + for (const basePath of watchVideoBasePaths) { + const res = await makeHTMLRequest(servers[1].url, basePath + servers[0].video.uuid) + expect(res.text).to.contain(``) + } + }) + + it('Should use the original account URL for the canonical tag', async function () { + const accountURLtest = (res) => { + expect(res.text).to.contain(``) + } + + accountURLtest(await makeHTMLRequest(servers[1].url, '/accounts/root@' + servers[0].host)) + accountURLtest(await makeHTMLRequest(servers[1].url, '/a/root@' + servers[0].host)) + accountURLtest(await makeHTMLRequest(servers[1].url, '/@root@' + servers[0].host)) + }) + + it('Should use the original channel URL for the canonical tag', async function () { + const channelURLtests = (res) => { + expect(res.text).to.contain(``) + } + + channelURLtests(await makeHTMLRequest(servers[1].url, '/video-channels/root_channel@' + servers[0].host)) + channelURLtests(await makeHTMLRequest(servers[1].url, '/c/root_channel@' + servers[0].host)) + channelURLtests(await makeHTMLRequest(servers[1].url, '/@root_channel@' + servers[0].host)) + }) + + it('Should use the original playlist URL for the canonical tag', async function () { + for (const basePath of watchPlaylistBasePaths) { + const res = await makeHTMLRequest(servers[1].url, basePath + playlistUUID) + expect(res.text).to.contain(``) + } + }) + }) + + describe('Embed HTML', function () { + + it('Should have the correct embed html tags', async function () { + const resConfig = await getConfig(servers[0].url) + const res = await makeHTMLRequest(servers[0].url, servers[0].video.embedPath) + + checkIndexTags(res.text, 'PeerTube updated', 'my short description', 'body { background-color: red; }', resConfig.body) }) }) after(async function () { - await cleanupTests([ server ]) + await cleanupTests(servers) }) })