X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fvideos%2Fvideo-transcoder.ts;h=f88c59f0d6edf38cdb25bdf737b71ec108ae2999;hb=f2eb23cd87cf32b8fe545178143b5f49e06a58da;hp=90ade16525aa35ae059ad90f7325e255c26420a9;hpb=86aafd06f2d124786ea3d10477f356c2e3f85dd6;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/videos/video-transcoder.ts b/server/tests/api/videos/video-transcoder.ts index 90ade1652..f88c59f0d 100644 --- a/server/tests/api/videos/video-transcoder.ts +++ b/server/tests/api/videos/video-transcoder.ts @@ -1,29 +1,43 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import * as chai from 'chai' import 'mocha' +import * as chai from 'chai' +import { FfprobeData } from 'fluent-ffmpeg' import { omit } from 'lodash' -import { getMaxBitrate, VideoDetails, VideoResolution, VideoState } from '../../../../shared/models/videos' -import { audio, canDoQuickTranscode, getVideoFileBitrate, getVideoFileFPS, getVideoFileResolution } from '../../../helpers/ffmpeg-utils' +import { join } from 'path' +import { VIDEO_TRANSCODING_FPS } from '../../../../server/initializers/constants' import { buildAbsoluteFixturePath, + buildServerDirectory, cleanupTests, doubleFollow, flushAndRunMultipleServers, generateHighBitrateVideo, + generateVideoWithFramerate, getMyVideos, + getServerFileSize, getVideo, + getVideoFileMetadataUrl, getVideosList, makeGetRequest, - root, ServerInfo, setAccessTokensToServers, + updateCustomSubConfig, uploadVideo, + uploadVideoAndGetId, waitJobs, webtorrentAdd } from '../../../../shared/extra-utils' -import { join } from 'path' -import { VIDEO_TRANSCODING_FPS } from '../../../../server/initializers/constants' +import { getMaxBitrate, VideoDetails, VideoResolution, VideoState } from '../../../../shared/models/videos' +import { + canDoQuickTranscode, + getAudioStream, + getMetadataFromFile, + getVideoFileBitrate, + getVideoFileFPS, + getVideoFileResolution +} from '../../../helpers/ffprobe-utils' +import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes' const expect = chai.expect @@ -55,24 +69,24 @@ describe('Test video transcoding', function () { for (const server of servers) { const res = await getVideosList(server.url) - const video = res.body.data[ 0 ] + const video = res.body.data[0] const res2 = await getVideo(server.url, video.id) const videoDetails = res2.body expect(videoDetails.files).to.have.lengthOf(1) - const magnetUri = videoDetails.files[ 0 ].magnetUri + const magnetUri = videoDetails.files[0].magnetUri expect(magnetUri).to.match(/\.webm/) const torrent = await webtorrentAdd(magnetUri, true) expect(torrent.files).to.be.an('array') expect(torrent.files.length).to.equal(1) - expect(torrent.files[ 0 ].path).match(/\.webm$/) + expect(torrent.files[0].path).match(/\.webm$/) } }) it('Should transcode video on server 2', async function () { - this.timeout(60000) + this.timeout(120000) const videoAttributes = { name: 'my super name for server 2', @@ -92,13 +106,13 @@ describe('Test video transcoding', function () { expect(videoDetails.files).to.have.lengthOf(4) - const magnetUri = videoDetails.files[ 0 ].magnetUri + const magnetUri = videoDetails.files[0].magnetUri expect(magnetUri).to.match(/\.mp4/) const torrent = await webtorrentAdd(magnetUri, true) expect(torrent.files).to.be.an('array') expect(torrent.files.length).to.equal(1) - expect(torrent.files[ 0 ].path).match(/\.mp4$/) + expect(torrent.files[0].path).match(/\.mp4$/) } }) @@ -122,12 +136,12 @@ describe('Test video transcoding', function () { expect(videoDetails.files).to.have.lengthOf(4) - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-240.mp4') - const probe = await audio.get(path) + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-240.mp4')) + const probe = await getAudioStream(path) if (probe.audioStream) { - expect(probe.audioStream[ 'codec_name' ]).to.be.equal('aac') - expect(probe.audioStream[ 'bit_rate' ]).to.be.at.most(384 * 8000) + expect(probe.audioStream['codec_name']).to.be.equal('aac') + expect(probe.audioStream['bit_rate']).to.be.at.most(384 * 8000) } else { this.fail('Could not retrieve the audio stream on ' + probe.absolutePath) } @@ -153,8 +167,8 @@ describe('Test video transcoding', function () { const videoDetails: VideoDetails = res2.body expect(videoDetails.files).to.have.lengthOf(4) - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-240.mp4') - const probe = await audio.get(path) + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-240.mp4')) + const probe = await getAudioStream(path) expect(probe).to.not.have.property('audioStream') } }) @@ -178,10 +192,13 @@ describe('Test video transcoding', function () { const videoDetails: VideoDetails = res2.body expect(videoDetails.files).to.have.lengthOf(4) + const fixturePath = buildAbsoluteFixturePath(videoAttributes.fixture) - const fixtureVideoProbe = await audio.get(fixturePath) - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-240.mp4') - const videoProbe = await audio.get(path) + const fixtureVideoProbe = await getAudioStream(fixturePath) + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-240.mp4')) + + const videoProbe = await getAudioStream(path) + if (videoProbe.audioStream && fixtureVideoProbe.audioStream) { const toOmit = [ 'max_bit_rate', 'duration', 'duration_ts', 'nb_frames', 'start_time', 'start_pts' ] expect(omit(videoProbe.audioStream, toOmit)).to.be.deep.equal(omit(fixtureVideoProbe.audioStream, toOmit)) @@ -211,19 +228,19 @@ describe('Test video transcoding', function () { const videoDetails: VideoDetails = res2.body expect(videoDetails.files).to.have.lengthOf(4) - expect(videoDetails.files[ 0 ].fps).to.be.above(58).and.below(62) - expect(videoDetails.files[ 1 ].fps).to.be.below(31) - expect(videoDetails.files[ 2 ].fps).to.be.below(31) - expect(videoDetails.files[ 3 ].fps).to.be.below(31) + expect(videoDetails.files[0].fps).to.be.above(58).and.below(62) + expect(videoDetails.files[1].fps).to.be.below(31) + expect(videoDetails.files[2].fps).to.be.below(31) + expect(videoDetails.files[3].fps).to.be.below(31) for (const resolution of [ '240', '360', '480' ]) { - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-' + resolution + '.mp4') + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-' + resolution + '.mp4')) const fps = await getVideoFileFPS(path) expect(fps).to.be.below(31) } - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-720.mp4') + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-720.mp4')) const fps = await getVideoFileFPS(path) expect(fps).to.be.above(58).and.below(62) @@ -231,7 +248,7 @@ describe('Test video transcoding', function () { }) it('Should wait for transcoding before publishing the video', async function () { - this.timeout(80000) + this.timeout(160000) { // Upload the video, but wait transcoding @@ -240,11 +257,11 @@ describe('Test video transcoding', function () { fixture: 'video_short1.webm', waitTranscoding: true } - const resVideo = await uploadVideo(servers[ 1 ].url, servers[ 1 ].accessToken, videoAttributes) + const resVideo = await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributes) const videoId = resVideo.body.video.uuid // Should be in transcode state - const { body } = await getVideo(servers[ 1 ].url, videoId) + const { body } = await getVideo(servers[1].url, videoId) expect(body.name).to.equal('waiting video') expect(body.state.id).to.equal(VideoState.TO_TRANSCODE) expect(body.state.label).to.equal('To transcode') @@ -264,7 +281,7 @@ describe('Test video transcoding', function () { expect(videoToFindInList).to.be.undefined // Server 1 should not have the video yet - await getVideo(servers[0].url, videoId, 404) + await getVideo(servers[0].url, videoId, HttpStatusCode.NOT_FOUND_404) } await waitJobs(servers) @@ -292,7 +309,7 @@ describe('Test video transcoding', function () { tempFixturePath = await generateHighBitrateVideo() const bitrate = await getVideoFileBitrate(tempFixturePath) - expect(bitrate).to.be.above(getMaxBitrate(VideoResolution.H_1080P, 60, VIDEO_TRANSCODING_FPS)) + expect(bitrate).to.be.above(getMaxBitrate(VideoResolution.H_1080P, 25, VIDEO_TRANSCODING_FPS)) } const videoAttributes = { @@ -310,8 +327,9 @@ describe('Test video transcoding', function () { const video = res.body.data.find(v => v.name === videoAttributes.name) - for (const resolution of ['240', '360', '480', '720', '1080']) { - const path = join(root(), 'test' + servers[1].internalServerNumber, 'videos', video.uuid + '-' + resolution + '.mp4') + for (const resolution of [ '240', '360', '480', '720', '1080' ]) { + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-' + resolution + '.mp4')) + const bitrate = await getVideoFileBitrate(path) const fps = await getVideoFileFPS(path) const resolution2 = await getVideoFileResolution(path) @@ -331,7 +349,7 @@ describe('Test video transcoding', function () { tempFixturePath = await generateHighBitrateVideo() const bitrate = await getVideoFileBitrate(tempFixturePath) - expect(bitrate).to.be.above(getMaxBitrate(VideoResolution.H_1080P, 60, VIDEO_TRANSCODING_FPS)) + expect(bitrate).to.be.above(getMaxBitrate(VideoResolution.H_1080P, 25, VIDEO_TRANSCODING_FPS)) } for (const fixture of [ 'video_short.mkv', 'video_short.avi' ]) { @@ -340,7 +358,7 @@ describe('Test video transcoding', function () { fixture } - await uploadVideo(servers[ 1 ].url, servers[ 1 ].accessToken, videoAttributes) + await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributes) await waitJobs(servers) @@ -353,7 +371,7 @@ describe('Test video transcoding', function () { expect(videoDetails.files).to.have.lengthOf(4) - const magnetUri = videoDetails.files[ 0 ].magnetUri + const magnetUri = videoDetails.files[0].magnetUri expect(magnetUri).to.contain('.mp4') } } @@ -370,7 +388,7 @@ describe('Test video transcoding', function () { this.timeout(60000) const videoAttributesArg = { name: 'audio_with_preview', previewfile: 'preview.jpg', fixture: 'sample.ogg' } - await uploadVideo(servers[ 1 ].url, servers[ 1 ].accessToken, videoAttributesArg) + await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributesArg) await waitJobs(servers) @@ -383,10 +401,10 @@ describe('Test video transcoding', function () { expect(videoDetails.files).to.have.lengthOf(1) - await makeGetRequest({ url: server.url, path: videoDetails.thumbnailPath, statusCodeExpected: 200 }) - await makeGetRequest({ url: server.url, path: videoDetails.previewPath, statusCodeExpected: 200 }) + await makeGetRequest({ url: server.url, path: videoDetails.thumbnailPath, statusCodeExpected: HttpStatusCode.OK_200 }) + await makeGetRequest({ url: server.url, path: videoDetails.previewPath, statusCodeExpected: HttpStatusCode.OK_200 }) - const magnetUri = videoDetails.files[ 0 ].magnetUri + const magnetUri = videoDetails.files[0].magnetUri expect(magnetUri).to.contain('.mp4') } }) @@ -395,7 +413,7 @@ describe('Test video transcoding', function () { this.timeout(60000) const videoAttributesArg = { name: 'audio_without_preview', fixture: 'sample.ogg' } - await uploadVideo(servers[ 1 ].url, servers[ 1 ].accessToken, videoAttributesArg) + await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributesArg) await waitJobs(servers) @@ -408,14 +426,147 @@ describe('Test video transcoding', function () { expect(videoDetails.files).to.have.lengthOf(1) - await makeGetRequest({ url: server.url, path: videoDetails.thumbnailPath, statusCodeExpected: 200 }) - await makeGetRequest({ url: server.url, path: videoDetails.previewPath, statusCodeExpected: 200 }) + await makeGetRequest({ url: server.url, path: videoDetails.thumbnailPath, statusCodeExpected: HttpStatusCode.OK_200 }) + await makeGetRequest({ url: server.url, path: videoDetails.previewPath, statusCodeExpected: HttpStatusCode.OK_200 }) - const magnetUri = videoDetails.files[ 0 ].magnetUri + const magnetUri = videoDetails.files[0].magnetUri expect(magnetUri).to.contain('.mp4') } }) + it('Should downscale to the closest divisor standard framerate', async function () { + this.timeout(200000) + + let tempFixturePath: string + + { + tempFixturePath = await generateVideoWithFramerate(59) + + const fps = await getVideoFileFPS(tempFixturePath) + expect(fps).to.be.equal(59) + } + + const videoAttributes = { + name: '59fps video', + description: '59fps video', + fixture: tempFixturePath + } + + await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributes) + + await waitJobs(servers) + + for (const server of servers) { + const res = await getVideosList(server.url) + + const video = res.body.data.find(v => v.name === videoAttributes.name) + + { + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-240.mp4')) + const fps = await getVideoFileFPS(path) + expect(fps).to.be.equal(25) + } + + { + const path = buildServerDirectory(servers[1], join('videos', video.uuid + '-720.mp4')) + const fps = await getVideoFileFPS(path) + expect(fps).to.be.equal(59) + } + } + }) + + it('Should not transcode to an higher bitrate than the original file', async function () { + this.timeout(160000) + + const config = { + transcoding: { + enabled: true, + resolutions: { + '240p': true, + '360p': true, + '480p': true, + '720p': true, + '1080p': true + }, + webtorrent: { enabled: true }, + hls: { enabled: true } + } + } + await updateCustomSubConfig(servers[1].url, servers[1].accessToken, config) + + const videoAttributes = { + name: 'low bitrate', + fixture: 'low-bitrate.mp4' + } + + const resUpload = await uploadVideo(servers[1].url, servers[1].accessToken, videoAttributes) + const videoUUID = resUpload.body.video.uuid + + await waitJobs(servers) + + const resolutions = [ 240, 360, 480, 720, 1080 ] + for (const r of resolutions) { + expect(await getServerFileSize(servers[1], `videos/${videoUUID}-${r}.mp4`)).to.be.below(60000) + } + }) + + it('Should provide valid ffprobe data', async function () { + this.timeout(160000) + + const videoUUID = (await uploadVideoAndGetId({ server: servers[1], videoName: 'ffprobe data' })).uuid + await waitJobs(servers) + + { + const path = buildServerDirectory(servers[1], join('videos', videoUUID + '-240.mp4')) + const metadata = await getMetadataFromFile(path) + + // expected format properties + for (const p of [ + 'tags.encoder', + 'format_long_name', + 'size', + 'bit_rate' + ]) { + expect(metadata.format).to.have.nested.property(p) + } + + // expected stream properties + for (const p of [ + 'codec_long_name', + 'profile', + 'width', + 'height', + 'display_aspect_ratio', + 'avg_frame_rate', + 'pix_fmt' + ]) { + expect(metadata.streams[0]).to.have.nested.property(p) + } + + expect(metadata).to.not.have.nested.property('format.filename') + } + + for (const server of servers) { + const res2 = await getVideo(server.url, videoUUID) + const videoDetails: VideoDetails = res2.body + + const videoFiles = videoDetails.files + .concat(videoDetails.streamingPlaylists[0].files) + expect(videoFiles).to.have.lengthOf(8) + + for (const file of videoFiles) { + expect(file.metadata).to.be.undefined + expect(file.metadataUrl).to.exist + expect(file.metadataUrl).to.contain(servers[1].url) + expect(file.metadataUrl).to.contain(videoUUID) + + const res3 = await getVideoFileMetadataUrl(file.metadataUrl) + const metadata: FfprobeData = res3.body + expect(metadata).to.have.nested.property('format.size') + } + } + }) + after(async function () { await cleanupTests(servers) })