X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fvideos%2Fvideo-channels.ts;h=8650987777f77745ea7d1cbe1f02d3a478626eb8;hb=57f879a540551c3b958b0991c8e1e3657a4481d8;hp=8138c65d60528015c2b274641232f9e958ed71ab;hpb=8a19bee1a1ee39f973bb37429e4f73c3f2873cdb;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/videos/video-channels.ts b/server/tests/api/videos/video-channels.ts index 8138c65d6..865098777 100644 --- a/server/tests/api/videos/video-channels.ts +++ b/server/tests/api/videos/video-channels.ts @@ -1,61 +1,71 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import * as chai from 'chai' import 'mocha' -import { User, Video } from '../../../../shared/index' +import * as chai from 'chai' +import { basename } from 'path' +import { ACTOR_IMAGES_SIZE } from '@server/initializers/constants' import { + cleanupTests, createUser, + deleteVideoChannelImage, doubleFollow, flushAndRunMultipleServers, - getVideoChannelVideos, serverLogin, testImage, + getActorImage, + getVideo, + getVideoChannel, + getVideoChannelVideos, + setDefaultVideoChannel, + testFileExistsOrNot, + testImage, updateVideo, - updateVideoChannelAvatar, - uploadVideo, wait, userLogin -} from '../../utils' + updateVideoChannelImage, + uploadVideo, + userLogin, + wait +} from '../../../../shared/extra-utils' import { addVideoChannel, deleteVideoChannel, - flushTests, getAccountVideoChannelsList, getMyUserInformation, - getVideoChannel, getVideoChannelsList, - killallServers, ServerInfo, setAccessTokensToServers, - updateVideoChannel -} from '../../utils/index' -import { waitJobs } from '../../utils/server/jobs' + updateVideoChannel, + viewVideo +} from '../../../../shared/extra-utils/index' +import { waitJobs } from '../../../../shared/extra-utils/server/jobs' +import { User, Video, VideoChannel, VideoDetails } from '../../../../shared/index' const expect = chai.expect +async function findChannel (server: ServerInfo, channelId: number) { + const res = await getVideoChannelsList(server.url, 0, 5, '-name') + const videoChannel = res.body.data.find(c => c.id === channelId) + + return videoChannel as VideoChannel +} + describe('Test video channels', function () { let servers: ServerInfo[] let userInfo: User - let accountUUID: string - let firstVideoChannelId: number let secondVideoChannelId: number + let totoChannel: number let videoUUID: string + let accountName: string - before(async function () { - this.timeout(30000) + const avatarPaths: { [ port: number ]: string } = {} + const bannerPaths: { [ port: number ]: string } = {} - await flushTests() + before(async function () { + this.timeout(60000) servers = await flushAndRunMultipleServers(2) await setAccessTokensToServers(servers) - await doubleFollow(servers[0], servers[1]) - - { - const res = await getMyUserInformation(servers[0].url, servers[0].accessToken) - const user: User = res.body - accountUUID = user.account.uuid - - firstVideoChannelId = user.videoChannels[0].id - } + await setDefaultVideoChannel(servers) - await waitJobs(servers) + await doubleFollow(servers[0], servers[1]) }) it('Should have one video channel (created with root)', async () => { @@ -76,13 +86,14 @@ describe('Test video channels', function () { description: 'super video channel description', support: 'super video channel support text' } - const res = await addVideoChannel(servers[ 0 ].url, servers[ 0 ].accessToken, videoChannel) + const res = await addVideoChannel(servers[0].url, servers[0].accessToken, videoChannel) secondVideoChannelId = res.body.videoChannel.id } // The channel is 1 is propagated to servers 2 { - const res = await uploadVideo(servers[ 0 ].url, servers[ 0 ].accessToken, { name: 'my video name', channelId: secondVideoChannelId }) + const videoAttributesArg = { name: 'my video name', channelId: secondVideoChannelId, support: 'video support field' } + const res = await uploadVideo(servers[0].url, servers[0].accessToken, videoAttributesArg) videoUUID = res.body.video.uuid } @@ -104,10 +115,16 @@ describe('Test video channels', function () { expect(videoChannels[1].displayName).to.equal('second video channel') expect(videoChannels[1].description).to.equal('super video channel description') expect(videoChannels[1].support).to.equal('super video channel support text') + + accountName = userInfo.account.name + '@' + userInfo.account.host }) it('Should have two video channels when getting account channels on server 1', async function () { - const res = await getAccountVideoChannelsList(servers[0].url, userInfo.account.name + '@' + userInfo.account.host) + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName + }) + expect(res.body.total).to.equal(2) expect(res.body.data).to.be.an('array') expect(res.body.data).to.have.lengthOf(2) @@ -122,8 +139,62 @@ describe('Test video channels', function () { expect(videoChannels[1].support).to.equal('super video channel support text') }) + it('Should paginate and sort account channels', async function () { + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + start: 0, + count: 1, + sort: 'createdAt' + }) + + expect(res.body.total).to.equal(2) + expect(res.body.data).to.have.lengthOf(1) + + const videoChannel: VideoChannel = res.body.data[0] + expect(videoChannel.name).to.equal('root_channel') + } + + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + start: 0, + count: 1, + sort: '-createdAt' + }) + + expect(res.body.total).to.equal(2) + expect(res.body.data).to.have.lengthOf(1) + + const videoChannel: VideoChannel = res.body.data[0] + expect(videoChannel.name).to.equal('second_video_channel') + } + + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + start: 1, + count: 1, + sort: '-createdAt' + }) + + expect(res.body.total).to.equal(2) + expect(res.body.data).to.have.lengthOf(1) + + const videoChannel: VideoChannel = res.body.data[0] + expect(videoChannel.name).to.equal('root_channel') + } + }) + it('Should have one video channel when getting account channels on server 2', async function () { - const res = await getAccountVideoChannelsList(servers[1].url, userInfo.account.name + '@' + userInfo.account.host) + const res = await getAccountVideoChannelsList({ + url: servers[1].url, + accountName + }) + expect(res.body.total).to.equal(1) expect(res.body.data).to.be.an('array') expect(res.body.data).to.have.lengthOf(1) @@ -146,12 +217,12 @@ describe('Test video channels', function () { }) it('Should update video channel', async function () { - this.timeout(5000) + this.timeout(15000) const videoChannelAttributes = { displayName: 'video channel updated', description: 'video channel description updated', - support: 'video channel support text updated' + support: 'support updated' } await updateVideoChannel(servers[0].url, servers[0].accessToken, 'second_video_channel', videoChannelAttributes) @@ -169,50 +240,141 @@ describe('Test video channels', function () { expect(res.body.data[0].name).to.equal('second_video_channel') expect(res.body.data[0].displayName).to.equal('video channel updated') expect(res.body.data[0].description).to.equal('video channel description updated') - expect(res.body.data[0].support).to.equal('video channel support text updated') + expect(res.body.data[0].support).to.equal('support updated') + } + }) + + it('Should not have updated the video support field', async function () { + for (const server of servers) { + const res = await getVideo(server.url, videoUUID) + const video: VideoDetails = res.body + + expect(video.support).to.equal('video support field') + } + }) + + it('Should update the channel support field and update videos too', async function () { + this.timeout(35000) + + const videoChannelAttributes = { + support: 'video channel support text updated', + bulkVideosSupportUpdate: true + } + + await updateVideoChannel(servers[0].url, servers[0].accessToken, 'second_video_channel', videoChannelAttributes) + + await waitJobs(servers) + + for (const server of servers) { + const res = await getVideo(server.url, videoUUID) + const video: VideoDetails = res.body + + expect(video.support).to.equal(videoChannelAttributes.support) } }) it('Should update video channel avatar', async function () { - this.timeout(5000) + this.timeout(15000) const fixture = 'avatar.png' - await updateVideoChannelAvatar({ + await updateVideoChannelImage({ url: servers[0].url, accessToken: servers[0].accessToken, videoChannelName: 'second_video_channel', - fixture + fixture, + type: 'avatar' }) await waitJobs(servers) + + for (const server of servers) { + const videoChannel = await findChannel(server, secondVideoChannelId) + + avatarPaths[server.port] = videoChannel.avatar.path + await testImage(server.url, 'avatar-resized', avatarPaths[server.port], '.png') + await testFileExistsOrNot(server, 'avatars', basename(avatarPaths[server.port]), true) + + const row = await getActorImage(server.internalServerNumber, basename(avatarPaths[server.port])) + expect(row.height).to.equal(ACTOR_IMAGES_SIZE.AVATARS.height) + expect(row.width).to.equal(ACTOR_IMAGES_SIZE.AVATARS.width) + } }) - it('Should have video channel avatar updated', async function () { + it('Should update video channel banner', async function () { + this.timeout(15000) + + const fixture = 'banner.jpg' + + await updateVideoChannelImage({ + url: servers[0].url, + accessToken: servers[0].accessToken, + videoChannelName: 'second_video_channel', + fixture, + type: 'banner' + }) + + await waitJobs(servers) + for (const server of servers) { - const res = await getVideoChannelsList(server.url, 0, 1, '-name') + const res = await getVideoChannel(server.url, 'second_video_channel@' + servers[0].host) + const videoChannel = res.body + + bannerPaths[server.port] = videoChannel.banner.path + await testImage(server.url, 'banner-resized', bannerPaths[server.port]) + await testFileExistsOrNot(server, 'avatars', basename(bannerPaths[server.port]), true) + + const row = await getActorImage(server.internalServerNumber, basename(bannerPaths[server.port])) + expect(row.height).to.equal(ACTOR_IMAGES_SIZE.BANNERS.height) + expect(row.width).to.equal(ACTOR_IMAGES_SIZE.BANNERS.width) + } + }) + + it('Should delete the video channel avatar', async function () { + this.timeout(15000) + + await deleteVideoChannelImage({ + url: servers[0].url, + accessToken: servers[0].accessToken, + videoChannelName: 'second_video_channel', + type: 'avatar' + }) - const videoChannel = res.body.data.find(c => c.id === secondVideoChannelId) + await waitJobs(servers) + + for (const server of servers) { + const videoChannel = await findChannel(server, secondVideoChannelId) + await testFileExistsOrNot(server, 'avatars', basename(avatarPaths[server.port]), false) - await testImage(server.url, 'avatar-resized', videoChannel.avatar.path, '.png') + expect(videoChannel.avatar).to.be.null } }) - it('Should get video channel', async function () { - const res = await getVideoChannel(servers[0].url, 'second_video_channel') + it('Should delete the video channel banner', async function () { + this.timeout(15000) - const videoChannel = res.body - expect(videoChannel.name).to.equal('second_video_channel') - expect(videoChannel.displayName).to.equal('video channel updated') - expect(videoChannel.description).to.equal('video channel description updated') - expect(videoChannel.support).to.equal('video channel support text updated') + await deleteVideoChannelImage({ + url: servers[0].url, + accessToken: servers[0].accessToken, + videoChannelName: 'second_video_channel', + type: 'banner' + }) + + await waitJobs(servers) + + for (const server of servers) { + const videoChannel = await findChannel(server, secondVideoChannelId) + await testFileExistsOrNot(server, 'avatars', basename(bannerPaths[server.port]), false) + + expect(videoChannel.banner).to.be.null + } }) it('Should list the second video channel videos', async function () { this.timeout(10000) for (const server of servers) { - const channelURI = 'second_video_channel@localhost:9001' + const channelURI = 'second_video_channel@localhost:' + servers[0].port const res1 = await getVideoChannelVideos(server.url, server.accessToken, channelURI, 0, 5) expect(res1.body.total).to.equal(1) expect(res1.body.data).to.be.an('array') @@ -224,7 +386,7 @@ describe('Test video channels', function () { it('Should change the video channel of a video', async function () { this.timeout(10000) - await updateVideo(servers[0].url, servers[0].accessToken, videoUUID, { channelId: firstVideoChannelId }) + await updateVideo(servers[0].url, servers[0].accessToken, videoUUID, { channelId: servers[0].videoChannel.id }) await waitJobs(servers) }) @@ -233,11 +395,11 @@ describe('Test video channels', function () { this.timeout(10000) for (const server of servers) { - const secondChannelURI = 'second_video_channel@localhost:9001' + const secondChannelURI = 'second_video_channel@localhost:' + servers[0].port const res1 = await getVideoChannelVideos(server.url, server.accessToken, secondChannelURI, 0, 5) expect(res1.body.total).to.equal(0) - const channelURI = 'root_channel@localhost:9001' + const channelURI = 'root_channel@localhost:' + servers[0].port const res2 = await getVideoChannelVideos(server.url, server.accessToken, channelURI, 0, 5) expect(res2.body.total).to.equal(1) @@ -264,20 +426,137 @@ describe('Test video channels', function () { it('Should create the main channel with an uuid if there is a conflict', async function () { { const videoChannel = { name: 'toto_channel', displayName: 'My toto channel' } - await addVideoChannel(servers[ 0 ].url, servers[ 0 ].accessToken, videoChannel) + const res = await addVideoChannel(servers[0].url, servers[0].accessToken, videoChannel) + totoChannel = res.body.videoChannel.id } { - await createUser(servers[ 0 ].url, servers[ 0 ].accessToken, 'toto', 'password') - const accessToken = await userLogin(servers[ 0 ], { username: 'toto', password: 'password' }) + await createUser({ url: servers[0].url, accessToken: servers[0].accessToken, username: 'toto', password: 'password' }) + const accessToken = await userLogin(servers[0], { username: 'toto', password: 'password' }) - const res = await getMyUserInformation(servers[ 0 ].url, accessToken) - const videoChannel = res.body.videoChannels[ 0 ] + const res = await getMyUserInformation(servers[0].url, accessToken) + const videoChannel = res.body.videoChannels[0] expect(videoChannel.name).to.match(/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}/) } }) + it('Should report correct channel views per days', async function () { + this.timeout(10000) + + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + withStats: true + }) + + const channels: VideoChannel[] = res.body.data + + for (const channel of channels) { + expect(channel).to.haveOwnProperty('viewsPerDay') + expect(channel.viewsPerDay).to.have.length(30 + 1) // daysPrior + today + + for (const v of channel.viewsPerDay) { + expect(v.date).to.be.an('string') + expect(v.views).to.equal(0) + } + } + } + + { + // video has been posted on channel servers[0].videoChannel.id since last update + await viewVideo(servers[0].url, videoUUID, 204, '0.0.0.1,127.0.0.1') + await viewVideo(servers[0].url, videoUUID, 204, '0.0.0.2,127.0.0.1') + + // Wait the repeatable job + await wait(8000) + + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + withStats: true + }) + const channelWithView = res.body.data.find((channel: VideoChannel) => channel.id === servers[0].videoChannel.id) + expect(channelWithView.viewsPerDay.slice(-1)[0].views).to.equal(2) + } + }) + + it('Should report correct videos count', async function () { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + withStats: true + }) + const channels: VideoChannel[] = res.body.data + + const totoChannel = channels.find(c => c.name === 'toto_channel') + const rootChannel = channels.find(c => c.name === 'root_channel') + + expect(rootChannel.videosCount).to.equal(1) + expect(totoChannel.videosCount).to.equal(0) + }) + + it('Should search among account video channels', async function () { + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + search: 'root' + }) + expect(res.body.total).to.equal(1) + + const channels = res.body.data + expect(channels).to.have.lengthOf(1) + } + + { + const res = await getAccountVideoChannelsList({ + url: servers[0].url, + accountName, + search: 'does not exist' + }) + expect(res.body.total).to.equal(0) + + const channels = res.body.data + expect(channels).to.have.lengthOf(0) + } + }) + + it('Should list channels by updatedAt desc if a video has been uploaded', async function () { + this.timeout(30000) + + await uploadVideo(servers[0].url, servers[0].accessToken, { channelId: totoChannel }) + await waitJobs(servers) + + for (const server of servers) { + const res = await getAccountVideoChannelsList({ + url: server.url, + accountName, + sort: '-updatedAt' + }) + + const channels: VideoChannel[] = res.body.data + expect(channels[0].name).to.equal('toto_channel') + expect(channels[1].name).to.equal('root_channel') + } + + await uploadVideo(servers[0].url, servers[0].accessToken, { channelId: servers[0].videoChannel.id }) + await waitJobs(servers) + + for (const server of servers) { + const res = await getAccountVideoChannelsList({ + url: server.url, + accountName, + sort: '-updatedAt' + }) + + const channels: VideoChannel[] = res.body.data + expect(channels[0].name).to.equal('root_channel') + expect(channels[1].name).to.equal('toto_channel') + } + }) + after(async function () { - killallServers(servers) + await cleanupTests(servers) }) })