X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fvideos%2Fvideo-abuse.ts;h=baeb543e0b939ec0b8b33948253f49685f8b8d0c;hb=17aa80ed016bafa3ccb071af3f86054033823284;hp=cd6df72672075e18ed5d1437c1cdbad801dd5dd2;hpb=a15871560f80e07386c1dabb8370cd2664ecfd1f;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/videos/video-abuse.ts b/server/tests/api/videos/video-abuse.ts index cd6df7267..baeb543e0 100644 --- a/server/tests/api/videos/video-abuse.ts +++ b/server/tests/api/videos/video-abuse.ts @@ -1,19 +1,22 @@ /* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import * as chai from 'chai' import 'mocha' -import { VideoAbuse, VideoAbuseState } from '../../../../shared/models/videos' +import * as chai from 'chai' +import { Abuse, AbusePredefinedReasonsString, AbuseState } from '@shared/models' import { cleanupTests, + createUser, deleteVideoAbuse, flushAndRunMultipleServers, getVideoAbusesList, getVideosList, + removeVideo, reportVideoAbuse, ServerInfo, setAccessTokensToServers, updateVideoAbuse, - uploadVideo + uploadVideo, + userLogin } from '../../../../shared/extra-utils/index' import { doubleFollow } from '../../../../shared/extra-utils/server/follows' import { waitJobs } from '../../../../shared/extra-utils/server/jobs' @@ -26,9 +29,11 @@ import { const expect = chai.expect +// FIXME: deprecated in 2.3. Remove this controller + describe('Test video abuses', function () { let servers: ServerInfo[] = [] - let abuseServer2: VideoAbuse + let abuseServer2: Abuse before(async function () { this.timeout(50000) @@ -68,7 +73,7 @@ describe('Test video abuses', function () { }) it('Should not have video abuses', async function () { - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(0) expect(res.body.data).to.be.an('array') @@ -86,19 +91,24 @@ describe('Test video abuses', function () { }) it('Should have 1 video abuses on server 1 and 0 on server 2', async function () { - const res1 = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res1 = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res1.body.total).to.equal(1) expect(res1.body.data).to.be.an('array') expect(res1.body.data.length).to.equal(1) - const abuse: VideoAbuse = res1.body.data[0] + const abuse: Abuse = res1.body.data[0] expect(abuse.reason).to.equal('my super bad reason') expect(abuse.reporterAccount.name).to.equal('root') expect(abuse.reporterAccount.host).to.equal('localhost:' + servers[0].port) expect(abuse.video.id).to.equal(servers[0].video.id) + expect(abuse.video.channel).to.exist + expect(abuse.video.countReports).to.equal(1) + expect(abuse.video.nthReport).to.equal(1) + expect(abuse.countReportsForReporter).to.equal(1) + expect(abuse.countReportsForReportee).to.equal(1) - const res2 = await getVideoAbusesList(servers[1].url, servers[1].accessToken) + const res2 = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) expect(res2.body.total).to.equal(0) expect(res2.body.data).to.be.an('array') expect(res2.body.data.length).to.equal(0) @@ -115,30 +125,32 @@ describe('Test video abuses', function () { }) it('Should have 2 video abuses on server 1 and 1 on server 2', async function () { - const res1 = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res1 = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res1.body.total).to.equal(2) expect(res1.body.data).to.be.an('array') expect(res1.body.data.length).to.equal(2) - const abuse1: VideoAbuse = res1.body.data[0] + const abuse1: Abuse = res1.body.data[0] expect(abuse1.reason).to.equal('my super bad reason') expect(abuse1.reporterAccount.name).to.equal('root') expect(abuse1.reporterAccount.host).to.equal('localhost:' + servers[0].port) expect(abuse1.video.id).to.equal(servers[0].video.id) - expect(abuse1.state.id).to.equal(VideoAbuseState.PENDING) + expect(abuse1.state.id).to.equal(AbuseState.PENDING) expect(abuse1.state.label).to.equal('Pending') expect(abuse1.moderationComment).to.be.null + expect(abuse1.video.countReports).to.equal(1) + expect(abuse1.video.nthReport).to.equal(1) - const abuse2: VideoAbuse = res1.body.data[1] + const abuse2: Abuse = res1.body.data[1] expect(abuse2.reason).to.equal('my super bad reason 2') expect(abuse2.reporterAccount.name).to.equal('root') expect(abuse2.reporterAccount.host).to.equal('localhost:' + servers[0].port) expect(abuse2.video.id).to.equal(servers[1].video.id) - expect(abuse2.state.id).to.equal(VideoAbuseState.PENDING) + expect(abuse2.state.id).to.equal(AbuseState.PENDING) expect(abuse2.state.label).to.equal('Pending') expect(abuse2.moderationComment).to.be.null - const res2 = await getVideoAbusesList(servers[1].url, servers[1].accessToken) + const res2 = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) expect(res2.body.total).to.equal(1) expect(res2.body.data).to.be.an('array') expect(res2.body.data.length).to.equal(1) @@ -147,25 +159,25 @@ describe('Test video abuses', function () { expect(abuseServer2.reason).to.equal('my super bad reason 2') expect(abuseServer2.reporterAccount.name).to.equal('root') expect(abuseServer2.reporterAccount.host).to.equal('localhost:' + servers[0].port) - expect(abuseServer2.state.id).to.equal(VideoAbuseState.PENDING) + expect(abuseServer2.state.id).to.equal(AbuseState.PENDING) expect(abuseServer2.state.label).to.equal('Pending') expect(abuseServer2.moderationComment).to.be.null }) it('Should update the state of a video abuse', async function () { - const body = { state: VideoAbuseState.REJECTED } + const body = { state: AbuseState.REJECTED } await updateVideoAbuse(servers[1].url, servers[1].accessToken, abuseServer2.video.uuid, abuseServer2.id, body) - const res = await getVideoAbusesList(servers[1].url, servers[1].accessToken) - expect(res.body.data[0].state.id).to.equal(VideoAbuseState.REJECTED) + const res = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) + expect(res.body.data[0].state.id).to.equal(AbuseState.REJECTED) }) it('Should add a moderation comment', async function () { - const body = { state: VideoAbuseState.ACCEPTED, moderationComment: 'It is valid' } + const body = { state: AbuseState.ACCEPTED, moderationComment: 'It is valid' } await updateVideoAbuse(servers[1].url, servers[1].accessToken, abuseServer2.video.uuid, abuseServer2.id, body) - const res = await getVideoAbusesList(servers[1].url, servers[1].accessToken) - expect(res.body.data[0].state.id).to.equal(VideoAbuseState.ACCEPTED) + const res = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) + expect(res.body.data[0].state.id).to.equal(AbuseState.ACCEPTED) expect(res.body.data[0].moderationComment).to.equal('It is valid') }) @@ -176,7 +188,7 @@ describe('Test video abuses', function () { await reportVideoAbuse(servers[1].url, servers[1].accessToken, servers[0].video.uuid, 'will mute this') await waitJobs(servers) - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(3) } @@ -185,7 +197,7 @@ describe('Test video abuses', function () { { await addAccountToServerBlocklist(servers[0].url, servers[0].accessToken, accountToBlock) - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(2) const abuse = res.body.data.find(a => a.reason === 'will mute this') @@ -195,7 +207,7 @@ describe('Test video abuses', function () { { await removeAccountFromServerBlocklist(servers[0].url, servers[0].accessToken, accountToBlock) - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(3) } }) @@ -206,7 +218,7 @@ describe('Test video abuses', function () { { await addServerToServerBlocklist(servers[0].url, servers[0].accessToken, servers[1].host) - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(2) const abuse = res.body.data.find(a => a.reason === 'will mute this') @@ -216,11 +228,97 @@ describe('Test video abuses', function () { { await removeServerFromServerBlocklist(servers[0].url, servers[0].accessToken, serverToBlock) - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) expect(res.body.total).to.equal(3) } }) + it('Should keep the video abuse when deleting the video', async function () { + this.timeout(10000) + + await removeVideo(servers[1].url, servers[1].accessToken, abuseServer2.video.uuid) + + await waitJobs(servers) + + const res = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) + expect(res.body.total).to.equal(2, "wrong number of videos returned") + expect(res.body.data.length).to.equal(2, "wrong number of videos returned") + expect(res.body.data[0].id).to.equal(abuseServer2.id, "wrong origin server id for first video") + + const abuse: Abuse = res.body.data[0] + expect(abuse.video.id).to.equal(abuseServer2.video.id, "wrong video id") + expect(abuse.video.channel).to.exist + expect(abuse.video.deleted).to.be.true + }) + + it('Should include counts of reports from reporter and reportee', async function () { + this.timeout(10000) + + // register a second user to have two reporters/reportees + const user = { username: 'user2', password: 'password' } + await createUser({ url: servers[0].url, accessToken: servers[0].accessToken, ...user }) + const userAccessToken = await userLogin(servers[0], user) + + // upload a third video via this user + const video3Attributes = { + name: 'my second super name for server 1', + description: 'my second super description for server 1' + } + await uploadVideo(servers[0].url, userAccessToken, video3Attributes) + + const res1 = await getVideosList(servers[0].url) + const videos = res1.body.data + const video3 = videos.find(video => video.name === 'my second super name for server 1') + + // resume with the test + const reason3 = 'my super bad reason 3' + await reportVideoAbuse(servers[0].url, servers[0].accessToken, video3.id, reason3) + const reason4 = 'my super bad reason 4' + await reportVideoAbuse(servers[0].url, userAccessToken, servers[0].video.id, reason4) + + const res2 = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) + + { + for (const abuse of res2.body.data as Abuse[]) { + if (abuse.video.id === video3.id) { + expect(abuse.video.countReports).to.equal(1, "wrong reports count for video 3") + expect(abuse.video.nthReport).to.equal(1, "wrong report position in report list for video 3") + expect(abuse.countReportsForReportee).to.equal(1, "wrong reports count for reporter on video 3 abuse") + expect(abuse.countReportsForReporter).to.equal(3, "wrong reports count for reportee on video 3 abuse") + } + if (abuse.video.id === servers[0].video.id) { + expect(abuse.countReportsForReportee).to.equal(3, "wrong reports count for reporter on video 1 abuse") + } + } + } + }) + + it('Should list predefined reasons as well as timestamps for the reported video', async function () { + this.timeout(10000) + + const reason5 = 'my super bad reason 5' + const predefinedReasons5: AbusePredefinedReasonsString[] = [ 'violentOrRepulsive', 'captions' ] + const createdAbuse = (await reportVideoAbuse( + servers[0].url, + servers[0].accessToken, + servers[0].video.id, + reason5, + predefinedReasons5, + 1, + 5 + )).body.abuse + + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) + + { + const abuse = (res.body.data as Abuse[]).find(a => a.id === createdAbuse.id) + expect(abuse.reason).to.equals(reason5) + expect(abuse.predefinedReasons).to.deep.equals(predefinedReasons5, "predefined reasons do not match the one reported") + expect(abuse.video.startAt).to.equal(1, "starting timestamp doesn't match the one reported") + expect(abuse.video.endAt).to.equal(5, "ending timestamp doesn't match the one reported") + } + }) + it('Should delete the video abuse', async function () { this.timeout(10000) @@ -229,18 +327,59 @@ describe('Test video abuses', function () { await waitJobs(servers) { - const res = await getVideoAbusesList(servers[1].url, servers[1].accessToken) + const res = await getVideoAbusesList({ url: servers[1].url, token: servers[1].accessToken }) expect(res.body.total).to.equal(1) expect(res.body.data.length).to.equal(1) expect(res.body.data[0].id).to.not.equal(abuseServer2.id) } { - const res = await getVideoAbusesList(servers[0].url, servers[0].accessToken) - expect(res.body.total).to.equal(3) + const res = await getVideoAbusesList({ url: servers[0].url, token: servers[0].accessToken }) + expect(res.body.total).to.equal(6) } }) + it('Should list and filter video abuses', async function () { + async function list (query: Omit[0], 'url' | 'token'>) { + const options = { + url: servers[0].url, + token: servers[0].accessToken + } + + Object.assign(options, query) + + const res = await getVideoAbusesList(options) + + return res.body.data as Abuse[] + } + + expect(await list({ id: 56 })).to.have.lengthOf(0) + expect(await list({ id: 1 })).to.have.lengthOf(1) + + expect(await list({ search: 'my super name for server 1' })).to.have.lengthOf(4) + expect(await list({ search: 'aaaaaaaaaaaaaaaaaaaaaaaaaa' })).to.have.lengthOf(0) + + expect(await list({ searchVideo: 'my second super name for server 1' })).to.have.lengthOf(1) + + expect(await list({ searchVideoChannel: 'root' })).to.have.lengthOf(4) + expect(await list({ searchVideoChannel: 'aaaa' })).to.have.lengthOf(0) + + expect(await list({ searchReporter: 'user2' })).to.have.lengthOf(1) + expect(await list({ searchReporter: 'root' })).to.have.lengthOf(5) + + expect(await list({ searchReportee: 'root' })).to.have.lengthOf(5) + expect(await list({ searchReportee: 'aaaa' })).to.have.lengthOf(0) + + expect(await list({ videoIs: 'deleted' })).to.have.lengthOf(1) + expect(await list({ videoIs: 'blacklisted' })).to.have.lengthOf(0) + + expect(await list({ state: AbuseState.ACCEPTED })).to.have.lengthOf(0) + expect(await list({ state: AbuseState.PENDING })).to.have.lengthOf(6) + + expect(await list({ predefinedReason: 'violentOrRepulsive' })).to.have.lengthOf(1) + expect(await list({ predefinedReason: 'serverRules' })).to.have.lengthOf(0) + }) + after(async function () { await cleanupTests(servers) })