X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-comments.ts;h=e67cc01fa42c4b0cd926b9046153e967a6920530;hb=2ad9dcda240ee843c5e4a5b98cc94f7b2aab2c89;hp=5112274f0f8372b12ee1c7c0eda955682d93f207;hpb=e2e22e40f91018cfaf244e0df9a4a93e4f6d0502;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-comments.ts b/server/tests/api/check-params/video-comments.ts index 5112274f0..e67cc01fa 100644 --- a/server/tests/api/check-params/video-comments.ts +++ b/server/tests/api/check-params/video-comments.ts @@ -1,42 +1,45 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ +import * as chai from 'chai' import 'mocha' -import * as request from 'supertest' import { - createUser, flushTests, getUserAccessToken, killallServers, makePostBodyRequest, runServer, ServerInfo, setAccessTokensToServers, - uploadVideo -} from '../../utils' -import { addVideoCommentThread } from '../../utils/video-comments' + cleanupTests, + createUser, + flushAndRunServer, + makeDeleteRequest, + makeGetRequest, + makePostBodyRequest, + ServerInfo, + setAccessTokensToServers, + uploadVideo, + userLogin +} from '../../../../shared/extra-utils' +import { + checkBadCountPagination, + checkBadSortPagination, + checkBadStartPagination +} from '../../../../shared/extra-utils/requests/check-api-params' +import { addVideoCommentThread } from '../../../../shared/extra-utils/videos/video-comments' + +const expect = chai.expect describe('Test video comments API validator', function () { let pathThread: string let pathComment: string let server: ServerInfo - let accessTokenUser: string let videoUUID: string + let userAccessToken: string let commentId: number // --------------------------------------------------------------- before(async function () { - this.timeout(20000) + this.timeout(30000) - await flushTests() - - server = await runServer(1) + server = await flushAndRunServer(1) await setAccessTokensToServers([ server ]) - { - const user = { - username: 'fake', - password: 'fake_password' - } - await createUser(server.url, server.accessToken, user.username, user.password) - - accessTokenUser = await getUserAccessToken(server, user) - } - { const res = await uploadVideo(server.url, server.accessToken, {}) videoUUID = res.body.video.uuid @@ -48,61 +51,62 @@ describe('Test video comments API validator', function () { commentId = res.body.comment.id pathComment = '/api/v1/videos/' + videoUUID + '/comments/' + commentId } + + { + const user = { + username: 'user1', + password: 'my super password' + } + await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password }) + userAccessToken = await userLogin(server, user) + } }) describe('When listing video comment threads', function () { it('Should fail with a bad start pagination', async function () { - await request(server.url) - .get(pathThread) - .query({ start: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadStartPagination(server.url, pathThread, server.accessToken) }) it('Should fail with a bad count pagination', async function () { - await request(server.url) - .get(pathThread) - .query({ count: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadCountPagination(server.url, pathThread, server.accessToken) }) it('Should fail with an incorrect sort', async function () { - await request(server.url) - .get(pathThread) - .query({ sort: 'hello' }) - .set('Accept', 'application/json') - .expect(400) + await checkBadSortPagination(server.url, pathThread, server.accessToken) }) it('Should fail with an incorrect video', async function () { - await request(server.url) - .get('/api/v1/videos/ba708d62-e3d7-45d9-9d73-41b9097cc02d/comment-threads') - .set('Accept', 'application/json') - .expect(404) + await makeGetRequest({ + url: server.url, + path: '/api/v1/videos/ba708d62-e3d7-45d9-9d73-41b9097cc02d/comment-threads', + statusCodeExpected: 404 + }) }) }) describe('When listing comments of a thread', function () { it('Should fail with an incorrect video', async function () { - await request(server.url) - .get('/api/v1/videos/ba708d62-e3d7-45d9-9d73-41b9097cc02d/comment-threads/' + commentId) - .set('Accept', 'application/json') - .expect(404) + await makeGetRequest({ + url: server.url, + path: '/api/v1/videos/ba708d62-e3d7-45d9-9d73-41b9097cc02d/comment-threads/' + commentId, + statusCodeExpected: 404 + }) }) it('Should fail with an incorrect thread id', async function () { - await request(server.url) - .get('/api/v1/videos/' + videoUUID + '/comment-threads/156') - .set('Accept', 'application/json') - .expect(404) + await makeGetRequest({ + url: server.url, + path: '/api/v1/videos/' + videoUUID + '/comment-threads/156', + statusCodeExpected: 404 + }) }) it('Should success with the correct params', async function () { - await request(server.url) - .get('/api/v1/videos/' + videoUUID + '/comment-threads/' + commentId) - .set('Accept', 'application/json') - .expect(200) + await makeGetRequest({ + url: server.url, + path: '/api/v1/videos/' + videoUUID + '/comment-threads/' + commentId, + statusCodeExpected: 200 + }) }) }) @@ -122,7 +126,7 @@ describe('Test video comments API validator', function () { it('Should fail with a short comment', async function () { const fields = { - text: 'h'.repeat(3001) + text: '' } await makePostBodyRequest({ url: server.url, path: pathThread, token: server.accessToken, fields }) }) @@ -165,7 +169,7 @@ describe('Test video comments API validator', function () { it('Should fail with a short comment', async function () { const fields = { - text: 'h'.repeat(3001) + text: '' } await makePostBodyRequest({ url: server.url, path: pathComment, token: server.accessToken, fields }) }) @@ -201,12 +205,60 @@ describe('Test video comments API validator', function () { }) }) - after(async function () { - killallServers([ server ]) + describe('When removing video comments', function () { + it('Should fail with a non authenticated user', async function () { + await makeDeleteRequest({ url: server.url, path: pathComment, token: 'none', statusCodeExpected: 401 }) + }) - // Keep the logs if the test failed - if (this['ok']) { - await flushTests() - } + it('Should fail with another user', async function () { + await makeDeleteRequest({ url: server.url, path: pathComment, token: userAccessToken, statusCodeExpected: 403 }) + }) + + it('Should fail with an incorrect video', async function () { + const path = '/api/v1/videos/ba708d62-e3d7-45d9-9d73-41b9097cc02d/comments/' + commentId + await makeDeleteRequest({ url: server.url, path, token: server.accessToken, statusCodeExpected: 404 }) + }) + + it('Should fail with an incorrect comment', async function () { + const path = '/api/v1/videos/' + videoUUID + '/comments/124' + await makeDeleteRequest({ url: server.url, path, token: server.accessToken, statusCodeExpected: 404 }) + }) + + it('Should succeed with the correct parameters', async function () { + await makeDeleteRequest({ url: server.url, path: pathComment, token: server.accessToken, statusCodeExpected: 204 }) + }) + }) + + describe('When a video has comments disabled', function () { + before(async function () { + const res = await uploadVideo(server.url, server.accessToken, { commentsEnabled: false }) + videoUUID = res.body.video.uuid + pathThread = '/api/v1/videos/' + videoUUID + '/comment-threads' + }) + + it('Should return an empty thread list', async function () { + const res = await makeGetRequest({ + url: server.url, + path: pathThread, + statusCodeExpected: 200 + }) + expect(res.body.total).to.equal(0) + expect(res.body.data).to.have.lengthOf(0) + }) + + it('Should return an thread comments list') + + it('Should return conflict on thread add', async function () { + const fields = { + text: 'super comment' + } + await makePostBodyRequest({ url: server.url, path: pathThread, token: server.accessToken, fields, statusCodeExpected: 409 }) + }) + + it('Should return conflict on comment thread add') + }) + + after(async function () { + await cleanupTests([ server ]) }) })