X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-channels.ts;h=de88298d164360531ada329dedb3895848114b4a;hb=d7a25329f9e607894d29ab342b9cb66638b56dc0;hp=acb6bdd57ead1bd48dfbeae9f0c3abb20ab2c7db;hpb=48dce1c90dff4e90a4bcffefaecf157336cf904b;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-channels.ts b/server/tests/api/check-params/video-channels.ts index acb6bdd57..de88298d1 100644 --- a/server/tests/api/check-params/video-channels.ts +++ b/server/tests/api/check-params/video-channels.ts @@ -4,29 +4,32 @@ import * as chai from 'chai' import { omit } from 'lodash' import 'mocha' import { + cleanupTests, createUser, deleteVideoChannel, - flushTests, + flushAndRunServer, getAccountVideoChannelsList, - getVideoChannelsList, immutableAssign, - killallServers, makeGetRequest, makePostBodyRequest, makePutBodyRequest, - runServer, + makeUploadRequest, ServerInfo, setAccessTokensToServers, userLogin -} from '../../utils' -import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination } from '../../utils/requests/check-api-params' -import { getAccountsList } from '../../utils/users/accounts' +} from '../../../../shared/extra-utils' +import { + checkBadCountPagination, + checkBadSortPagination, + checkBadStartPagination +} from '../../../../shared/extra-utils/requests/check-api-params' +import { join } from 'path' +import { VideoChannelUpdate } from '../../../../shared/models/videos' const expect = chai.expect -describe('Test videos API validator', function () { +describe('Test video channels API validator', function () { const videoChannelPath = '/api/v1/video-channels' - const accountPath = '/api/v1/accounts/' let server: ServerInfo let accessTokenUser: string @@ -35,9 +38,7 @@ describe('Test videos API validator', function () { before(async function () { this.timeout(30000) - await flushTests() - - server = await runServer(1) + server = await flushAndRunServer(1) await setAccessTokensToServers([ server ]) @@ -45,8 +46,11 @@ describe('Test videos API validator', function () { username: 'fake', password: 'fake_password' } - await createUser(server.url, server.accessToken, user.username, user.password) - accessTokenUser = await userLogin(server, user) + + { + await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password }) + accessTokenUser = await userLogin(server, user) + } }) describe('When listing a video channels', function () { @@ -64,86 +68,118 @@ describe('Test videos API validator', function () { }) describe('When listing account video channels', function () { - it('Should fail with bad account', async function () { - await getAccountVideoChannelsList(server.url, 'hello', 400) + const accountChannelPath = '/api/v1/accounts/fake/video-channels' + + it('Should fail with a bad start pagination', async function () { + await checkBadStartPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with a bad count pagination', async function () { + await checkBadCountPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with an incorrect sort', async function () { + await checkBadSortPagination(server.url, accountChannelPath, server.accessToken) }) it('Should fail with a unknown account', async function () { - await getAccountVideoChannelsList(server.url, 154, 404) + await getAccountVideoChannelsList({ url: server.url, accountName: 'unknown', specialStatus: 404 }) + }) + + it('Should succeed with the correct parameters', async function () { + await makeGetRequest({ + url: server.url, + path: accountChannelPath, + statusCodeExpected: 200 + }) }) }) describe('When adding a video channel', function () { - let path: string - const baseCorrectParams = { - name: 'hello', + name: 'super_channel', + displayName: 'hello', description: 'super description', support: 'super support text' } - before(async function () { - const res = await getAccountsList(server.url) - const accountId = res.body.data[0].id - path = accountPath + accountId + '/video-channels' - }) - it('Should fail with a non authenticated user', async function () { - await makePostBodyRequest({ url: server.url, path, token: 'none', fields: baseCorrectParams, statusCodeExpected: 401 }) + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: 'none', + fields: baseCorrectParams, + statusCodeExpected: 401 + }) }) it('Should fail with nothing', async function () { const fields = {} - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) - it('Should fail without name', async function () { + it('Should fail without a name', async function () { const fields = omit(baseCorrectParams, 'name') - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail with a bad name', async function () { + const fields = immutableAssign(baseCorrectParams, { name: 'super name' }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail without a name', async function () { + const fields = omit(baseCorrectParams, 'displayName') + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long name', async function () { - const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(25) }) - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + const fields = immutableAssign(baseCorrectParams, { displayName: 'super'.repeat(25) }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long description', async function () { - const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(60) }) - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(201) }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long support text', async function () { - const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(70) }) - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should succeed with the correct parameters', async function () { await makePostBodyRequest({ url: server.url, - path, + path: videoChannelPath, token: server.accessToken, fields: baseCorrectParams, statusCodeExpected: 200 }) }) + + it('Should fail when adding a channel with the same username', async function () { + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: server.accessToken, + fields: baseCorrectParams, + statusCodeExpected: 409 + }) + }) }) describe('When updating a video channel', function () { - let path: string - - const baseCorrectParams = { - name: 'hello', - description: 'super description' + const baseCorrectParams: VideoChannelUpdate = { + displayName: 'hello', + description: 'super description', + support: 'toto', + bulkVideosSupportUpdate: false } + let path: string before(async function () { - const res1 = await getVideoChannelsList(server.url, 0, 1) - const videoChannelId = res1.body.data[0].id - - const res2 = await getAccountsList(server.url) - const accountId = res2.body.data[0].id - - path = accountPath + accountId + '/video-channels/' + videoChannelId + path = videoChannelPath + '/super_channel' }) it('Should fail with a non authenticated user', async function () { @@ -167,17 +203,22 @@ describe('Test videos API validator', function () { }) it('Should fail with a long name', async function () { - const fields = immutableAssign(baseCorrectParams, { name: 'super'.repeat(25) }) + const fields = immutableAssign(baseCorrectParams, { displayName: 'super'.repeat(25) }) await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) it('Should fail with a long description', async function () { - const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(60) }) + const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(201) }) await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) it('Should fail with a long support text', async function () { - const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(70) }) + const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) }) + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should fail with a bad bulkVideosSupportUpdate field', async function () { + const fields = immutableAssign(baseCorrectParams, { bulkVideosSupportUpdate: 'super' }) await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) @@ -192,42 +233,74 @@ describe('Test videos API validator', function () { }) }) - describe('When getting a video channel', function () { - let basePath: string - let videoChannelId: number + describe('When updating video channel avatar', function () { + let path: string before(async function () { - const res1 = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res1.body.data[0].id + path = videoChannelPath + '/super_channel' + }) - const res2 = await getAccountsList(server.url) - const accountId = res2.body.data[0].id + it('Should fail with an incorrect input file', async function () { + const fields = {} + const attaches = { + 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'video_short.mp4') + } + await makeUploadRequest({ url: server.url, path: path + '/avatar/pick', token: server.accessToken, fields, attaches }) + }) - basePath = accountPath + accountId + '/video-channels' + it('Should fail with a big file', async function () { + const fields = {} + const attaches = { + 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar-big.png') + } + await makeUploadRequest({ url: server.url, path: path + '/avatar/pick', token: server.accessToken, fields, attaches }) }) - it('Should return the list of the video channels with nothing', async function () { - const res = await makeGetRequest({ + it('Should fail with an unauthenticated user', async function () { + const fields = {} + const attaches = { + 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar.png') + } + await makeUploadRequest({ url: server.url, - path: basePath, - statusCodeExpected: 200 + path: path + '/avatar/pick', + fields, + attaches, + statusCodeExpected: 401 }) + }) - expect(res.body.data).to.be.an('array') + it('Should succeed with the correct params', async function () { + const fields = {} + const attaches = { + 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar.png') + } + await makeUploadRequest({ + url: server.url, + path: path + '/avatar/pick', + token: server.accessToken, + fields, + attaches, + statusCodeExpected: 200 + }) }) + }) - it('Should fail without a correct uuid', async function () { - await makeGetRequest({ + describe('When getting a video channel', function () { + it('Should return the list of the video channels with nothing', async function () { + const res = await makeGetRequest({ url: server.url, - path: basePath + '/coucou', - statusCodeExpected: 400 + path: videoChannelPath, + statusCodeExpected: 200 }) + + expect(res.body.data).to.be.an('array') }) it('Should return 404 with an incorrect video channel', async function () { await makeGetRequest({ url: server.url, - path: basePath + '/4da6fde3-88f7-4d16-b119-108df5630b06', + path: videoChannelPath + '/super_channel2', statusCodeExpected: 404 }) }) @@ -235,58 +308,35 @@ describe('Test videos API validator', function () { it('Should succeed with the correct parameters', async function () { await makeGetRequest({ url: server.url, - path: basePath + '/' + videoChannelId, + path: videoChannelPath + '/super_channel', statusCodeExpected: 200 }) }) }) describe('When deleting a video channel', function () { - let videoChannelId: number - let accountId: number - - before(async function () { - const res1 = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res1.body.data[0].id - - const res2 = await getAccountsList(server.url) - accountId = res2.body.data[0].id - }) - it('Should fail with a non authenticated user', async function () { - await deleteVideoChannel(server.url, 'coucou', accountId, videoChannelId, 401) + await deleteVideoChannel(server.url, 'coucou', 'super_channel', 401) }) it('Should fail with another authenticated user', async function () { - await deleteVideoChannel(server.url, accessTokenUser, accountId, videoChannelId, 403) - }) - - it('Should fail with an unknown account id', async function () { - await deleteVideoChannel(server.url, server.accessToken, 454554,videoChannelId, 404) + await deleteVideoChannel(server.url, accessTokenUser, 'super_channel', 403) }) it('Should fail with an unknown video channel id', async function () { - await deleteVideoChannel(server.url, server.accessToken, accountId,454554, 404) + await deleteVideoChannel(server.url, server.accessToken,'super_channel2', 404) }) it('Should succeed with the correct parameters', async function () { - await deleteVideoChannel(server.url, server.accessToken, accountId, videoChannelId) + await deleteVideoChannel(server.url, server.accessToken, 'super_channel') }) it('Should fail to delete the last user video channel', async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - videoChannelId = res.body.data[0].id - - await deleteVideoChannel(server.url, server.accessToken, accountId, videoChannelId, 409) + await deleteVideoChannel(server.url, server.accessToken, 'root_channel', 409) }) }) after(async function () { - killallServers([ server ]) - - // Keep the logs if the test failed - if (this['ok']) { - await flushTests() - } + await cleanupTests([ server ]) }) })