X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-channels.ts;h=2795ad7d5111b837d6c12fcd46f2758feb9726dc;hb=3b0bd70aa05ab82fa30fe67ed4899d44652c703a;hp=0980de73b8d972f5b3b67c7294fc95999504ea90;hpb=52d9f792b3fee5acce80f948295b59e3ad2073eb;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-channels.ts b/server/tests/api/check-params/video-channels.ts index 0980de73b..2795ad7d5 100644 --- a/server/tests/api/check-params/video-channels.ts +++ b/server/tests/api/check-params/video-channels.ts @@ -1,29 +1,30 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ import * as chai from 'chai' import { omit } from 'lodash' import 'mocha' import { + cleanupTests, createUser, deleteVideoChannel, - flushTests, + flushAndRunServer, getAccountVideoChannelsList, - getMyUserInformation, - getVideoChannelsList, immutableAssign, - killallServers, makeGetRequest, makePostBodyRequest, makePutBodyRequest, makeUploadRequest, - runServer, ServerInfo, setAccessTokensToServers, userLogin -} from '../../utils' -import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination } from '../../utils/requests/check-api-params' -import { User } from '../../../../shared/models/users' +} from '../../../../shared/extra-utils' +import { + checkBadCountPagination, + checkBadSortPagination, + checkBadStartPagination +} from '../../../../shared/extra-utils/requests/check-api-params' import { join } from 'path' +import { VideoChannelUpdate } from '../../../../shared/models/videos' const expect = chai.expect @@ -31,16 +32,13 @@ describe('Test video channels API validator', function () { const videoChannelPath = '/api/v1/video-channels' let server: ServerInfo let accessTokenUser: string - let videoChannelUUID: string // --------------------------------------------------------------- before(async function () { this.timeout(30000) - await flushTests() - - server = await runServer(1) + server = await flushAndRunServer(1) await setAccessTokensToServers([ server ]) @@ -50,15 +48,9 @@ describe('Test video channels API validator', function () { } { - await createUser(server.url, server.accessToken, user.username, user.password) + await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password }) accessTokenUser = await userLogin(server, user) } - - { - const res = await getMyUserInformation(server.url, server.accessToken) - const user: User = res.body - videoChannelUUID = user.videoChannels[0].uuid - } }) describe('When listing a video channels', function () { @@ -76,13 +68,36 @@ describe('Test video channels API validator', function () { }) describe('When listing account video channels', function () { + const accountChannelPath = '/api/v1/accounts/fake/video-channels' + + it('Should fail with a bad start pagination', async function () { + await checkBadStartPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with a bad count pagination', async function () { + await checkBadCountPagination(server.url, accountChannelPath, server.accessToken) + }) + + it('Should fail with an incorrect sort', async function () { + await checkBadSortPagination(server.url, accountChannelPath, server.accessToken) + }) + it('Should fail with a unknown account', async function () { - await getAccountVideoChannelsList(server.url, 'unknown', 404) + await getAccountVideoChannelsList({ url: server.url, accountName: 'unknown', specialStatus: 404 }) + }) + + it('Should succeed with the correct parameters', async function () { + await makeGetRequest({ + url: server.url, + path: accountChannelPath, + statusCodeExpected: 200 + }) }) }) describe('When adding a video channel', function () { const baseCorrectParams = { + name: 'super_channel', displayName: 'hello', description: 'super description', support: 'super support text' @@ -103,6 +118,16 @@ describe('Test video channels API validator', function () { await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) + it('Should fail without a name', async function () { + const fields = omit(baseCorrectParams, 'name') + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + + it('Should fail with a bad name', async function () { + const fields = immutableAssign(baseCorrectParams, { name: 'super name' }) + await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) + }) + it('Should fail without a name', async function () { const fields = omit(baseCorrectParams, 'displayName') await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) @@ -114,12 +139,12 @@ describe('Test video channels API validator', function () { }) it('Should fail with a long description', async function () { - const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(150) }) + const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(201) }) await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) it('Should fail with a long support text', async function () { - const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(150) }) + const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) }) await makePostBodyRequest({ url: server.url, path: videoChannelPath, token: server.accessToken, fields }) }) @@ -132,17 +157,29 @@ describe('Test video channels API validator', function () { statusCodeExpected: 200 }) }) + + it('Should fail when adding a channel with the same username', async function () { + await makePostBodyRequest({ + url: server.url, + path: videoChannelPath, + token: server.accessToken, + fields: baseCorrectParams, + statusCodeExpected: 409 + }) + }) }) describe('When updating a video channel', function () { - const baseCorrectParams = { + const baseCorrectParams: VideoChannelUpdate = { displayName: 'hello', - description: 'super description' + description: 'super description', + support: 'toto', + bulkVideosSupportUpdate: false } let path: string before(async function () { - path = videoChannelPath + '/' + videoChannelUUID + path = videoChannelPath + '/super_channel' }) it('Should fail with a non authenticated user', async function () { @@ -171,12 +208,17 @@ describe('Test video channels API validator', function () { }) it('Should fail with a long description', async function () { - const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(150) }) + const fields = immutableAssign(baseCorrectParams, { description: 'super'.repeat(201) }) await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) it('Should fail with a long support text', async function () { - const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(150) }) + const fields = immutableAssign(baseCorrectParams, { support: 'super'.repeat(201) }) + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should fail with a bad bulkVideosSupportUpdate field', async function () { + const fields = immutableAssign(baseCorrectParams, { bulkVideosSupportUpdate: 'super' }) await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) }) @@ -195,13 +237,13 @@ describe('Test video channels API validator', function () { let path: string before(async function () { - path = videoChannelPath + '/' + videoChannelUUID + path = videoChannelPath + '/super_channel' }) it('Should fail with an incorrect input file', async function () { const fields = {} const attaches = { - 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'video_short.mp4') + avatarfile: join(__dirname, '..', '..', 'fixtures', 'video_short.mp4') } await makeUploadRequest({ url: server.url, path: path + '/avatar/pick', token: server.accessToken, fields, attaches }) }) @@ -209,7 +251,7 @@ describe('Test video channels API validator', function () { it('Should fail with a big file', async function () { const fields = {} const attaches = { - 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar-big.png') + avatarfile: join(__dirname, '..', '..', 'fixtures', 'avatar-big.png') } await makeUploadRequest({ url: server.url, path: path + '/avatar/pick', token: server.accessToken, fields, attaches }) }) @@ -217,7 +259,7 @@ describe('Test video channels API validator', function () { it('Should fail with an unauthenticated user', async function () { const fields = {} const attaches = { - 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar.png') + avatarfile: join(__dirname, '..', '..', 'fixtures', 'avatar.png') } await makeUploadRequest({ url: server.url, @@ -231,7 +273,7 @@ describe('Test video channels API validator', function () { it('Should succeed with the correct params', async function () { const fields = {} const attaches = { - 'avatarfile': join(__dirname, '..', '..', 'fixtures', 'avatar.png') + avatarfile: join(__dirname, '..', '..', 'fixtures', 'avatar.png') } await makeUploadRequest({ url: server.url, @@ -255,18 +297,10 @@ describe('Test video channels API validator', function () { expect(res.body.data).to.be.an('array') }) - it('Should fail without a correct uuid', async function () { - await makeGetRequest({ - url: server.url, - path: videoChannelPath + '/coucou', - statusCodeExpected: 400 - }) - }) - it('Should return 404 with an incorrect video channel', async function () { await makeGetRequest({ url: server.url, - path: videoChannelPath + '/4da6fde3-88f7-4d16-b119-108df5630b06', + path: videoChannelPath + '/super_channel2', statusCodeExpected: 404 }) }) @@ -274,7 +308,7 @@ describe('Test video channels API validator', function () { it('Should succeed with the correct parameters', async function () { await makeGetRequest({ url: server.url, - path: videoChannelPath + '/' + videoChannelUUID, + path: videoChannelPath + '/super_channel', statusCodeExpected: 200 }) }) @@ -282,35 +316,27 @@ describe('Test video channels API validator', function () { describe('When deleting a video channel', function () { it('Should fail with a non authenticated user', async function () { - await deleteVideoChannel(server.url, 'coucou', videoChannelUUID, 401) + await deleteVideoChannel(server.url, 'coucou', 'super_channel', 401) }) it('Should fail with another authenticated user', async function () { - await deleteVideoChannel(server.url, accessTokenUser, videoChannelUUID, 403) + await deleteVideoChannel(server.url, accessTokenUser, 'super_channel', 403) }) it('Should fail with an unknown video channel id', async function () { - await deleteVideoChannel(server.url, server.accessToken,454554, 404) + await deleteVideoChannel(server.url, server.accessToken, 'super_channel2', 404) }) it('Should succeed with the correct parameters', async function () { - await deleteVideoChannel(server.url, server.accessToken, videoChannelUUID) + await deleteVideoChannel(server.url, server.accessToken, 'super_channel') }) it('Should fail to delete the last user video channel', async function () { - const res = await getVideoChannelsList(server.url, 0, 1) - const lastVideoChannelUUID = res.body.data[0].uuid - - await deleteVideoChannel(server.url, server.accessToken, lastVideoChannelUUID, 409) + await deleteVideoChannel(server.url, server.accessToken, 'root_channel', 409) }) }) after(async function () { - killallServers([ server ]) - - // Keep the logs if the test failed - if (this['ok']) { - await flushTests() - } + await cleanupTests([ server ]) }) })