X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-captions.ts;h=bfce5ca4767524c46fe891a8bc88a28a886768d2;hb=63fa260a81a8930c157b73c897fe8696a8cc90d4;hp=1ce2202d2a63c2c1d381a24af6cc9c48ab8d4de3;hpb=3d470a530c4a48b2e4f4a9e7d4f223e14f32cea4;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-captions.ts b/server/tests/api/check-params/video-captions.ts index 1ce2202d2..bfce5ca47 100644 --- a/server/tests/api/check-params/video-captions.ts +++ b/server/tests/api/check-params/video-captions.ts @@ -1,51 +1,44 @@ /* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import 'mocha' - -import { HttpStatusCode } from '../../../../shared/core-utils/miscs/http-error-codes' +import { buildAbsoluteFixturePath } from '@shared/core-utils' +import { HttpStatusCode, VideoCreateResult, VideoPrivacy } from '@shared/models' import { - buildAbsoluteFixturePath, cleanupTests, - createUser, - flushAndRunServer, + createSingleServer, makeDeleteRequest, makeGetRequest, makeUploadRequest, - ServerInfo, - setAccessTokensToServers, - uploadVideo, - userLogin -} from '../../../../shared/extra-utils' -import { createVideoCaption } from '../../../../shared/extra-utils/videos/video-captions' + PeerTubeServer, + setAccessTokensToServers +} from '@shared/server-commands' describe('Test video captions API validator', function () { const path = '/api/v1/videos/' - let server: ServerInfo + let server: PeerTubeServer let userAccessToken: string - let videoUUID: string + let video: VideoCreateResult + let privateVideo: VideoCreateResult // --------------------------------------------------------------- before(async function () { this.timeout(30000) - server = await flushAndRunServer(1) + server = await createSingleServer(1) await setAccessTokensToServers([ server ]) - { - const res = await uploadVideo(server.url, server.accessToken, {}) - videoUUID = res.body.video.uuid - } + video = await server.videos.upload() + privateVideo = await server.videos.upload({ attributes: { privacy: VideoPrivacy.PRIVATE } }) { const user = { username: 'user1', password: 'my super password' } - await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password }) - userAccessToken = await userLogin(server, user) + await server.users.create({ username: user.username, password: user.password }) + userAccessToken = await server.login.getAccessToken(user) } }) @@ -74,12 +67,12 @@ describe('Test video captions API validator', function () { token: server.accessToken, fields, attaches, - statusCodeExpected: 404 + expectedStatus: 404 }) }) it('Should fail with a missing language in path', async function () { - const captionPath = path + videoUUID + '/captions' + const captionPath = path + video.uuid + '/captions' await makeUploadRequest({ method: 'PUT', url: server.url, @@ -91,7 +84,7 @@ describe('Test video captions API validator', function () { }) it('Should fail with an unknown language', async function () { - const captionPath = path + videoUUID + '/captions/15' + const captionPath = path + video.uuid + '/captions/15' await makeUploadRequest({ method: 'PUT', url: server.url, @@ -103,19 +96,19 @@ describe('Test video captions API validator', function () { }) it('Should fail without access token', async function () { - const captionPath = path + videoUUID + '/captions/fr' + const captionPath = path + video.uuid + '/captions/fr' await makeUploadRequest({ method: 'PUT', url: server.url, path: captionPath, fields, attaches, - statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail with a bad access token', async function () { - const captionPath = path + videoUUID + '/captions/fr' + const captionPath = path + video.uuid + '/captions/fr' await makeUploadRequest({ method: 'PUT', url: server.url, @@ -123,7 +116,7 @@ describe('Test video captions API validator', function () { token: 'blabla', fields, attaches, - statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) @@ -133,7 +126,7 @@ describe('Test video captions API validator', function () { // 'captionfile': buildAbsoluteFixturePath('subtitle-bad.txt') // } // - // const captionPath = path + videoUUID + '/captions/fr' + // const captionPath = path + video.uuid + '/captions/fr' // await makeUploadRequest({ // method: 'PUT', // url: server.url, @@ -141,7 +134,7 @@ describe('Test video captions API validator', function () { // token: server.accessToken, // fields, // attaches, - // statusCodeExpected: HttpStatusCode.BAD_REQUEST_400 + // expectedStatus: HttpStatusCode.BAD_REQUEST_400 // }) // }) @@ -151,19 +144,17 @@ describe('Test video captions API validator', function () { // url: server.url, // accessToken: server.accessToken, // language: 'zh', - // videoId: videoUUID, + // videoId: video.uuid, // fixture: 'subtitle-bad.txt', // mimeType: 'application/octet-stream', - // statusCodeExpected: HttpStatusCode.BAD_REQUEST_400 + // expectedStatus: HttpStatusCode.BAD_REQUEST_400 // }) // }) it('Should succeed with a valid captionfile extension and octet-stream mime type', async function () { - await createVideoCaption({ - url: server.url, - accessToken: server.accessToken, + await server.captions.add({ language: 'zh', - videoId: videoUUID, + videoId: video.uuid, fixture: 'subtitle-good.srt', mimeType: 'application/octet-stream' }) @@ -175,7 +166,7 @@ describe('Test video captions API validator', function () { // 'captionfile': buildAbsoluteFixturePath('subtitle-bad.srt') // } // - // const captionPath = path + videoUUID + '/captions/fr' + // const captionPath = path + video.uuid + '/captions/fr' // await makeUploadRequest({ // method: 'PUT', // url: server.url, @@ -183,12 +174,12 @@ describe('Test video captions API validator', function () { // token: server.accessToken, // fields, // attaches, - // statusCodeExpected: HttpStatusCode.INTERNAL_SERVER_ERROR_500 + // expectedStatus: HttpStatusCode.INTERNAL_SERVER_ERROR_500 // }) // }) it('Should success with the correct parameters', async function () { - const captionPath = path + videoUUID + '/captions/fr' + const captionPath = path + video.uuid + '/captions/fr' await makeUploadRequest({ method: 'PUT', url: server.url, @@ -196,7 +187,7 @@ describe('Test video captions API validator', function () { token: server.accessToken, fields, attaches, - statusCodeExpected: HttpStatusCode.NO_CONTENT_204 + expectedStatus: HttpStatusCode.NO_CONTENT_204 }) }) }) @@ -210,12 +201,36 @@ describe('Test video captions API validator', function () { await makeGetRequest({ url: server.url, path: path + '4da6fde3-88f7-4d16-b119-108df5630b06/captions', - statusCodeExpected: HttpStatusCode.NOT_FOUND_404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 + }) + }) + + it('Should fail with a private video without token', async function () { + await makeGetRequest({ + url: server.url, + path: path + privateVideo.shortUUID + '/captions', + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 + }) + }) + + it('Should fail with another user token', async function () { + await makeGetRequest({ + url: server.url, + token: userAccessToken, + path: path + privateVideo.shortUUID + '/captions', + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) it('Should success with the correct parameters', async function () { - await makeGetRequest({ url: server.url, path: path + videoUUID + '/captions', statusCodeExpected: HttpStatusCode.OK_200 }) + await makeGetRequest({ url: server.url, path: path + video.shortUUID + '/captions', expectedStatus: HttpStatusCode.OK_200 }) + + await makeGetRequest({ + url: server.url, + path: path + privateVideo.shortUUID + '/captions', + token: server.accessToken, + expectedStatus: HttpStatusCode.OK_200 + }) }) }) @@ -233,7 +248,7 @@ describe('Test video captions API validator', function () { url: server.url, path: path + '4da6fde3-88f7-4d16-b119-108df5630b06/captions/fr', token: server.accessToken, - statusCodeExpected: HttpStatusCode.NOT_FOUND_404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) @@ -246,42 +261,42 @@ describe('Test video captions API validator', function () { }) it('Should fail with a missing language', async function () { - const captionPath = path + videoUUID + '/captions' + const captionPath = path + video.shortUUID + '/captions' await makeDeleteRequest({ url: server.url, path: captionPath, token: server.accessToken }) }) it('Should fail with an unknown language', async function () { - const captionPath = path + videoUUID + '/captions/15' + const captionPath = path + video.shortUUID + '/captions/15' await makeDeleteRequest({ url: server.url, path: captionPath, token: server.accessToken }) }) it('Should fail without access token', async function () { - const captionPath = path + videoUUID + '/captions/fr' - await makeDeleteRequest({ url: server.url, path: captionPath, statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401 }) + const captionPath = path + video.shortUUID + '/captions/fr' + await makeDeleteRequest({ url: server.url, path: captionPath, expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail with a bad access token', async function () { - const captionPath = path + videoUUID + '/captions/fr' - await makeDeleteRequest({ url: server.url, path: captionPath, token: 'coucou', statusCodeExpected: HttpStatusCode.UNAUTHORIZED_401 }) + const captionPath = path + video.shortUUID + '/captions/fr' + await makeDeleteRequest({ url: server.url, path: captionPath, token: 'coucou', expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail with another user', async function () { - const captionPath = path + videoUUID + '/captions/fr' + const captionPath = path + video.shortUUID + '/captions/fr' await makeDeleteRequest({ url: server.url, path: captionPath, token: userAccessToken, - statusCodeExpected: HttpStatusCode.FORBIDDEN_403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) it('Should success with the correct parameters', async function () { - const captionPath = path + videoUUID + '/captions/fr' + const captionPath = path + video.shortUUID + '/captions/fr' await makeDeleteRequest({ url: server.url, path: captionPath, token: server.accessToken, - statusCodeExpected: HttpStatusCode.NO_CONTENT_204 + expectedStatus: HttpStatusCode.NO_CONTENT_204 }) }) })