X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-blacklist.ts;h=b96c269892900a399aed52e06b4035a9208b3882;hb=5baee5fca418487e72ddcd6419d31bca8659b668;hp=eb16b3af08fb90e2e640200cbac60b637a5675f9;hpb=35bf0c83c80f59ca79f4b84fac8700f17adeb22d;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-blacklist.ts b/server/tests/api/check-params/video-blacklist.ts index eb16b3af0..b96c26989 100644 --- a/server/tests/api/check-params/video-blacklist.ts +++ b/server/tests/api/check-params/video-blacklist.ts @@ -1,127 +1,217 @@ -/* tslint:disable:no-unused-expression */ +/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ import 'mocha' -import * as request from 'supertest' import { - ServerInfo, - flushTests, - runServer, - uploadVideo, - getVideosList, + cleanupTests, createUser, - setAccessTokensToServers, - killallServers, + doubleFollow, + flushAndRunMultipleServers, + getBlacklistedVideosList, + getVideo, + getVideoWithToken, makePostBodyRequest, - getUserAccessToken -} from '../../utils' + makePutBodyRequest, + removeVideoFromBlacklist, + ServerInfo, + setAccessTokensToServers, + uploadVideo, + userLogin, + waitJobs +} from '../../../../shared/extra-utils' +import { + checkBadCountPagination, + checkBadSortPagination, + checkBadStartPagination +} from '../../../../shared/extra-utils/requests/check-api-params' +import { VideoBlockType, VideoDetails } from '../../../../shared/models/videos' +import { expect } from 'chai' describe('Test video blacklist API validators', function () { - let server: ServerInfo - let userAccessToken = '' + let servers: ServerInfo[] + let notBlacklistedVideoId: number + let remoteVideoUUID: string + let userAccessToken1 = '' + let userAccessToken2 = '' // --------------------------------------------------------------- before(async function () { this.timeout(120000) - await flushTests() + servers = await flushAndRunMultipleServers(2) - server = await runServer(1) + await setAccessTokensToServers(servers) + await doubleFollow(servers[0], servers[1]) + + { + const username = 'user1' + const password = 'my super password' + await createUser({ url: servers[0].url, accessToken: servers[0].accessToken, username: username, password: password }) + userAccessToken1 = await userLogin(servers[0], { username, password }) + } - await setAccessTokensToServers([ server ]) + { + const username = 'user2' + const password = 'my super password' + await createUser({ url: servers[0].url, accessToken: servers[0].accessToken, username: username, password: password }) + userAccessToken2 = await userLogin(servers[0], { username, password }) + } - const username = 'user1' - const password = 'my super password' - await createUser(server.url, server.accessToken, username, password) - userAccessToken = await getUserAccessToken(server, { username, password }) + { + const res = await uploadVideo(servers[0].url, userAccessToken1, {}) + servers[0].video = res.body.video + } - // Upload a video - const videoAttributes = {} - await uploadVideo(server.url, server.accessToken, videoAttributes) + { + const res = await uploadVideo(servers[0].url, servers[0].accessToken, {}) + notBlacklistedVideoId = res.body.video.uuid + } - const res = await getVideosList(server.url) + { + const res = await uploadVideo(servers[1].url, servers[1].accessToken, {}) + remoteVideoUUID = res.body.video.uuid + } - const videos = res.body.data - server.video = videos[0] + await waitJobs(servers) }) describe('When adding a video in blacklist', function () { const basePath = '/api/v1/videos/' it('Should fail with nothing', async function () { - const path = basePath + server.video + '/blacklist' + const path = basePath + servers[0].video + '/blacklist' const fields = {} - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + await makePostBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields }) }) it('Should fail with a wrong video', async function () { const wrongPath = '/api/v1/videos/blabla/blacklist' const fields = {} - await makePostBodyRequest({ url: server.url, path: wrongPath, token: server.accessToken, fields }) + await makePostBodyRequest({ url: servers[0].url, path: wrongPath, token: servers[0].accessToken, fields }) }) it('Should fail with a non authenticated user', async function () { + const path = basePath + servers[0].video + '/blacklist' const fields = {} - const path = basePath + server.video + '/blacklist' - await makePostBodyRequest({ url: server.url, path, token: 'hello', fields, statusCodeExpected: 401 }) + await makePostBodyRequest({ url: servers[0].url, path, token: 'hello', fields, statusCodeExpected: 401 }) }) it('Should fail with a non admin user', async function () { + const path = basePath + servers[0].video + '/blacklist' const fields = {} - const path = basePath + server.video + '/blacklist' - await makePostBodyRequest({ url: server.url, path, token: userAccessToken, fields, statusCodeExpected: 403 }) + await makePostBodyRequest({ url: servers[0].url, path, token: userAccessToken2, fields, statusCodeExpected: 403 }) }) - it('Should fail with a local video', async function () { + it('Should fail with an invalid reason', async function () { + const path = basePath + servers[0].video.uuid + '/blacklist' + const fields = { reason: 'a'.repeat(305) } + + await makePostBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields }) + }) + + it('Should fail to unfederate a remote video', async function () { + const path = basePath + remoteVideoUUID + '/blacklist' + const fields = { unfederate: true } + + await makePostBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields, statusCodeExpected: 409 }) + }) + + it('Should succeed with the correct params', async function () { + const path = basePath + servers[0].video.uuid + '/blacklist' const fields = {} - const path = basePath + server.video.id + '/blacklist' - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 403 }) + + await makePostBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields, statusCodeExpected: 204 }) }) }) - describe('When removing a video in blacklist', function () { + describe('When updating a video in blacklist', function () { const basePath = '/api/v1/videos/' - it('Should fail with a non authenticated user', async function () { - const path = basePath + server.video.id + '/blacklist' + it('Should fail with a wrong video', async function () { + const wrongPath = '/api/v1/videos/blabla/blacklist' + const fields = {} + await makePutBodyRequest({ url: servers[0].url, path: wrongPath, token: servers[0].accessToken, fields }) + }) - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + 'fake token') - .set('Accept', 'application/json') - .expect(401) + it('Should fail with a video not blacklisted', async function () { + const path = '/api/v1/videos/' + notBlacklistedVideoId + '/blacklist' + const fields = {} + await makePutBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields, statusCodeExpected: 404 }) + }) + + it('Should fail with a non authenticated user', async function () { + const path = basePath + servers[0].video + '/blacklist' + const fields = {} + await makePutBodyRequest({ url: servers[0].url, path, token: 'hello', fields, statusCodeExpected: 401 }) }) it('Should fail with a non admin user', async function () { - const path = basePath + server.video.id + '/blacklist' + const path = basePath + servers[0].video + '/blacklist' + const fields = {} + await makePutBodyRequest({ url: servers[0].url, path, token: userAccessToken2, fields, statusCodeExpected: 403 }) + }) - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + userAccessToken) - .set('Accept', 'application/json') - .expect(403) + it('Should fail with an invalid reason', async function () { + const path = basePath + servers[0].video.uuid + '/blacklist' + const fields = { reason: 'a'.repeat(305) } + + await makePutBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields }) }) - it('Should fail with an incorrect id', async function () { - const path = basePath + 'foobar/blacklist' + it('Should succeed with the correct params', async function () { + const path = basePath + servers[0].video.uuid + '/blacklist' + const fields = { reason: 'hello' } - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + server.accessToken) - .set('Accept', 'application/json') - .expect(400) + await makePutBodyRequest({ url: servers[0].url, path, token: servers[0].accessToken, fields, statusCodeExpected: 204 }) + }) + }) + + describe('When getting blacklisted video', function () { + + it('Should fail with a non authenticated user', async function () { + await getVideo(servers[0].url, servers[0].video.uuid, 401) + }) + + it('Should fail with another user', async function () { + await getVideoWithToken(servers[0].url, userAccessToken2, servers[0].video.uuid, 403) + }) + + it('Should succeed with the owner authenticated user', async function () { + const res = await getVideoWithToken(servers[0].url, userAccessToken1, servers[0].video.uuid, 200) + const video: VideoDetails = res.body + + expect(video.blacklisted).to.be.true + }) + + it('Should succeed with an admin', async function () { + const res = await getVideoWithToken(servers[0].url, servers[0].accessToken, servers[0].video.uuid, 200) + const video: VideoDetails = res.body + + expect(video.blacklisted).to.be.true + }) + }) + + describe('When removing a video in blacklist', function () { + it('Should fail with a non authenticated user', async function () { + await removeVideoFromBlacklist(servers[0].url, 'fake token', servers[0].video.uuid, 401) + }) + + it('Should fail with a non admin user', async function () { + await removeVideoFromBlacklist(servers[0].url, userAccessToken2, servers[0].video.uuid, 403) + }) + + it('Should fail with an incorrect id', async function () { + await removeVideoFromBlacklist(servers[0].url, servers[0].accessToken, 'hello', 400) }) it('Should fail with a not blacklisted video', async function () { // The video was not added to the blacklist so it should fail - const path = basePath + server.video.id + '/blacklist' + await removeVideoFromBlacklist(servers[0].url, servers[0].accessToken, notBlacklistedVideoId, 404) + }) - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + server.accessToken) - .set('Accept', 'application/json') - .expect(404) + it('Should succeed with the correct params', async function () { + await removeVideoFromBlacklist(servers[0].url, servers[0].accessToken, servers[0].video.uuid, 204) }) }) @@ -129,67 +219,35 @@ describe('Test video blacklist API validators', function () { const basePath = '/api/v1/videos/blacklist/' it('Should fail with a non authenticated user', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ sort: 'createdAt' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + 'fake token') - .expect(401) + await getBlacklistedVideosList({ url: servers[0].url, token: 'fake token', specialStatus: 401 }) }) it('Should fail with a non admin user', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ sort: 'createdAt' }) - .set('Authorization', 'Bearer ' + userAccessToken) - .set('Accept', 'application/json') - .expect(403) + await getBlacklistedVideosList({ url: servers[0].url, token: userAccessToken2, specialStatus: 403 }) }) it('Should fail with a bad start pagination', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ start: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + await checkBadStartPagination(servers[0].url, basePath, servers[0].accessToken) }) it('Should fail with a bad count pagination', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ count: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + await checkBadCountPagination(servers[0].url, basePath, servers[0].accessToken) }) it('Should fail with an incorrect sort', async function () { - const path = basePath + await checkBadSortPagination(servers[0].url, basePath, servers[0].accessToken) + }) - await request(server.url) - .get(path) - .query({ sort: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + it('Should fail with an invalid type', async function () { + await getBlacklistedVideosList({ url: servers[0].url, token: servers[0].accessToken, type: 0, specialStatus: 400 }) + }) + + it('Should succeed with the correct parameters', async function () { + await getBlacklistedVideosList({ url: servers[0].url, token: servers[0].accessToken, type: VideoBlockType.MANUAL }) }) }) after(async function () { - killallServers([ server ]) - - // Keep the logs if the test failed - if (this['ok']) { - await flushTests() - } + await cleanupTests(servers) }) })