X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Fvideo-blacklist.ts;h=8e1206db3e26e610d8703a13d07247baee2db739;hb=6e7e63b83f08ba68edc2bb9f72ff03d1802e45df;hp=eb16b3af08fb90e2e640200cbac60b637a5675f9;hpb=35bf0c83c80f59ca79f4b84fac8700f17adeb22d;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/video-blacklist.ts b/server/tests/api/check-params/video-blacklist.ts index eb16b3af0..8e1206db3 100644 --- a/server/tests/api/check-params/video-blacklist.ts +++ b/server/tests/api/check-params/video-blacklist.ts @@ -1,24 +1,34 @@ /* tslint:disable:no-unused-expression */ import 'mocha' -import * as request from 'supertest' import { - ServerInfo, - flushTests, - runServer, - uploadVideo, - getVideosList, createUser, - setAccessTokensToServers, + flushTests, + getBlacklistedVideosList, getVideo, getVideoWithToken, killallServers, makePostBodyRequest, - getUserAccessToken -} from '../../utils' + makePutBodyRequest, + removeVideoFromBlacklist, + runServer, + ServerInfo, + setAccessTokensToServers, + uploadVideo, + userLogin +} from '../../../../shared/utils' +import { + checkBadCountPagination, + checkBadSortPagination, + checkBadStartPagination +} from '../../../../shared/utils/requests/check-api-params' +import { VideoDetails } from '../../../../shared/models/videos' +import { expect } from 'chai' describe('Test video blacklist API validators', function () { let server: ServerInfo - let userAccessToken = '' + let notBlacklistedVideoId: number + let userAccessToken1 = '' + let userAccessToken2 = '' // --------------------------------------------------------------- @@ -31,19 +41,29 @@ describe('Test video blacklist API validators', function () { await setAccessTokensToServers([ server ]) - const username = 'user1' - const password = 'my super password' - await createUser(server.url, server.accessToken, username, password) - userAccessToken = await getUserAccessToken(server, { username, password }) + { + const username = 'user1' + const password = 'my super password' + await createUser(server.url, server.accessToken, username, password) + userAccessToken1 = await userLogin(server, { username, password }) + } - // Upload a video - const videoAttributes = {} - await uploadVideo(server.url, server.accessToken, videoAttributes) + { + const username = 'user2' + const password = 'my super password' + await createUser(server.url, server.accessToken, username, password) + userAccessToken2 = await userLogin(server, { username, password }) + } - const res = await getVideosList(server.url) + { + const res = await uploadVideo(server.url, userAccessToken1, {}) + server.video = res.body.video + } - const videos = res.body.data - server.video = videos[0] + { + const res = await uploadVideo(server.url, server.accessToken, {}) + notBlacklistedVideoId = res.body.video.uuid + } }) describe('When adding a video in blacklist', function () { @@ -62,66 +82,119 @@ describe('Test video blacklist API validators', function () { }) it('Should fail with a non authenticated user', async function () { - const fields = {} const path = basePath + server.video + '/blacklist' + const fields = {} await makePostBodyRequest({ url: server.url, path, token: 'hello', fields, statusCodeExpected: 401 }) }) it('Should fail with a non admin user', async function () { + const path = basePath + server.video + '/blacklist' const fields = {} + await makePostBodyRequest({ url: server.url, path, token: userAccessToken2, fields, statusCodeExpected: 403 }) + }) + + it('Should fail with an invalid reason', async function () { + const path = basePath + server.video.uuid + '/blacklist' + const fields = { reason: 'a'.repeat(305) } + + await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should succeed with the correct params', async function () { + const path = basePath + server.video.uuid + '/blacklist' + const fields = { } + + await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 204 }) + }) + }) + + describe('When updating a video in blacklist', function () { + const basePath = '/api/v1/videos/' + + it('Should fail with a wrong video', async function () { + const wrongPath = '/api/v1/videos/blabla/blacklist' + const fields = {} + await makePutBodyRequest({ url: server.url, path: wrongPath, token: server.accessToken, fields }) + }) + + it('Should fail with a video not blacklisted', async function () { + const path = '/api/v1/videos/' + notBlacklistedVideoId + '/blacklist' + const fields = {} + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 404 }) + }) + + it('Should fail with a non authenticated user', async function () { const path = basePath + server.video + '/blacklist' - await makePostBodyRequest({ url: server.url, path, token: userAccessToken, fields, statusCodeExpected: 403 }) + const fields = {} + await makePutBodyRequest({ url: server.url, path, token: 'hello', fields, statusCodeExpected: 401 }) }) - it('Should fail with a local video', async function () { + it('Should fail with a non admin user', async function () { + const path = basePath + server.video + '/blacklist' const fields = {} - const path = basePath + server.video.id + '/blacklist' - await makePostBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 403 }) + await makePutBodyRequest({ url: server.url, path, token: userAccessToken2, fields, statusCodeExpected: 403 }) + }) + + it('Should fail with an invalid reason', async function () { + const path = basePath + server.video.uuid + '/blacklist' + const fields = { reason: 'a'.repeat(305) } + + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields }) + }) + + it('Should succeed with the correct params', async function () { + const path = basePath + server.video.uuid + '/blacklist' + const fields = { reason: 'hello' } + + await makePutBodyRequest({ url: server.url, path, token: server.accessToken, fields, statusCodeExpected: 204 }) }) }) - describe('When removing a video in blacklist', function () { - const basePath = '/api/v1/videos/' + describe('When getting blacklisted video', function () { it('Should fail with a non authenticated user', async function () { - const path = basePath + server.video.id + '/blacklist' + await getVideo(server.url, server.video.uuid, 401) + }) - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + 'fake token') - .set('Accept', 'application/json') - .expect(401) + it('Should fail with another user', async function () { + await getVideoWithToken(server.url, userAccessToken2, server.video.uuid, 403) }) - it('Should fail with a non admin user', async function () { - const path = basePath + server.video.id + '/blacklist' + it('Should succeed with the owner authenticated user', async function () { + const res = await getVideoWithToken(server.url, userAccessToken1, server.video.uuid, 200) + const video: VideoDetails = res.body - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + userAccessToken) - .set('Accept', 'application/json') - .expect(403) + expect(video.blacklisted).to.be.true }) - it('Should fail with an incorrect id', async function () { - const path = basePath + 'foobar/blacklist' + it('Should succeed with an admin', async function () { + const res = await getVideoWithToken(server.url, server.accessToken, server.video.uuid, 200) + const video: VideoDetails = res.body - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + server.accessToken) - .set('Accept', 'application/json') - .expect(400) + expect(video.blacklisted).to.be.true + }) + }) + + describe('When removing a video in blacklist', function () { + it('Should fail with a non authenticated user', async function () { + await removeVideoFromBlacklist(server.url, 'fake token', server.video.uuid, 401) + }) + + it('Should fail with a non admin user', async function () { + await removeVideoFromBlacklist(server.url, userAccessToken2, server.video.uuid, 403) + }) + + it('Should fail with an incorrect id', async function () { + await removeVideoFromBlacklist(server.url, server.accessToken, 'hello', 400) }) it('Should fail with a not blacklisted video', async function () { // The video was not added to the blacklist so it should fail - const path = basePath + server.video.id + '/blacklist' + await removeVideoFromBlacklist(server.url, server.accessToken, notBlacklistedVideoId, 404) + }) - await request(server.url) - .delete(path) - .set('Authorization', 'Bearer ' + server.accessToken) - .set('Accept', 'application/json') - .expect(404) + it('Should succeed with the correct params', async function () { + await removeVideoFromBlacklist(server.url, server.accessToken, server.video.uuid, 204) }) }) @@ -129,58 +202,23 @@ describe('Test video blacklist API validators', function () { const basePath = '/api/v1/videos/blacklist/' it('Should fail with a non authenticated user', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ sort: 'createdAt' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + 'fake token') - .expect(401) + await getBlacklistedVideosList(server.url, 'fake token', 401) }) it('Should fail with a non admin user', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ sort: 'createdAt' }) - .set('Authorization', 'Bearer ' + userAccessToken) - .set('Accept', 'application/json') - .expect(403) + await getBlacklistedVideosList(server.url, userAccessToken2, 403) }) it('Should fail with a bad start pagination', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ start: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + await checkBadStartPagination(server.url, basePath, server.accessToken) }) it('Should fail with a bad count pagination', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ count: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + await checkBadCountPagination(server.url, basePath, server.accessToken) }) it('Should fail with an incorrect sort', async function () { - const path = basePath - - await request(server.url) - .get(path) - .query({ sort: 'foobar' }) - .set('Accept', 'application/json') - .set('Authorization', 'Bearer ' + server.accessToken) - .expect(400) + await checkBadSortPagination(server.url, basePath, server.accessToken) }) })