X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Ftests%2Fapi%2Fcheck-params%2Ffollows.ts;h=3c911dcee820341ae4ea990de465be7558a8eb97;hb=c5c95361e6adca439ae316066366e520797f9ec0;hp=2c2224a452b848a972362b6d06505b76ee78ec47;hpb=7024e9120b381b5b3201212f5a18f5cdc14e15ff;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/tests/api/check-params/follows.ts b/server/tests/api/check-params/follows.ts index 2c2224a45..3c911dcee 100644 --- a/server/tests/api/check-params/follows.ts +++ b/server/tests/api/check-params/follows.ts @@ -1,32 +1,26 @@ /* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */ -import 'mocha' - +import { checkBadCountPagination, checkBadSortPagination, checkBadStartPagination } from '@server/tests/shared' +import { HttpStatusCode } from '@shared/models' import { cleanupTests, - createUser, - flushAndRunServer, - makeDeleteRequest, makeGetRequest, + createSingleServer, + makeDeleteRequest, + makeGetRequest, makePostBodyRequest, - ServerInfo, - setAccessTokensToServers, - userLogin -} from '../../../../shared/extra-utils' -import { - checkBadCountPagination, - checkBadSortPagination, - checkBadStartPagination -} from '../../../../shared/extra-utils/requests/check-api-params' + PeerTubeServer, + setAccessTokensToServers +} from '@shared/server-commands' describe('Test server follows API validators', function () { - let server: ServerInfo + let server: PeerTubeServer // --------------------------------------------------------------- before(async function () { this.timeout(30000) - server = await flushAndRunServer(1) + server = await createSingleServer(1) await setAccessTokensToServers([ server ]) }) @@ -35,64 +29,68 @@ describe('Test server follows API validators', function () { let userAccessToken = null before(async function () { - const user = { - username: 'user1', - password: 'password' - } - - await createUser({ url: server.url, accessToken: server.accessToken, username: user.username, password: user.password }) - userAccessToken = await userLogin(server, user) + userAccessToken = await server.users.generateUserAndToken('user1') }) describe('When adding follows', function () { const path = '/api/v1/server/following' - it('Should fail without hosts', async function () { + it('Should fail with nothing', async function () { await makePostBodyRequest({ url: server.url, path, token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) - it('Should fail if hosts is not an array', async function () { + it('Should fail if hosts is not composed by hosts', async function () { await makePostBodyRequest({ url: server.url, path, + fields: { hosts: [ '127.0.0.1:9002', '127.0.0.1:coucou' ] }, token: server.accessToken, - fields: { hosts: 'localhost:9002' }, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) - it('Should fail if the array is not composed by hosts', async function () { + it('Should fail if hosts is composed with http schemes', async function () { await makePostBodyRequest({ url: server.url, path, - fields: { hosts: [ 'localhost:9002', 'localhost:coucou' ] }, + fields: { hosts: [ '127.0.0.1:9002', 'http://127.0.0.1:9003' ] }, token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) - it('Should fail if the array is composed with http schemes', async function () { + it('Should fail if hosts are not unique', async function () { await makePostBodyRequest({ url: server.url, path, - fields: { hosts: [ 'localhost:9002', 'http://localhost:9003' ] }, + fields: { urls: [ '127.0.0.1:9002', '127.0.0.1:9002' ] }, token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) - it('Should fail if hosts are not unique', async function () { + it('Should fail if handles is not composed by handles', async function () { + await makePostBodyRequest({ + url: server.url, + path, + fields: { handles: [ 'hello@example.com', '127.0.0.1:9001' ] }, + token: server.accessToken, + expectedStatus: HttpStatusCode.BAD_REQUEST_400 + }) + }) + + it('Should fail if handles are not unique', async function () { await makePostBodyRequest({ url: server.url, path, - fields: { urls: [ 'localhost:9002', 'localhost:9002' ] }, + fields: { urls: [ 'hello@example.com', 'hello@example.com' ] }, token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) @@ -100,9 +98,9 @@ describe('Test server follows API validators', function () { await makePostBodyRequest({ url: server.url, path, - fields: { hosts: [ 'localhost:9002' ] }, + fields: { hosts: [ '127.0.0.1:9002' ] }, token: 'fake_token', - statusCodeExpected: 401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) @@ -110,9 +108,9 @@ describe('Test server follows API validators', function () { await makePostBodyRequest({ url: server.url, path, - fields: { hosts: [ 'localhost:9002' ] }, + fields: { hosts: [ '127.0.0.1:9002' ] }, token: userAccessToken, - statusCodeExpected: 403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) }) @@ -156,7 +154,7 @@ describe('Test server follows API validators', function () { await makeGetRequest({ url: server.url, path, - statusCodeExpected: 200, + expectedStatus: HttpStatusCode.OK_200, query: { state: 'accepted', actorType: 'Application' @@ -205,7 +203,7 @@ describe('Test server follows API validators', function () { await makeGetRequest({ url: server.url, path, - statusCodeExpected: 200, + expectedStatus: HttpStatusCode.OK_200, query: { state: 'accepted' } @@ -219,18 +217,18 @@ describe('Test server follows API validators', function () { it('Should fail with an invalid token', async function () { await makeDeleteRequest({ url: server.url, - path: path + '/toto@localhost:9002', + path: path + '/toto@127.0.0.1:9002', token: 'fake_token', - statusCodeExpected: 401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail if the user is not an administrator', async function () { await makeDeleteRequest({ url: server.url, - path: path + '/toto@localhost:9002', + path: path + '/toto@127.0.0.1:9002', token: userAccessToken, - statusCodeExpected: 403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) @@ -239,16 +237,16 @@ describe('Test server follows API validators', function () { url: server.url, path: path + '/toto', token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) it('Should fail with an unknown follower', async function () { await makeDeleteRequest({ url: server.url, - path: path + '/toto@localhost:9003', + path: path + '/toto@127.0.0.1:9003', token: server.accessToken, - statusCodeExpected: 404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) }) @@ -259,18 +257,18 @@ describe('Test server follows API validators', function () { it('Should fail with an invalid token', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9002/accept', + path: path + '/toto@127.0.0.1:9002/accept', token: 'fake_token', - statusCodeExpected: 401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail if the user is not an administrator', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9002/accept', + path: path + '/toto@127.0.0.1:9002/accept', token: userAccessToken, - statusCodeExpected: 403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) @@ -279,16 +277,16 @@ describe('Test server follows API validators', function () { url: server.url, path: path + '/toto/accept', token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) it('Should fail with an unknown follower', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9003/accept', + path: path + '/toto@127.0.0.1:9003/accept', token: server.accessToken, - statusCodeExpected: 404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) }) @@ -299,18 +297,18 @@ describe('Test server follows API validators', function () { it('Should fail with an invalid token', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9002/reject', + path: path + '/toto@127.0.0.1:9002/reject', token: 'fake_token', - statusCodeExpected: 401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail if the user is not an administrator', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9002/reject', + path: path + '/toto@127.0.0.1:9002/reject', token: userAccessToken, - statusCodeExpected: 403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) @@ -319,16 +317,16 @@ describe('Test server follows API validators', function () { url: server.url, path: path + '/toto/reject', token: server.accessToken, - statusCodeExpected: 400 + expectedStatus: HttpStatusCode.BAD_REQUEST_400 }) }) it('Should fail with an unknown follower', async function () { await makePostBodyRequest({ url: server.url, - path: path + '/toto@localhost:9003/reject', + path: path + '/toto@127.0.0.1:9003/reject', token: server.accessToken, - statusCodeExpected: 404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) }) @@ -339,18 +337,18 @@ describe('Test server follows API validators', function () { it('Should fail with an invalid token', async function () { await makeDeleteRequest({ url: server.url, - path: path + '/localhost:9002', + path: path + '/127.0.0.1:9002', token: 'fake_token', - statusCodeExpected: 401 + expectedStatus: HttpStatusCode.UNAUTHORIZED_401 }) }) it('Should fail if the user is not an administrator', async function () { await makeDeleteRequest({ url: server.url, - path: path + '/localhost:9002', + path: path + '/127.0.0.1:9002', token: userAccessToken, - statusCodeExpected: 403 + expectedStatus: HttpStatusCode.FORBIDDEN_403 }) }) @@ -359,7 +357,7 @@ describe('Test server follows API validators', function () { url: server.url, path: path + '/example.com', token: server.accessToken, - statusCodeExpected: 404 + expectedStatus: HttpStatusCode.NOT_FOUND_404 }) }) })