X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Fvideos%2Fvideo-live.ts;h=b058ff5c189a91968c68ea149117c2d06df3073d;hb=c756bae079e02873f6433582ca14a092fec0db27;hp=cbc48fe93f0c5bd79dc137572e9ed05670b3aaf7;hpb=af4ae64f6faf38f8179f2e07d3cd4ad60006be92;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/videos/video-live.ts b/server/middlewares/validators/videos/video-live.ts index cbc48fe93..b058ff5c1 100644 --- a/server/middlewares/validators/videos/video-live.ts +++ b/server/middlewares/validators/videos/video-live.ts @@ -1,16 +1,19 @@ import * as express from 'express' import { body, param } from 'express-validator' -import { checkUserCanManageVideo, doesVideoChannelOfAccountExist, doesVideoExist } from '@server/helpers/middlewares/videos' +import { CONSTRAINTS_FIELDS } from '@server/initializers/constants' +import { isLocalLiveVideoAccepted } from '@server/lib/moderation' +import { Hooks } from '@server/lib/plugins/hooks' +import { VideoModel } from '@server/models/video/video' import { VideoLiveModel } from '@server/models/video/video-live' +import { HttpStatusCode } from '@shared/core-utils/miscs/http-error-codes' import { ServerErrorCode, UserRight, VideoState } from '@shared/models' import { isBooleanValid, isIdOrUUIDValid, isIdValid, toBooleanOrNull, toIntOrNull } from '../../../helpers/custom-validators/misc' import { isVideoNameValid } from '../../../helpers/custom-validators/videos' import { cleanUpReqFiles } from '../../../helpers/express-utils' import { logger } from '../../../helpers/logger' import { CONFIG } from '../../../initializers/config' -import { areValidationErrors } from '../utils' +import { areValidationErrors, checkUserCanManageVideo, doesVideoChannelOfAccountExist, doesVideoExist } from '../shared' import { getCommonVideoEditAttributes } from './videos' -import { VideoModel } from '@server/models/video/video' const videoLiveGetValidator = [ param('videoId').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid videoId'), @@ -26,7 +29,12 @@ const videoLiveGetValidator = [ if (!checkUserCanManageVideo(user, res.locals.videoAll, UserRight.GET_ANY_LIVE, res, false)) return const videoLive = await VideoLiveModel.loadByVideoId(res.locals.videoAll.id) - if (!videoLive) return res.sendStatus(404) + if (!videoLive) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Live video not found' + }) + } res.locals.videoLive = videoLive @@ -40,31 +48,50 @@ const videoLiveAddValidator = getCommonVideoEditAttributes().concat([ .custom(isIdValid).withMessage('Should have correct video channel id'), body('name') - .custom(isVideoNameValid).withMessage('Should have a valid name'), + .custom(isVideoNameValid).withMessage( + `Should have a video name between ${CONSTRAINTS_FIELDS.VIDEOS.NAME.min} and ${CONSTRAINTS_FIELDS.VIDEOS.NAME.max} characters long` + ), body('saveReplay') .optional() .customSanitizer(toBooleanOrNull) .custom(isBooleanValid).withMessage('Should have a valid saveReplay attribute'), + body('permanentLive') + .optional() + .customSanitizer(toBooleanOrNull) + .custom(isBooleanValid).withMessage('Should have a valid permanentLive attribute'), + async (req: express.Request, res: express.Response, next: express.NextFunction) => { logger.debug('Checking videoLiveAddValidator parameters', { parameters: req.body }) + if (areValidationErrors(req, res)) return cleanUpReqFiles(req) + if (CONFIG.LIVE.ENABLED !== true) { cleanUpReqFiles(req) - return res.status(403) - .json({ error: 'Live is not enabled on this instance' }) + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Live is not enabled on this instance', + type: ServerErrorCode.LIVE_NOT_ENABLED + }) } if (CONFIG.LIVE.ALLOW_REPLAY !== true && req.body.saveReplay === true) { cleanUpReqFiles(req) - return res.status(403) - .json({ error: 'Saving live replay is not allowed instance' }) + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Saving live replay is not enabled on this instance', + type: ServerErrorCode.LIVE_NOT_ALLOWING_REPLAY + }) } - if (areValidationErrors(req, res)) return cleanUpReqFiles(req) + if (req.body.permanentLive && req.body.saveReplay) { + cleanUpReqFiles(req) + + return res.fail({ message: 'Cannot set this live as permanent while saving its replay' }) + } const user = res.locals.oauth.token.User if (!await doesVideoChannelOfAccountExist(req.body.channelId, user, res)) return cleanUpReqFiles(req) @@ -75,11 +102,11 @@ const videoLiveAddValidator = getCommonVideoEditAttributes().concat([ if (totalInstanceLives >= CONFIG.LIVE.MAX_INSTANCE_LIVES) { cleanUpReqFiles(req) - return res.status(403) - .json({ - code: ServerErrorCode.MAX_INSTANCE_LIVES_LIMIT_REACHED, - error: 'Cannot create this live because the max instance lives limit is reached.' - }) + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Cannot create this live because the max instance lives limit is reached.', + type: ServerErrorCode.MAX_INSTANCE_LIVES_LIMIT_REACHED + }) } } @@ -89,14 +116,16 @@ const videoLiveAddValidator = getCommonVideoEditAttributes().concat([ if (totalUserLives >= CONFIG.LIVE.MAX_USER_LIVES) { cleanUpReqFiles(req) - return res.status(403) - .json({ - code: ServerErrorCode.MAX_USER_LIVES_LIMIT_REACHED, - error: 'Cannot create this live because the max user lives limit is reached.' - }) + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Cannot create this live because the max user lives limit is reached.', + type: ServerErrorCode.MAX_USER_LIVES_LIMIT_REACHED + }) } } + if (!await isLiveVideoAccepted(req, res)) return cleanUpReqFiles(req) + return next() } ]) @@ -112,14 +141,19 @@ const videoLiveUpdateValidator = [ if (areValidationErrors(req, res)) return + if (req.body.permanentLive && req.body.saveReplay) { + return res.fail({ message: 'Cannot set this live as permanent while saving its replay' }) + } + if (CONFIG.LIVE.ALLOW_REPLAY !== true && req.body.saveReplay === true) { - return res.status(403) - .json({ error: 'Saving live replay is not allowed instance' }) + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Saving live replay is not allowed instance' + }) } if (res.locals.videoAll.state !== VideoState.WAITING_FOR_LIVE) { - return res.status(400) - .json({ error: 'Cannot update a live that has already started' }) + return res.fail({ message: 'Cannot update a live that has already started' }) } // Check the user can manage the live @@ -137,3 +171,30 @@ export { videoLiveUpdateValidator, videoLiveGetValidator } + +// --------------------------------------------------------------------------- + +async function isLiveVideoAccepted (req: express.Request, res: express.Response) { + // Check we accept this video + const acceptParameters = { + liveVideoBody: req.body, + user: res.locals.oauth.token.User + } + const acceptedResult = await Hooks.wrapFun( + isLocalLiveVideoAccepted, + acceptParameters, + 'filter:api.live-video.create.accept.result' + ) + + if (!acceptedResult || acceptedResult.accepted !== true) { + logger.info('Refused local live video.', { acceptedResult, acceptParameters }) + + res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: acceptedResult.errorMessage || 'Refused local live video' + }) + return false + } + + return true +}