X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Fvideos%2Fvideo-channels.ts;h=ca6b5700355fb15ce1fdf8eb0b683dcfeea0d428;hb=cb0eda5602a21d1626a7face32de6153ed07b5f9;hp=f039794e090c47aca1e097bd863c0f90b2df10b3;hpb=6e46de095d7169355dd83030f6ce4a582304153a;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/videos/video-channels.ts b/server/middlewares/validators/videos/video-channels.ts index f039794e0..ca6b57003 100644 --- a/server/middlewares/validators/videos/video-channels.ts +++ b/server/middlewares/validators/videos/video-channels.ts @@ -1,50 +1,49 @@ -import * as express from 'express' -import { body, param } from 'express-validator/check' -import { UserRight } from '../../../../shared' -import { isAccountNameWithHostExist } from '../../../helpers/custom-validators/accounts' +import express from 'express' +import { body, param, query } from 'express-validator' +import { isUrlValid } from '@server/helpers/custom-validators/activitypub/misc' +import { CONFIG } from '@server/initializers/config' +import { MChannelAccountDefault } from '@server/types/models' +import { VideosImportInChannelCreate } from '@shared/models' +import { HttpStatusCode } from '../../../../shared/models/http/http-error-codes' +import { isBooleanValid, isIdValid, toBooleanOrNull } from '../../../helpers/custom-validators/misc' import { - isLocalVideoChannelNameExist, isVideoChannelDescriptionValid, - isVideoChannelNameValid, - isVideoChannelNameWithHostExist, - isVideoChannelSupportValid + isVideoChannelDisplayNameValid, + isVideoChannelSupportValid, + isVideoChannelUsernameValid } from '../../../helpers/custom-validators/video-channels' -import { logger } from '../../../helpers/logger' -import { UserModel } from '../../../models/account/user' +import { ActorModel } from '../../../models/actor/actor' import { VideoChannelModel } from '../../../models/video/video-channel' -import { areValidationErrors } from '../utils' -import { isActorPreferredUsernameValid } from '../../../helpers/custom-validators/activitypub/actor' -import { ActorModel } from '../../../models/activitypub/actor' - -const listVideoAccountChannelsValidator = [ - param('accountName').exists().withMessage('Should have a valid account name'), - - async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking listVideoAccountChannelsValidator parameters', { parameters: req.body }) - - if (areValidationErrors(req, res)) return - if (!await isAccountNameWithHostExist(req.params.accountName, res)) return - - return next() - } -] - -const videoChannelsAddValidator = [ - body('name').custom(isActorPreferredUsernameValid).withMessage('Should have a valid channel name'), - body('displayName').custom(isVideoChannelNameValid).withMessage('Should have a valid display name'), - body('description').optional().custom(isVideoChannelDescriptionValid).withMessage('Should have a valid description'), - body('support').optional().custom(isVideoChannelSupportValid).withMessage('Should have a valid support text'), +import { areValidationErrors, checkUserQuota, doesVideoChannelNameWithHostExist } from '../shared' +import { doesVideoChannelSyncIdExist } from '../shared/video-channel-syncs' + +export const videoChannelsAddValidator = [ + body('name') + .custom(isVideoChannelUsernameValid), + body('displayName') + .custom(isVideoChannelDisplayNameValid), + body('description') + .optional() + .custom(isVideoChannelDescriptionValid), + body('support') + .optional() + .custom(isVideoChannelSupportValid), async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking videoChannelsAdd parameters', { parameters: req.body }) - if (areValidationErrors(req, res)) return const actor = await ActorModel.loadLocalByName(req.body.name) if (actor) { - res.status(409) - .send({ error: 'Another actor (account/channel) with this name on this instance already exists or has already existed.' }) - .end() + res.fail({ + status: HttpStatusCode.CONFLICT_409, + message: 'Another actor (account/channel) with this name on this instance already exists or has already existed.' + }) + return false + } + + const count = await VideoChannelModel.countByAccount(res.locals.oauth.token.User.Account.id) + if (count >= CONFIG.VIDEO_CHANNELS.MAX_PER_USER) { + res.fail({ message: `You cannot create more than ${CONFIG.VIDEO_CHANNELS.MAX_PER_USER} channels` }) return false } @@ -52,122 +51,142 @@ const videoChannelsAddValidator = [ } ] -const videoChannelsUpdateValidator = [ - param('nameWithHost').exists().withMessage('Should have an video channel name with host'), - body('displayName').optional().custom(isVideoChannelNameValid).withMessage('Should have a valid display name'), - body('description').optional().custom(isVideoChannelDescriptionValid).withMessage('Should have a valid description'), - body('support').optional().custom(isVideoChannelSupportValid).withMessage('Should have a valid support text'), - - async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking videoChannelsUpdate parameters', { parameters: req.body }) - +export const videoChannelsUpdateValidator = [ + param('nameWithHost') + .exists(), + + body('displayName') + .optional() + .custom(isVideoChannelDisplayNameValid), + body('description') + .optional() + .custom(isVideoChannelDescriptionValid), + body('support') + .optional() + .custom(isVideoChannelSupportValid), + body('bulkVideosSupportUpdate') + .optional() + .custom(isBooleanValid).withMessage('Should have a valid bulkVideosSupportUpdate boolean field'), + + (req: express.Request, res: express.Response, next: express.NextFunction) => { if (areValidationErrors(req, res)) return - if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return - // We need to make additional checks - if (res.locals.videoChannel.Actor.isOwned() === false) { - return res.status(403) - .json({ error: 'Cannot update video channel of another server' }) - .end() - } + return next() + } +] - if (res.locals.videoChannel.Account.userId !== res.locals.oauth.token.User.id) { - return res.status(403) - .json({ error: 'Cannot update video channel of another user' }) - .end() - } +export const videoChannelsRemoveValidator = [ + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (!await checkVideoChannelIsNotTheLastOne(res.locals.videoChannel, res)) return return next() } ] -const videoChannelsRemoveValidator = [ - param('nameWithHost').exists().withMessage('Should have an video channel name with host'), +export const videoChannelsNameWithHostValidator = [ + param('nameWithHost') + .exists(), async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking videoChannelsRemove parameters', { parameters: req.params }) - if (areValidationErrors(req, res)) return - if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return - if (!checkUserCanDeleteVideoChannel(res.locals.oauth.token.User, res.locals.videoChannel, res)) return - if (!await checkVideoChannelIsNotTheLastOne(res)) return + if (!await doesVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return return next() } ] -const videoChannelsNameWithHostValidator = [ - param('nameWithHost').exists().withMessage('Should have an video channel name with host'), +export const ensureIsLocalChannel = [ + (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (res.locals.videoChannel.Actor.isOwned() === false) { + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'This channel is not owned.' + }) + } + return next() + } +] + +export const ensureChannelOwnerCanUpload = [ async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking videoChannelsNameWithHostValidator parameters', { parameters: req.params }) + const channel = res.locals.videoChannel + const user = { id: channel.Account.userId } - if (areValidationErrors(req, res)) return + if (!await checkUserQuota(user, 1, res)) return + + next() + } +] - if (!await isVideoChannelNameWithHostExist(req.params.nameWithHost, res)) return +export const videoChannelStatsValidator = [ + query('withStats') + .optional() + .customSanitizer(toBooleanOrNull) + .custom(isBooleanValid).withMessage('Should have a valid stats flag boolean'), + (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return return next() } ] -const localVideoChannelValidator = [ - param('name').custom(isVideoChannelNameValid).withMessage('Should have a valid video channel name'), - - async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking localVideoChannelValidator parameters', { parameters: req.params }) +export const videoChannelsListValidator = [ + query('search') + .optional() + .not().isEmpty(), + (req: express.Request, res: express.Response, next: express.NextFunction) => { if (areValidationErrors(req, res)) return - if (!await isLocalVideoChannelNameExist(req.params.name, res)) return return next() } ] -// --------------------------------------------------------------------------- +export const videoChannelImportVideosValidator = [ + body('externalChannelUrl') + .custom(isUrlValid), -export { - listVideoAccountChannelsValidator, - videoChannelsAddValidator, - videoChannelsUpdateValidator, - videoChannelsRemoveValidator, - videoChannelsNameWithHostValidator, - localVideoChannelValidator -} + body('videoChannelSyncId') + .optional() + .custom(isIdValid), -// --------------------------------------------------------------------------- + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return -function checkUserCanDeleteVideoChannel (user: UserModel, videoChannel: VideoChannelModel, res: express.Response) { - if (videoChannel.Actor.isOwned() === false) { - res.status(403) - .json({ error: 'Cannot remove video channel of another server.' }) - .end() + const body: VideosImportInChannelCreate = req.body - return false - } + if (!CONFIG.IMPORT.VIDEOS.HTTP.ENABLED) { + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'Channel import is impossible as video upload via HTTP is not enabled on the server' + }) + } - // Check if the user can delete the video channel - // The user can delete it if s/he is an admin - // Or if s/he is the video channel's account - if (user.hasRight(UserRight.REMOVE_ANY_VIDEO_CHANNEL) === false && videoChannel.Account.userId !== user.id) { - res.status(403) - .json({ error: 'Cannot remove video channel of another user' }) - .end() + if (body.videoChannelSyncId && !await doesVideoChannelSyncIdExist(body.videoChannelSyncId, res)) return - return false + if (res.locals.videoChannelSync && res.locals.videoChannelSync.videoChannelId !== res.locals.videoChannel.id) { + return res.fail({ + status: HttpStatusCode.FORBIDDEN_403, + message: 'This channel sync is not owned by this channel' + }) + } + + return next() } +] - return true -} +// --------------------------------------------------------------------------- -async function checkVideoChannelIsNotTheLastOne (res: express.Response) { - const count = await VideoChannelModel.countByAccount(res.locals.oauth.token.User.Account.id) +async function checkVideoChannelIsNotTheLastOne (videoChannel: MChannelAccountDefault, res: express.Response) { + const count = await VideoChannelModel.countByAccount(videoChannel.Account.id) if (count <= 1) { - res.status(409) - .json({ error: 'Cannot remove the last channel of this user' }) - .end() - + res.fail({ + status: HttpStatusCode.CONFLICT_409, + message: 'Cannot remove the last channel of this user' + }) return false }