X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Futils.ts;h=43e5652fa2c2764706da943d5eb122b78ac46230;hb=adc1f09c0dbd997f34028c1c82d1c118dc8ead80;hp=ea107bbe8f67b5036b7f24a964d470de76b7d968;hpb=8a02bd0433b7101c5ea36e87a4edb63204d2adec;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/utils.ts b/server/middlewares/validators/utils.ts index ea107bbe8..43e5652fa 100644 --- a/server/middlewares/validators/utils.ts +++ b/server/middlewares/validators/utils.ts @@ -1,21 +1,44 @@ -import { validationResult } from 'express-validator/check' import * as express from 'express' +import { query, validationResult } from 'express-validator' +import { logger } from '../../helpers/logger' -import { logger } from '../../helpers' - -function checkErrors (req: express.Request, res: express.Response, next: express.NextFunction) { +function areValidationErrors (req: express.Request, res: express.Response) { const errors = validationResult(req) if (!errors.isEmpty()) { logger.warn('Incorrect request parameters', { path: req.originalUrl, err: errors.mapped() }) - return res.status(400).json({ errors: errors.mapped() }) + res.status(400).json({ errors: errors.mapped() }) + + return true } - return next() + return false +} + +function checkSort (sortableColumns: string[]) { + return [ + query('sort').optional().isIn(sortableColumns).withMessage('Should have correct sortable column'), + + (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking sort parameters', { parameters: req.query }) + + if (areValidationErrors(req, res)) return + + return next() + } + ] +} + +function createSortableColumns (sortableColumns: string[]) { + const sortableColumnDesc = sortableColumns.map(sortableColumn => '-' + sortableColumn) + + return sortableColumns.concat(sortableColumnDesc) } // --------------------------------------------------------------------------- export { - checkErrors + areValidationErrors, + checkSort, + createSortableColumns }