X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Fredundancy.ts;h=c80f9b728251e214e931d778b49bdad4a90bf166;hb=2c015b54192f2080f756c424173bac2bd53e7ca9;hp=c72ab78b23fa2c253a83956a51ae4e8e6d37b89b;hpb=46f8d69b4e58a3006c32b2e0d97b9262fd30fd6b;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/redundancy.ts b/server/middlewares/validators/redundancy.ts index c72ab78b2..c80f9b728 100644 --- a/server/middlewares/validators/redundancy.ts +++ b/server/middlewares/validators/redundancy.ts @@ -1,44 +1,98 @@ -import * as express from 'express' -import 'express-validator' -import { param, body } from 'express-validator/check' -import { exists, isBooleanValid, isIdOrUUIDValid, toIntOrNull } from '../../helpers/custom-validators/misc' -import { isVideoExist } from '../../helpers/custom-validators/videos' -import { logger } from '../../helpers/logger' -import { areValidationErrors } from './utils' -import { VideoModel } from '../../models/video/video' -import { VideoRedundancyModel } from '../../models/redundancy/video-redundancy' +import express from 'express' +import { body, param, query } from 'express-validator' +import { isVideoRedundancyTarget } from '@server/helpers/custom-validators/video-redundancies' +import { forceNumber } from '@shared/core-utils' +import { HttpStatusCode } from '../../../shared/models/http/http-error-codes' +import { + exists, + isBooleanValid, + isIdOrUUIDValid, + isIdValid, + toBooleanOrNull, + toCompleteUUID, + toIntOrNull +} from '../../helpers/custom-validators/misc' import { isHostValid } from '../../helpers/custom-validators/servers' -import { getServerActor } from '../../helpers/utils' -import { ActorFollowModel } from '../../models/activitypub/actor-follow' -import { SERVER_ACTOR_NAME } from '../../initializers' +import { VideoRedundancyModel } from '../../models/redundancy/video-redundancy' import { ServerModel } from '../../models/server/server' +import { areValidationErrors, doesVideoExist, isValidVideoIdParam } from './shared' + +const videoFileRedundancyGetValidator = [ + isValidVideoIdParam('videoId'), -const videoRedundancyGetValidator = [ - param('videoId').custom(isIdOrUUIDValid).not().isEmpty().withMessage('Should have a valid video id'), param('resolution') .customSanitizer(toIntOrNull) - .custom(exists).withMessage('Should have a valid resolution'), + .custom(exists), param('fps') .optional() .customSanitizer(toIntOrNull) - .custom(exists).withMessage('Should have a valid fps'), + .custom(exists), async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking videoRedundancyGetValidator parameters', { parameters: req.params }) - if (areValidationErrors(req, res)) return - if (!await isVideoExist(req.params.videoId, res)) return + if (!await doesVideoExist(req.params.videoId, res)) return + + const video = res.locals.videoAll + + const paramResolution = req.params.resolution as unknown as number // We casted to int above + const paramFPS = req.params.fps as unknown as number // We casted to int above - const video: VideoModel = res.locals.video const videoFile = video.VideoFiles.find(f => { - return f.resolution === req.params.resolution && (!req.params.fps || f.fps === req.params.fps) + return f.resolution === paramResolution && (!req.params.fps || paramFPS) }) - if (!videoFile) return res.status(404).json({ error: 'Video file not found.' }) + if (!videoFile) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Video file not found.' + }) + } res.locals.videoFile = videoFile const videoRedundancy = await VideoRedundancyModel.loadLocalByFileId(videoFile.id) - if (!videoRedundancy)return res.status(404).json({ error: 'Video redundancy not found.' }) + if (!videoRedundancy) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Video redundancy not found.' + }) + } + res.locals.videoRedundancy = videoRedundancy + + return next() + } +] + +const videoPlaylistRedundancyGetValidator = [ + isValidVideoIdParam('videoId'), + + param('streamingPlaylistType') + .customSanitizer(toIntOrNull) + .custom(exists), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return + if (!await doesVideoExist(req.params.videoId, res)) return + + const video = res.locals.videoAll + + const paramPlaylistType = req.params.streamingPlaylistType as unknown as number // We casted to int above + const videoStreamingPlaylist = video.VideoStreamingPlaylists.find(p => p.type === paramPlaylistType) + + if (!videoStreamingPlaylist) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Video playlist not found.' + }) + } + res.locals.videoStreamingPlaylist = videoStreamingPlaylist + + const videoRedundancy = await VideoRedundancyModel.loadLocalByStreamingPlaylistId(videoStreamingPlaylist.id) + if (!videoRedundancy) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Video redundancy not found.' + }) + } res.locals.videoRedundancy = videoRedundancy return next() @@ -46,25 +100,23 @@ const videoRedundancyGetValidator = [ ] const updateServerRedundancyValidator = [ - param('host').custom(isHostValid).withMessage('Should have a valid host'), + param('host') + .custom(isHostValid), + body('redundancyAllowed') - .toBoolean() - .custom(isBooleanValid).withMessage('Should have a valid redundancyAllowed attribute'), + .customSanitizer(toBooleanOrNull) + .custom(isBooleanValid).withMessage('Should have a valid redundancyAllowed boolean'), async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking updateServerRedundancy parameters', { parameters: req.params }) - if (areValidationErrors(req, res)) return const server = await ServerModel.loadByHost(req.params.host) if (!server) { - return res - .status(404) - .json({ - error: `Server ${req.params.host} not found.` - }) - .end() + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: `Server ${req.params.host} not found.` + }) } res.locals.server = server @@ -72,9 +124,75 @@ const updateServerRedundancyValidator = [ } ] +const listVideoRedundanciesValidator = [ + query('target') + .custom(isVideoRedundancyTarget), + + (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return + + return next() + } +] + +const addVideoRedundancyValidator = [ + body('videoId') + .customSanitizer(toCompleteUUID) + .custom(isIdOrUUIDValid), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return + + if (!await doesVideoExist(req.body.videoId, res, 'only-video')) return + + if (res.locals.onlyVideo.remote === false) { + return res.fail({ message: 'Cannot create a redundancy on a local video' }) + } + + if (res.locals.onlyVideo.isLive) { + return res.fail({ message: 'Cannot create a redundancy of a live video' }) + } + + const alreadyExists = await VideoRedundancyModel.isLocalByVideoUUIDExists(res.locals.onlyVideo.uuid) + if (alreadyExists) { + return res.fail({ + status: HttpStatusCode.CONFLICT_409, + message: 'This video is already duplicated by your instance.' + }) + } + + return next() + } +] + +const removeVideoRedundancyValidator = [ + param('redundancyId') + .custom(isIdValid), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + if (areValidationErrors(req, res)) return + + const redundancy = await VideoRedundancyModel.loadByIdWithVideo(forceNumber(req.params.redundancyId)) + if (!redundancy) { + return res.fail({ + status: HttpStatusCode.NOT_FOUND_404, + message: 'Video redundancy not found' + }) + } + + res.locals.videoRedundancy = redundancy + + return next() + } +] + // --------------------------------------------------------------------------- export { - videoRedundancyGetValidator, - updateServerRedundancyValidator + videoFileRedundancyGetValidator, + videoPlaylistRedundancyGetValidator, + updateServerRedundancyValidator, + listVideoRedundanciesValidator, + addVideoRedundancyValidator, + removeVideoRedundancyValidator }