X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Ffollows.ts;h=bdf39eb9c543389b58139d87e8e5339e822b6c54;hb=7279b455811f4806dcb74a08d17b837bc22533c1;hp=10482e5d0a87fc7b3a781177d8da88683688068e;hpb=3fd3ab2d34d512b160a5e6084d7609be7b4f4452;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/follows.ts b/server/middlewares/validators/follows.ts index 10482e5d0..bdf39eb9c 100644 --- a/server/middlewares/validators/follows.ts +++ b/server/middlewares/validators/follows.ts @@ -1,10 +1,11 @@ import * as express from 'express' import { body, param } from 'express-validator/check' -import { getServerAccount, isTestInstance, logger } from '../../helpers' -import { isIdOrUUIDValid } from '../../helpers/custom-validators/misc' -import { isEachUniqueHostValid } from '../../helpers/custom-validators/servers' +import { isTestInstance } from '../../helpers/core-utils' +import { isEachUniqueHostValid, isHostValid } from '../../helpers/custom-validators/servers' +import { logger } from '../../helpers/logger' +import { getServerActor } from '../../helpers/utils' import { CONFIG } from '../../initializers' -import { AccountFollowModel } from '../../models/account/account-follow' +import { ActorFollowModel } from '../../models/activitypub/actor-follow' import { areValidationErrors } from './utils' const followValidator = [ @@ -15,7 +16,7 @@ const followValidator = [ if (isTestInstance() === false && CONFIG.WEBSERVER.SCHEME === 'http') { return res.status(400) .json({ - error: 'Cannot follow non HTTPS web server.' + error: 'Cannot follow on a non HTTPS web server.' }) .end() } @@ -29,18 +30,22 @@ const followValidator = [ ] const removeFollowingValidator = [ - param('accountId').custom(isIdOrUUIDValid).withMessage('Should have a valid account id'), + param('host').custom(isHostValid).withMessage('Should have a valid host'), async (req: express.Request, res: express.Response, next: express.NextFunction) => { logger.debug('Checking unfollow parameters', { parameters: req.params }) if (areValidationErrors(req, res)) return - const serverAccount = await getServerAccount() - const follow = await AccountFollowModel.loadByAccountAndTarget(serverAccount.id, req.params.accountId) + const serverActor = await getServerActor() + const follow = await ActorFollowModel.loadByActorAndTargetHost(serverActor.id, req.params.host) if (!follow) { - return res.status(404) + return res + .status(404) + .json({ + error: `Follower ${req.params.host} not found.` + }) .end() }