X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Ffollows.ts;h=b360cf95ee0656a8227e613a32b6ccf0b0db490f;hb=fd8710b897a67518d3a61c319e54b6a65ba443ef;hp=faefc1179a17e7a3321ed0c70c2d35c254c195fa;hpb=06a05d5f4784a7cbb27aa1188385b5679845dad8;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/follows.ts b/server/middlewares/validators/follows.ts index faefc1179..b360cf95e 100644 --- a/server/middlewares/validators/follows.ts +++ b/server/middlewares/validators/follows.ts @@ -7,6 +7,9 @@ import { getServerActor } from '../../helpers/utils' import { CONFIG, SERVER_ACTOR_NAME } from '../../initializers' import { ActorFollowModel } from '../../models/activitypub/actor-follow' import { areValidationErrors } from './utils' +import { ActorModel } from '../../models/activitypub/actor' +import { loadActorUrlOrGetFromWebfinger } from '../../helpers/webfinger' +import { isValidActorHandle } from '../../helpers/custom-validators/activitypub/actor' const followValidator = [ body('hosts').custom(isEachUniqueHostValid).withMessage('Should have an array of unique hosts'), @@ -33,18 +36,18 @@ const removeFollowingValidator = [ param('host').custom(isHostValid).withMessage('Should have a valid host'), async (req: express.Request, res: express.Response, next: express.NextFunction) => { - logger.debug('Checking unfollow parameters', { parameters: req.params }) + logger.debug('Checking unfollowing parameters', { parameters: req.params }) if (areValidationErrors(req, res)) return const serverActor = await getServerActor() - const follow = await ActorFollowModel.loadByActorAndTargetNameAndHost(serverActor.id, SERVER_ACTOR_NAME, req.params.host) + const follow = await ActorFollowModel.loadByActorAndTargetNameAndHostForAPI(serverActor.id, SERVER_ACTOR_NAME, req.params.host) if (!follow) { return res .status(404) .json({ - error: `Follower ${req.params.host} not found.` + error: `Following ${req.params.host} not found.` }) .end() } @@ -54,9 +57,57 @@ const removeFollowingValidator = [ } ] +const getFollowerValidator = [ + param('nameWithHost').custom(isValidActorHandle).withMessage('Should have a valid nameWithHost'), + + async (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking get follower parameters', { parameters: req.params }) + + if (areValidationErrors(req, res)) return + + let follow: ActorFollowModel + try { + const actorUrl = await loadActorUrlOrGetFromWebfinger(req.params.nameWithHost) + const actor = await ActorModel.loadByUrl(actorUrl) + + const serverActor = await getServerActor() + follow = await ActorFollowModel.loadByActorAndTarget(actor.id, serverActor.id) + } catch (err) { + logger.warn('Cannot get actor from handle.', { handle: req.params.nameWithHost, err }) + } + + if (!follow) { + return res + .status(404) + .json({ + error: `Follower ${req.params.nameWithHost} not found.` + }) + .end() + } + + res.locals.follow = follow + return next() + } +] + +const acceptOrRejectFollowerValidator = [ + (req: express.Request, res: express.Response, next: express.NextFunction) => { + logger.debug('Checking accept/reject follower parameters', { parameters: req.params }) + + const follow = res.locals.follow + if (follow.state !== 'pending') { + return res.status(400).json({ error: 'Follow is not in pending state.' }).end() + } + + return next() + } +] + // --------------------------------------------------------------------------- export { followValidator, - removeFollowingValidator + removeFollowingValidator, + getFollowerValidator, + acceptOrRejectFollowerValidator }