X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Fvalidators%2Fblocklist.ts;h=f61811a1a6983190991bd98c72f423bc24d22d2e;hb=f479685678406a5df864d89615b33d29085ebfc6;hp=27224ff9b5c5218a45e20d52817dc9fd528034ac;hpb=610d0be13b3d01f653ef269271dd667a57c85ef2;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/validators/blocklist.ts b/server/middlewares/validators/blocklist.ts index 27224ff9b..f61811a1a 100644 --- a/server/middlewares/validators/blocklist.ts +++ b/server/middlewares/validators/blocklist.ts @@ -9,6 +9,7 @@ import { ServerModel } from '../../models/server/server' import { WEBSERVER } from '../../initializers/constants' import { doesAccountNameWithHostExist } from '../../helpers/middlewares' import { getServerActor } from '@server/models/application/application' +import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes' const blockAccountValidator = [ body('accountName').exists().withMessage('Should have an account name with host'), @@ -23,9 +24,8 @@ const blockAccountValidator = [ const accountToBlock = res.locals.account if (user.Account.id === accountToBlock.id) { - res.status(409) - .send({ error: 'You cannot block yourself.' }) - .end() + res.status(HttpStatusCode.CONFLICT_409) + .json({ error: 'You cannot block yourself.' }) return } @@ -79,9 +79,8 @@ const blockServerValidator = [ const host: string = req.body.host if (host === WEBSERVER.HOST) { - return res.status(409) - .send({ error: 'You cannot block your own server.' }) - .end() + return res.status(HttpStatusCode.CONFLICT_409) + .json({ error: 'You cannot block your own server.' }) } const server = await ServerModel.loadOrCreateByHost(host) @@ -138,9 +137,8 @@ export { async function doesUnblockAccountExist (accountId: number, targetAccountId: number, res: express.Response) { const accountBlock = await AccountBlocklistModel.loadByAccountAndTarget(accountId, targetAccountId) if (!accountBlock) { - res.status(404) - .send({ error: 'Account block entry not found.' }) - .end() + res.status(HttpStatusCode.NOT_FOUND_404) + .json({ error: 'Account block entry not found.' }) return false } @@ -153,9 +151,8 @@ async function doesUnblockAccountExist (accountId: number, targetAccountId: numb async function doesUnblockServerExist (accountId: number, host: string, res: express.Response) { const serverBlock = await ServerBlocklistModel.loadByAccountAndHost(accountId, host) if (!serverBlock) { - res.status(404) - .send({ error: 'Server block entry not found.' }) - .end() + res.status(HttpStatusCode.NOT_FOUND_404) + .json({ error: 'Server block entry not found.' }) return false }