X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fmiddlewares%2Foauth.ts;h=8c1df2c3eaa2688f5edaa302aa49c5b9154d3b48;hb=1de1d05f4c61fe059fa5e24e79c92582f0e7e4b3;hp=9976993e03b8a08919ae3fe12fc8b74ae170369d;hpb=93e4a311f37d7fc82ec81190553f8beae28fdef5;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/middlewares/oauth.ts b/server/middlewares/oauth.ts index 9976993e0..8c1df2c3e 100644 --- a/server/middlewares/oauth.ts +++ b/server/middlewares/oauth.ts @@ -2,6 +2,7 @@ import * as express from 'express' import * as OAuthServer from 'express-oauth-server' import 'express-validator' import { OAUTH_LIFETIME } from '../initializers' +import { logger } from '../helpers/logger' const oAuthServer = new OAuthServer({ useErrorHandler: true, @@ -13,9 +14,11 @@ const oAuthServer = new OAuthServer({ function authenticate (req: express.Request, res: express.Response, next: express.NextFunction) { oAuthServer.authenticate()(req, res, err => { if (err) { + logger.warn('Cannot authenticate.', { err }) + return res.status(err.status) .json({ - error: 'Authentication failed.', + error: 'Token is invalid.', code: err.name }) .end() @@ -25,13 +28,47 @@ function authenticate (req: express.Request, res: express.Response, next: expres }) } +function authenticatePromiseIfNeeded (req: express.Request, res: express.Response) { + return new Promise(resolve => { + // Already authenticated? (or tried to) + if (res.locals.oauth && res.locals.oauth.token.User) return resolve() + + if (res.locals.authenticated === false) return res.sendStatus(401) + + authenticate(req, res, () => { + return resolve() + }) + }) +} + +function optionalAuthenticate (req: express.Request, res: express.Response, next: express.NextFunction) { + if (req.header('authorization')) return authenticate(req, res, next) + + res.locals.authenticated = false + + return next() +} + function token (req: express.Request, res: express.Response, next: express.NextFunction) { - return oAuthServer.token()(req, res, next) + return oAuthServer.token()(req, res, err => { + if (err) { + return res.status(err.status) + .json({ + error: err.message, + code: err.name + }) + .end() + } + + return next() + }) } // --------------------------------------------------------------------------- export { authenticate, + authenticatePromiseIfNeeded, + optionalAuthenticate, token }