X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Flive%2Flive-segment-sha-store.ts;h=1a0a93985598721cb4fd5ad17bfc8ed7a1a21c13;hb=3733175b6b53d8f9cdc3e1752110a030508907af;hp=251301141c69562398d8db1e9d6c2e1f95748506;hpb=0c9668f77901e7540e2c7045eb0f2974a4842a69;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/live/live-segment-sha-store.ts b/server/lib/live/live-segment-sha-store.ts index 251301141..1a0a93985 100644 --- a/server/lib/live/live-segment-sha-store.ts +++ b/server/lib/live/live-segment-sha-store.ts @@ -1,11 +1,11 @@ -import { writeJson } from 'fs-extra' +import { rename, writeJson } from 'fs-extra' +import PQueue from 'p-queue' import { basename } from 'path' import { mapToJSON } from '@server/helpers/core-utils' import { logger, loggerTagsFactory } from '@server/helpers/logger' import { MStreamingPlaylistVideo } from '@server/types/models' import { buildSha256Segment } from '../hls' import { storeHLSFileFromPath } from '../object-storage' -import PQueue from 'p-queue' const lTags = loggerTagsFactory('live') @@ -14,7 +14,10 @@ class LiveSegmentShaStore { private readonly segmentsSha256 = new Map() private readonly videoUUID: string + private readonly sha256Path: string + private readonly sha256PathTMP: string + private readonly streamingPlaylist: MStreamingPlaylistVideo private readonly sendToObjectStorage: boolean private readonly writeQueue = new PQueue({ concurrency: 1 }) @@ -26,7 +29,10 @@ class LiveSegmentShaStore { sendToObjectStorage: boolean }) { this.videoUUID = options.videoUUID + this.sha256Path = options.sha256Path + this.sha256PathTMP = options.sha256Path + '.tmp' + this.streamingPlaylist = options.streamingPlaylist this.sendToObjectStorage = options.sendToObjectStorage } @@ -66,7 +72,9 @@ class LiveSegmentShaStore { private writeToDisk () { return this.writeQueue.add(async () => { - await writeJson(this.sha256Path, mapToJSON(this.segmentsSha256)) + // Atomic write: use rename instead of move that is not atomic + await writeJson(this.sha256PathTMP, mapToJSON(this.segmentsSha256)) + await rename(this.sha256PathTMP, this.sha256Path) if (this.sendToObjectStorage) { const url = await storeHLSFileFromPath(this.streamingPlaylist, this.sha256Path)