X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Ffiles-cache%2Fvideos-caption-cache.ts;h=d21acf4ef7fa666c955590675643bb47d3f5c6b9;hb=2c015b54192f2080f756c424173bac2bd53e7ca9;hp=26ab3bd0d0c621b35b84f005fb69ccd059f76361;hpb=ca6d36227a9273f616a462d3aad6a721ab5dd627;p=github%2FChocobozzz%2FPeerTube.git

diff --git a/server/lib/files-cache/videos-caption-cache.ts b/server/lib/files-cache/videos-caption-cache.ts
index 26ab3bd0d..d21acf4ef 100644
--- a/server/lib/files-cache/videos-caption-cache.ts
+++ b/server/lib/files-cache/videos-caption-cache.ts
@@ -1,17 +1,14 @@
 import { join } from 'path'
+import { logger } from '@server/helpers/logger'
+import { doRequestAndSaveToFile } from '@server/helpers/requests'
+import { CONFIG } from '../../initializers/config'
 import { FILES_CACHE } from '../../initializers/constants'
 import { VideoModel } from '../../models/video/video'
 import { VideoCaptionModel } from '../../models/video/video-caption'
 import { AbstractVideoStaticFileCache } from './abstract-video-static-file-cache'
-import { CONFIG } from '../../initializers/config'
-import { logger } from '../../helpers/logger'
-import { doRequestAndSaveToFile } from '@server/helpers/requests'
 
-type GetPathParam = { videoId: string, language: string }
+class VideosCaptionCache extends AbstractVideoStaticFileCache <string> {
 
-class VideosCaptionCache extends AbstractVideoStaticFileCache <GetPathParam> {
-
-  private static readonly KEY_DELIMITER = '%'
   private static instance: VideosCaptionCache
 
   private constructor () {
@@ -22,36 +19,38 @@ class VideosCaptionCache extends AbstractVideoStaticFileCache <GetPathParam> {
     return this.instance || (this.instance = new this())
   }
 
-  async getFilePathImpl (params: GetPathParam) {
-    const videoCaption = await VideoCaptionModel.loadByVideoIdAndLanguage(params.videoId, params.language)
+  async getFilePathImpl (filename: string) {
+    const videoCaption = await VideoCaptionModel.loadWithVideoByFilename(filename)
     if (!videoCaption) return undefined
 
-    if (videoCaption.isOwned()) return { isOwned: true, path: join(CONFIG.STORAGE.CAPTIONS_DIR, videoCaption.getCaptionName()) }
+    if (videoCaption.isOwned()) return { isOwned: true, path: join(CONFIG.STORAGE.CAPTIONS_DIR, videoCaption.filename) }
 
-    const key = params.videoId + VideosCaptionCache.KEY_DELIMITER + params.language
-    return this.loadRemoteFile(key)
+    return this.loadRemoteFile(filename)
   }
 
+  // Key is the caption filename
   protected async loadRemoteFile (key: string) {
-    logger.debug('Loading remote caption file %s.', key)
-
-    const [ videoId, language ] = key.split(VideosCaptionCache.KEY_DELIMITER)
-
-    const videoCaption = await VideoCaptionModel.loadByVideoIdAndLanguage(videoId, language)
+    const videoCaption = await VideoCaptionModel.loadWithVideoByFilename(key)
     if (!videoCaption) return undefined
 
     if (videoCaption.isOwned()) throw new Error('Cannot load remote caption of owned video.')
 
     // Used to fetch the path
-    const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(videoId)
+    const video = await VideoModel.loadFull(videoCaption.videoId)
     if (!video) return undefined
 
     const remoteUrl = videoCaption.getFileUrl(video)
-    const destPath = join(FILES_CACHE.VIDEO_CAPTIONS.DIRECTORY, videoCaption.getCaptionName())
+    const destPath = join(FILES_CACHE.VIDEO_CAPTIONS.DIRECTORY, videoCaption.filename)
+
+    try {
+      await doRequestAndSaveToFile(remoteUrl, destPath)
 
-    await doRequestAndSaveToFile({ uri: remoteUrl }, destPath)
+      return { isOwned: false, path: destPath }
+    } catch (err) {
+      logger.info('Cannot fetch remote caption file %s.', remoteUrl, { err })
 
-    return { isOwned: false, path: destPath }
+      return undefined
+    }
   }
 }