X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Factivitypub%2Fvideos.ts;h=907f7e11e273e55a559af20f7f9762de0498846f;hb=28be89161aab245526d64f6fb7dd29391a97fe0a;hp=1d2d46cbc199e915d246545c637e21adbaee538f;hpb=f05a1c30c15d2ae35c11e241ca039a72eeb7d6ad;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/activitypub/videos.ts b/server/lib/activitypub/videos.ts index 1d2d46cbc..907f7e11e 100644 --- a/server/lib/activitypub/videos.ts +++ b/server/lib/activitypub/videos.ts @@ -4,13 +4,14 @@ import { join } from 'path' import * as request from 'request' import { ActivityIconObject } from '../../../shared/index' import { VideoTorrentObject } from '../../../shared/models/activitypub/objects' -import { VideoPrivacy } from '../../../shared/models/videos' -import { isVideoTorrentObjectValid } from '../../helpers/custom-validators/activitypub/videos' +import { VideoPrivacy, VideoRateType } from '../../../shared/models/videos' +import { sanitizeAndCheckVideoTorrentObject } from '../../helpers/custom-validators/activitypub/videos' import { isVideoFileInfoHashValid } from '../../helpers/custom-validators/videos' import { retryTransactionWrapper } from '../../helpers/database-utils' import { logger } from '../../helpers/logger' import { doRequest, doRequestAndSaveToFile } from '../../helpers/requests' import { ACTIVITY_PUB, CONFIG, REMOTE_SCHEME, sequelizeTypescript, STATIC_PATHS, VIDEO_MIMETYPE_EXT } from '../../initializers' +import { AccountVideoRateModel } from '../../models/account/account-video-rate' import { ActorModel } from '../../models/activitypub/actor' import { TagModel } from '../../models/video/tag' import { VideoModel } from '../../models/video/video' @@ -18,6 +19,8 @@ import { VideoChannelModel } from '../../models/video/video-channel' import { VideoFileModel } from '../../models/video/video-file' import { VideoShareModel } from '../../models/video/video-share' import { getOrCreateActorAndServerAndModel } from './actor' +import { addVideoComments } from './video-comments' +import { crawlCollectionPage } from './crawl' function fetchRemoteVideoPreview (video: VideoModel, reject: Function) { const host = video.VideoChannel.Account.Actor.Server.host @@ -54,32 +57,27 @@ function generateThumbnailFromUrl (video: VideoModel, icon: ActivityIconObject) async function videoActivityObjectToDBAttributes (videoChannel: VideoChannelModel, videoObject: VideoTorrentObject, - to: string[] = [], - cc: string[] = []) { - let privacy = VideoPrivacy.PRIVATE - if (to.indexOf(ACTIVITY_PUB.PUBLIC) !== -1) privacy = VideoPrivacy.PUBLIC - else if (cc.indexOf(ACTIVITY_PUB.PUBLIC) !== -1) privacy = VideoPrivacy.UNLISTED - + to: string[] = []) { + const privacy = to.indexOf(ACTIVITY_PUB.PUBLIC) !== -1 ? VideoPrivacy.PUBLIC : VideoPrivacy.UNLISTED const duration = videoObject.duration.replace(/[^\d]+/, '') - let language = null + + let language: string = null if (videoObject.language) { - language = parseInt(videoObject.language.identifier, 10) + language = videoObject.language.identifier } - let category = null + let category: number = null if (videoObject.category) { category = parseInt(videoObject.category.identifier, 10) } - let licence = null + let licence: number = null if (videoObject.licence) { licence = parseInt(videoObject.licence.identifier, 10) } - let description = null - if (videoObject.content) { - description = videoObject.content - } + const description = videoObject.content || null + const support = videoObject.support || null return { name: videoObject.name, @@ -89,11 +87,13 @@ async function videoActivityObjectToDBAttributes (videoChannel: VideoChannelMode licence, language, description, - nsfw: videoObject.nsfw, + support, + nsfw: videoObject.sensitive, commentsEnabled: videoObject.commentsEnabled, channelId: videoChannel.id, duration: parseInt(duration, 10), createdAt: new Date(videoObject.published), + publishedAt: new Date(videoObject.published), // FIXME: updatedAt does not seems to be considered by Sequelize updatedAt: new Date(videoObject.updated), views: videoObject.views, @@ -139,6 +139,13 @@ function videoFileActivityUrlToDBAttributes (videoCreated: VideoModel, videoObje return attributes } +function getOrCreateVideoChannel (videoObject: VideoTorrentObject) { + const channel = videoObject.attributedTo.find(a => a.type === 'Group') + if (!channel) throw new Error('Cannot find associated video channel to video ' + videoObject.url) + + return getOrCreateActorAndServerAndModel(channel.id) +} + async function getOrCreateVideo (videoObject: VideoTorrentObject, channelActor: ActorModel) { logger.debug('Adding remote video %s.', videoObject.id) @@ -149,12 +156,12 @@ async function getOrCreateVideo (videoObject: VideoTorrentObject, channelActor: const videoFromDatabase = await VideoModel.loadByUUIDOrURLAndPopulateAccount(videoObject.uuid, videoObject.id, t) if (videoFromDatabase) return videoFromDatabase - const videoData = await videoActivityObjectToDBAttributes(channelActor.VideoChannel, videoObject, videoObject.to, videoObject.cc) + const videoData = await videoActivityObjectToDBAttributes(channelActor.VideoChannel, videoObject, videoObject.to) const video = VideoModel.build(videoData) // Don't block on request generateThumbnailFromUrl(video, videoObject.icon) - .catch(err => logger.warn('Cannot generate thumbnail of %s.', videoObject.id, err)) + .catch(err => logger.warn('Cannot generate thumbnail of %s.', videoObject.id, { err })) const videoCreated = await video.save(sequelizeOptions) @@ -163,7 +170,7 @@ async function getOrCreateVideo (videoObject: VideoTorrentObject, channelActor: throw new Error('Cannot find valid files for video %s ' + videoObject.url) } - const tasks: Bluebird[] = videoFileAttributes.map(f => VideoFileModel.create(f, { transaction: t })) + const tasks = videoFileAttributes.map(f => VideoFileModel.create(f, { transaction: t })) await Promise.all(tasks) const tags = videoObject.tag.map(t => t.name) @@ -179,7 +186,9 @@ async function getOrCreateVideo (videoObject: VideoTorrentObject, channelActor: async function getOrCreateAccountAndVideoAndChannel (videoObject: VideoTorrentObject | string, actor?: ActorModel) { if (typeof videoObject === 'string') { - const videoFromDatabase = await VideoModel.loadByUrlAndPopulateAccount(videoObject) + const videoUrl = videoObject + + const videoFromDatabase = await VideoModel.loadByUrlAndPopulateAccount(videoUrl) if (videoFromDatabase) { return { video: videoFromDatabase, @@ -188,8 +197,8 @@ async function getOrCreateAccountAndVideoAndChannel (videoObject: VideoTorrentOb } } - videoObject = await fetchRemoteVideo(videoObject) - if (!videoObject) throw new Error('Cannot fetch remote video') + videoObject = await fetchRemoteVideo(videoUrl) + if (!videoObject) throw new Error('Cannot fetch remote video with url: ' + videoUrl) } if (!actor) { @@ -199,10 +208,7 @@ async function getOrCreateAccountAndVideoAndChannel (videoObject: VideoTorrentOb actor = await getOrCreateActorAndServerAndModel(actorObj.id) } - const channel = videoObject.attributedTo.find(a => a.type === 'Group') - if (!channel) throw new Error('Cannot find associated video channel to video ' + videoObject.url) - - const channelActor = await getOrCreateActorAndServerAndModel(channel.id) + const channelActor = await getOrCreateVideoChannel(videoObject) const options = { arguments: [ videoObject, channelActor ], @@ -211,10 +217,50 @@ async function getOrCreateAccountAndVideoAndChannel (videoObject: VideoTorrentOb const video = await retryTransactionWrapper(getOrCreateVideo, options) + // Process outside the transaction because we could fetch remote data + logger.info('Adding likes of video %s.', video.uuid) + await crawlCollectionPage(videoObject.likes, (items) => createRates(items, video, 'like')) + + logger.info('Adding dislikes of video %s.', video.uuid) + await crawlCollectionPage(videoObject.dislikes, (items) => createRates(items, video, 'dislike')) + + logger.info('Adding shares of video %s.', video.uuid) + await crawlCollectionPage(videoObject.shares, (items) => addVideoShares(items, video)) + + logger.info('Adding comments of video %s.', video.uuid) + await crawlCollectionPage(videoObject.comments, (items) => addVideoComments(items, video)) + return { actor, channelActor, video } } -async function addVideoShares (instance: VideoModel, shareUrls: string[]) { +async function createRates (actorUrls: string[], video: VideoModel, rate: VideoRateType) { + let rateCounts = 0 + const tasks: Bluebird[] = [] + + for (const actorUrl of actorUrls) { + const actor = await getOrCreateActorAndServerAndModel(actorUrl) + const p = AccountVideoRateModel + .create({ + videoId: video.id, + accountId: actor.Account.id, + type: rate + }) + .then(() => rateCounts += 1) + + tasks.push(p) + } + + await Promise.all(tasks) + + logger.info('Adding %d %s to video %s.', rateCounts, rate, video.uuid) + + // This is "likes" and "dislikes" + await video.increment(rate + 's', { by: rateCounts }) + + return +} + +async function addVideoShares (shareUrls: string[], instance: VideoModel) { for (const shareUrl of shareUrls) { // Fetch url const { body } = await doRequest({ @@ -222,18 +268,24 @@ async function addVideoShares (instance: VideoModel, shareUrls: string[]) { json: true, activityPub: true }) - const actorUrl = body.actor - if (!actorUrl) continue + if (!body || !body.actor) { + logger.warn('Cannot add remote share with url: %s, skipping...', shareUrl) + continue + } + const actorUrl = body.actor const actor = await getOrCreateActorAndServerAndModel(actorUrl) const entry = { actorId: actor.id, - videoId: instance.id + videoId: instance.id, + url: shareUrl } await VideoShareModel.findOrCreate({ - where: entry, + where: { + url: shareUrl + }, defaults: entry }) } @@ -247,7 +299,9 @@ export { videoActivityObjectToDBAttributes, videoFileActivityUrlToDBAttributes, getOrCreateVideo, - addVideoShares} + getOrCreateVideoChannel, + addVideoShares +} // --------------------------------------------------------------------------- @@ -263,7 +317,7 @@ async function fetchRemoteVideo (videoUrl: string): Promise const { body } = await doRequest(options) - if (isVideoTorrentObjectValid(body) === false) { + if (sanitizeAndCheckVideoTorrentObject(body) === false) { logger.debug('Remote video JSON is not valid.', { body }) return undefined }