X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Factivitypub%2Fprocess%2Fprocess-update.ts;h=4afdbd430576edecfe86043db69fc55713c93faa;hb=47d883de2efbc2e8b5f6f94ae18c15224cbe982b;hp=c0038be64b5a36722a1c94874660fddc84414d08;hpb=a28f353a64c24df5cf29d4167429d27f88c94502;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/activitypub/process/process-update.ts b/server/lib/activitypub/process/process-update.ts index c0038be64..4afdbd430 100644 --- a/server/lib/activitypub/process/process-update.ts +++ b/server/lib/activitypub/process/process-update.ts @@ -1,28 +1,47 @@ -import * as Bluebird from 'bluebird' -import { ActivityUpdate } from '../../../../shared/models/activitypub' +import { isRedundancyAccepted } from '@server/lib/redundancy' +import { ActivityUpdate, CacheFileObject, VideoObject } from '../../../../shared/models/activitypub' import { ActivityPubActor } from '../../../../shared/models/activitypub/activitypub-actor' -import { VideoTorrentObject } from '../../../../shared/models/activitypub/objects' +import { PlaylistObject } from '../../../../shared/models/activitypub/objects/playlist-object' +import { isCacheFileObjectValid } from '../../../helpers/custom-validators/activitypub/cache-file' +import { sanitizeAndCheckVideoTorrentObject } from '../../../helpers/custom-validators/activitypub/videos' import { retryTransactionWrapper } from '../../../helpers/database-utils' import { logger } from '../../../helpers/logger' -import { resetSequelizeInstance } from '../../../helpers/utils' -import { sequelizeTypescript } from '../../../initializers' -import { AccountModel } from '../../../models/account/account' -import { ActorModel } from '../../../models/activitypub/actor' -import { TagModel } from '../../../models/video/tag' -import { VideoFileModel } from '../../../models/video/video-file' -import { fetchAvatarIfExists, getOrCreateActorAndServerAndModel, updateActorAvatarInstance, updateActorInstance } from '../actor' -import { getOrCreateAccountAndVideoAndChannel, videoActivityObjectToDBAttributes, videoFileActivityUrlToDBAttributes } from '../videos' - -async function processUpdateActivity (activity: ActivityUpdate) { - const actor = await getOrCreateActorAndServerAndModel(activity.actor) - - if (activity.object.type === 'Video') { - return processUpdateVideo(actor, activity) - } else if (activity.object.type === 'Person') { - return processUpdateAccount(actor, activity) +import { sequelizeTypescript } from '../../../initializers/database' +import { ActorModel } from '../../../models/actor/actor' +import { APProcessorOptions } from '../../../types/activitypub-processor.model' +import { MActorFull, MActorSignature } from '../../../types/models' +import { APActorUpdater } from '../actors/updater' +import { createOrUpdateCacheFile } from '../cache-file' +import { createOrUpdateVideoPlaylist } from '../playlists' +import { forwardVideoRelatedActivity } from '../send/shared/send-utils' +import { APVideoUpdater, getOrCreateAPVideo } from '../videos' + +async function processUpdateActivity (options: APProcessorOptions) { + const { activity, byActor } = options + + const objectType = activity.object.type + + if (objectType === 'Video') { + return retryTransactionWrapper(processUpdateVideo, activity) } - return + if (objectType === 'Person' || objectType === 'Application' || objectType === 'Group') { + // We need more attributes + const byActorFull = await ActorModel.loadByUrlAndPopulateAccountAndChannel(byActor.url) + return retryTransactionWrapper(processUpdateActor, byActorFull, activity) + } + + if (objectType === 'CacheFile') { + // We need more attributes + const byActorFull = await ActorModel.loadByUrlAndPopulateAccountAndChannel(byActor.url) + return retryTransactionWrapper(processUpdateCacheFile, byActorFull, activity) + } + + if (objectType === 'Playlist') { + return retryTransactionWrapper(processUpdatePlaylist, byActor, activity) + } + + return undefined } // --------------------------------------------------------------------------- @@ -33,133 +52,64 @@ export { // --------------------------------------------------------------------------- -function processUpdateVideo (actor: ActorModel, activity: ActivityUpdate) { - const options = { - arguments: [ actor, activity ], - errorMessage: 'Cannot update the remote video with many retries' +async function processUpdateVideo (activity: ActivityUpdate) { + const videoObject = activity.object as VideoObject + + if (sanitizeAndCheckVideoTorrentObject(videoObject) === false) { + logger.debug('Video sent by update is not valid.', { videoObject }) + return undefined } - return retryTransactionWrapper(updateRemoteVideo, options) -} + const { video, created } = await getOrCreateAPVideo({ + videoObject: videoObject.id, + allowRefresh: false, + fetchType: 'all' + }) + // We did not have this video, it has been created so no need to update + if (created) return -async function updateRemoteVideo (actor: ActorModel, activity: ActivityUpdate) { - const videoAttributesToUpdate = activity.object as VideoTorrentObject - - const res = await getOrCreateAccountAndVideoAndChannel(videoAttributesToUpdate.id) - - logger.debug('Updating remote video "%s".', videoAttributesToUpdate.uuid) - let videoInstance = res.video - let videoFieldsSave: any - - try { - await sequelizeTypescript.transaction(async t => { - const sequelizeOptions = { - transaction: t - } - - videoFieldsSave = videoInstance.toJSON() - - const videoChannel = videoInstance.VideoChannel - if (videoChannel.Account.Actor.id !== actor.id) { - throw new Error('Account ' + actor.url + ' does not own video channel ' + videoChannel.Actor.url) - } - - const videoData = await videoActivityObjectToDBAttributes(videoChannel, videoAttributesToUpdate, activity.to, activity.cc) - videoInstance.set('name', videoData.name) - videoInstance.set('uuid', videoData.uuid) - videoInstance.set('url', videoData.url) - videoInstance.set('category', videoData.category) - videoInstance.set('licence', videoData.licence) - videoInstance.set('language', videoData.language) - videoInstance.set('description', videoData.description) - videoInstance.set('nsfw', videoData.nsfw) - videoInstance.set('commentsEnabled', videoData.commentsEnabled) - videoInstance.set('duration', videoData.duration) - videoInstance.set('createdAt', videoData.createdAt) - videoInstance.set('updatedAt', videoData.updatedAt) - videoInstance.set('views', videoData.views) - videoInstance.set('privacy', videoData.privacy) - - await videoInstance.save(sequelizeOptions) - - // Remove old video files - const videoFileDestroyTasks: Bluebird[] = [] - for (const videoFile of videoInstance.VideoFiles) { - videoFileDestroyTasks.push(videoFile.destroy(sequelizeOptions)) - } - await Promise.all(videoFileDestroyTasks) - - const videoFileAttributes = videoFileActivityUrlToDBAttributes(videoInstance, videoAttributesToUpdate) - const tasks = videoFileAttributes.map(f => VideoFileModel.create(f)) - await Promise.all(tasks) - - const tags = videoAttributesToUpdate.tag.map(t => t.name) - const tagInstances = await TagModel.findOrCreateTags(tags, t) - await videoInstance.$set('Tags', tagInstances, sequelizeOptions) - }) - - logger.info('Remote video with uuid %s updated', videoAttributesToUpdate.uuid) - } catch (err) { - if (videoInstance !== undefined && videoFieldsSave !== undefined) { - resetSequelizeInstance(videoInstance, videoFieldsSave) - } - - // This is just a debug because we will retry the insert - logger.debug('Cannot update the remote video.', err) - throw err - } + const updater = new APVideoUpdater(videoObject, video) + return updater.update(activity.to) } -function processUpdateAccount (actor: ActorModel, activity: ActivityUpdate) { - const options = { - arguments: [ actor, activity ], - errorMessage: 'Cannot update the remote account with many retries' - } +async function processUpdateCacheFile (byActor: MActorSignature, activity: ActivityUpdate) { + if (await isRedundancyAccepted(activity, byActor) !== true) return - return retryTransactionWrapper(updateRemoteAccount, options) -} + const cacheFileObject = activity.object as CacheFileObject -async function updateRemoteAccount (actor: ActorModel, activity: ActivityUpdate) { - const accountAttributesToUpdate = activity.object as ActivityPubActor + if (!isCacheFileObjectValid(cacheFileObject)) { + logger.debug('Cache file object sent by update is not valid.', { cacheFileObject }) + return undefined + } - logger.debug('Updating remote account "%s".', accountAttributesToUpdate.uuid) - let accountInstance: AccountModel - let actorFieldsSave: object - let accountFieldsSave: object + const { video } = await getOrCreateAPVideo({ videoObject: cacheFileObject.object }) - // Fetch icon? - const avatarName = await fetchAvatarIfExists(accountAttributesToUpdate) + await sequelizeTypescript.transaction(async t => { + await createOrUpdateCacheFile(cacheFileObject, video, byActor, t) + }) - try { - await sequelizeTypescript.transaction(async t => { - actorFieldsSave = actor.toJSON() - accountInstance = actor.Account - accountFieldsSave = actor.Account.toJSON() + if (video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] - await updateActorInstance(actor, accountAttributesToUpdate) + await forwardVideoRelatedActivity(activity, undefined, exceptions, video) + } +} - if (avatarName !== undefined) { - await updateActorAvatarInstance(actor, avatarName, t) - } +async function processUpdateActor (actor: MActorFull, activity: ActivityUpdate) { + const actorObject = activity.object as ActivityPubActor - await actor.save({ transaction: t }) + logger.debug('Updating remote account "%s".', actorObject.url) - actor.Account.set('name', accountAttributesToUpdate.name || accountAttributesToUpdate.preferredUsername) - await actor.Account.save({ transaction: t }) - }) + const updater = new APActorUpdater(actorObject, actor) + return updater.update() +} - logger.info('Remote account with uuid %s updated', accountAttributesToUpdate.uuid) - } catch (err) { - if (actor !== undefined && actorFieldsSave !== undefined) { - resetSequelizeInstance(actor, actorFieldsSave) - } +async function processUpdatePlaylist (byActor: MActorSignature, activity: ActivityUpdate) { + const playlistObject = activity.object as PlaylistObject + const byAccount = byActor.Account - if (accountInstance !== undefined && accountFieldsSave !== undefined) { - resetSequelizeInstance(accountInstance, accountFieldsSave) - } + if (!byAccount) throw new Error('Cannot update video playlist with the non account actor ' + byActor.url) - // This is just a debug because we will retry the insert - logger.debug('Cannot update the remote account.', err) - throw err - } + await createOrUpdateVideoPlaylist(playlistObject, activity.to) }