X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Factivitypub%2Fprocess%2Fprocess-update.ts;h=0b96ba3526593b731f607fab94fd25b661911dda;hb=418d092afa81e2c8fe8ac6838fc4b5eb0af6a782;hp=566e5938b3b918707fe058dfb9435dfa62e61e19;hpb=2422c46b27790d94fd29a7092170cee5a1b56008;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/activitypub/process/process-update.ts b/server/lib/activitypub/process/process-update.ts index 566e5938b..0b96ba352 100644 --- a/server/lib/activitypub/process/process-update.ts +++ b/server/lib/activitypub/process/process-update.ts @@ -1,35 +1,44 @@ -import * as Bluebird from 'bluebird' -import { ActivityUpdate } from '../../../../shared/models/activitypub' +import { ActivityUpdate, CacheFileObject, VideoTorrentObject } from '../../../../shared/models/activitypub' import { ActivityPubActor } from '../../../../shared/models/activitypub/activitypub-actor' -import { VideoTorrentObject } from '../../../../shared/models/activitypub/objects' -import { retryTransactionWrapper } from '../../../helpers/database-utils' +import { resetSequelizeInstance, retryTransactionWrapper } from '../../../helpers/database-utils' import { logger } from '../../../helpers/logger' -import { resetSequelizeInstance } from '../../../helpers/utils' import { sequelizeTypescript } from '../../../initializers' import { AccountModel } from '../../../models/account/account' import { ActorModel } from '../../../models/activitypub/actor' -import { TagModel } from '../../../models/video/tag' import { VideoChannelModel } from '../../../models/video/video-channel' -import { VideoFileModel } from '../../../models/video/video-file' -import { fetchAvatarIfExists, getOrCreateActorAndServerAndModel, updateActorAvatarInstance, updateActorInstance } from '../actor' -import { - generateThumbnailFromUrl, - getOrCreateAccountAndVideoAndChannel, - videoActivityObjectToDBAttributes, - videoFileActivityUrlToDBAttributes -} from '../videos' - -async function processUpdateActivity (activity: ActivityUpdate) { - const actor = await getOrCreateActorAndServerAndModel(activity.actor) +import { fetchAvatarIfExists, updateActorAvatarInstance, updateActorInstance } from '../actor' +import { getOrCreateVideoAndAccountAndChannel, getOrCreateVideoChannelFromVideoObject, updateVideoFromAP } from '../videos' +import { sanitizeAndCheckVideoTorrentObject } from '../../../helpers/custom-validators/activitypub/videos' +import { isCacheFileObjectValid } from '../../../helpers/custom-validators/activitypub/cache-file' +import { createOrUpdateCacheFile } from '../cache-file' +import { forwardVideoRelatedActivity } from '../send/utils' +import { PlaylistObject } from '../../../../shared/models/activitypub/objects/playlist-object' +import { createOrUpdateVideoPlaylist } from '../playlist' + +async function processUpdateActivity (activity: ActivityUpdate, byActor: ActorModel) { const objectType = activity.object.type if (objectType === 'Video') { - return processUpdateVideo(actor, activity) - } else if (objectType === 'Person' || objectType === 'Application' || objectType === 'Group') { - return processUpdateActor(actor, activity) + return retryTransactionWrapper(processUpdateVideo, byActor, activity) } - return + if (objectType === 'Person' || objectType === 'Application' || objectType === 'Group') { + // We need more attributes + const byActorFull = await ActorModel.loadByUrlAndPopulateAccountAndChannel(byActor.url) + return retryTransactionWrapper(processUpdateActor, byActorFull, activity) + } + + if (objectType === 'CacheFile') { + // We need more attributes + const byActorFull = await ActorModel.loadByUrlAndPopulateAccountAndChannel(byActor.url) + return retryTransactionWrapper(processUpdateCacheFile, byActorFull, activity) + } + + if (objectType === 'Playlist') { + return retryTransactionWrapper(processUpdatePlaylist, byActor, activity) + } + + return undefined } // --------------------------------------------------------------------------- @@ -40,98 +49,50 @@ export { // --------------------------------------------------------------------------- -function processUpdateVideo (actor: ActorModel, activity: ActivityUpdate) { - const options = { - arguments: [ actor, activity ], - errorMessage: 'Cannot update the remote video with many retries' - } - - return retryTransactionWrapper(updateRemoteVideo, options) -} +async function processUpdateVideo (actor: ActorModel, activity: ActivityUpdate) { + const videoObject = activity.object as VideoTorrentObject -async function updateRemoteVideo (actor: ActorModel, activity: ActivityUpdate) { - const videoAttributesToUpdate = activity.object as VideoTorrentObject - - const res = await getOrCreateAccountAndVideoAndChannel(videoAttributesToUpdate.id) - - logger.debug('Updating remote video "%s".', videoAttributesToUpdate.uuid) - let videoInstance = res.video - let videoFieldsSave: any - - try { - await sequelizeTypescript.transaction(async t => { - const sequelizeOptions = { - transaction: t - } + if (sanitizeAndCheckVideoTorrentObject(videoObject) === false) { + logger.debug('Video sent by update is not valid.', { videoObject }) + return undefined + } - videoFieldsSave = videoInstance.toJSON() + const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: videoObject.id, allowRefresh: false }) + const channelActor = await getOrCreateVideoChannelFromVideoObject(videoObject) - const videoChannel = videoInstance.VideoChannel - if (videoChannel.Account.Actor.id !== actor.id) { - throw new Error('Account ' + actor.url + ' does not own video channel ' + videoChannel.Actor.url) - } + const updateOptions = { + video, + videoObject, + account: actor.Account, + channel: channelActor.VideoChannel, + overrideTo: activity.to + } + return updateVideoFromAP(updateOptions) +} - const videoData = await videoActivityObjectToDBAttributes(videoChannel, videoAttributesToUpdate, activity.to, activity.cc) - videoInstance.set('name', videoData.name) - videoInstance.set('uuid', videoData.uuid) - videoInstance.set('url', videoData.url) - videoInstance.set('category', videoData.category) - videoInstance.set('licence', videoData.licence) - videoInstance.set('language', videoData.language) - videoInstance.set('description', videoData.description) - videoInstance.set('support', videoData.support) - videoInstance.set('nsfw', videoData.nsfw) - videoInstance.set('commentsEnabled', videoData.commentsEnabled) - videoInstance.set('duration', videoData.duration) - videoInstance.set('createdAt', videoData.createdAt) - videoInstance.set('updatedAt', videoData.updatedAt) - videoInstance.set('views', videoData.views) - videoInstance.set('privacy', videoData.privacy) - - await videoInstance.save(sequelizeOptions) - - // Don't block on request - generateThumbnailFromUrl(videoInstance, videoAttributesToUpdate.icon) - .catch(err => logger.warn('Cannot generate thumbnail of %s.', videoAttributesToUpdate.id, err)) - - // Remove old video files - const videoFileDestroyTasks: Bluebird[] = [] - for (const videoFile of videoInstance.VideoFiles) { - videoFileDestroyTasks.push(videoFile.destroy(sequelizeOptions)) - } - await Promise.all(videoFileDestroyTasks) +async function processUpdateCacheFile (byActor: ActorModel, activity: ActivityUpdate) { + const cacheFileObject = activity.object as CacheFileObject - const videoFileAttributes = videoFileActivityUrlToDBAttributes(videoInstance, videoAttributesToUpdate) - const tasks = videoFileAttributes.map(f => VideoFileModel.create(f)) - await Promise.all(tasks) + if (!isCacheFileObjectValid(cacheFileObject)) { + logger.debug('Cache file object sent by update is not valid.', { cacheFileObject }) + return undefined + } - const tags = videoAttributesToUpdate.tag.map(t => t.name) - const tagInstances = await TagModel.findOrCreateTags(tags, t) - await videoInstance.$set('Tags', tagInstances, sequelizeOptions) - }) + const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: cacheFileObject.object }) - logger.info('Remote video with uuid %s updated', videoAttributesToUpdate.uuid) - } catch (err) { - if (videoInstance !== undefined && videoFieldsSave !== undefined) { - resetSequelizeInstance(videoInstance, videoFieldsSave) - } + await sequelizeTypescript.transaction(async t => { + await createOrUpdateCacheFile(cacheFileObject, video, byActor, t) + }) - // This is just a debug because we will retry the insert - logger.debug('Cannot update the remote video.', err) - throw err - } -} + if (video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] -function processUpdateActor (actor: ActorModel, activity: ActivityUpdate) { - const options = { - arguments: [ actor, activity ], - errorMessage: 'Cannot update the remote actor with many retries' + await forwardVideoRelatedActivity(activity, undefined, exceptions, video) } - - return retryTransactionWrapper(updateRemoteActor, options) } -async function updateRemoteActor (actor: ActorModel, activity: ActivityUpdate) { +async function processUpdateActor (actor: ActorModel, activity: ActivityUpdate) { const actorAttributesToUpdate = activity.object as ActivityPubActor logger.debug('Updating remote account "%s".', actorAttributesToUpdate.uuid) @@ -176,7 +137,16 @@ async function updateRemoteActor (actor: ActorModel, activity: ActivityUpdate) { } // This is just a debug because we will retry the insert - logger.debug('Cannot update the remote account.', err) + logger.debug('Cannot update the remote account.', { err }) throw err } } + +async function processUpdatePlaylist (byActor: ActorModel, activity: ActivityUpdate) { + const playlistObject = activity.object as PlaylistObject + const byAccount = byActor.Account + + if (!byAccount) throw new Error('Cannot update video playlist with the non account actor ' + byActor.url) + + await createOrUpdateVideoPlaylist(playlistObject, byAccount, activity.to) +}