X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Factivitypub%2Fprocess%2Fprocess-undo.ts;h=10643b2e99d9210535aa5998740abea0d479d4f1;hb=8dc8a34ee8428e7657414115d1c137592efa174d;hp=caa835714b1f91cdd6913919915d458e715737b7;hpb=0032ebe94aa83fab761c7de3ceb6210ac4532824;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/activitypub/process/process-undo.ts b/server/lib/activitypub/process/process-undo.ts index caa835714..10643b2e9 100644 --- a/server/lib/activitypub/process/process-undo.ts +++ b/server/lib/activitypub/process/process-undo.ts @@ -1,20 +1,44 @@ -import { ActivityCreate, ActivityFollow, ActivityLike, ActivityUndo } from '../../../../shared/models/activitypub/activity' -import { logger } from '../../../helpers/logger' -import { database as db } from '../../../initializers' +import { ActivityAnnounce, ActivityFollow, ActivityLike, ActivityUndo, CacheFileObject } from '../../../../shared/models/activitypub' +import { DislikeObject } from '../../../../shared/models/activitypub/objects' import { retryTransactionWrapper } from '../../../helpers/database-utils' -import { DislikeObject } from '../../../../shared/models/activitypub/objects/dislike-object' -import { sendUndoLikeToVideoFollowers } from '../send/send-undo' -import { sendUndoDislikeToVideoFollowers } from '../index' - -async function processUndoActivity (activity: ActivityUndo) { +import { logger } from '../../../helpers/logger' +import { sequelizeTypescript } from '../../../initializers' +import { AccountVideoRateModel } from '../../../models/account/account-video-rate' +import { ActorModel } from '../../../models/activitypub/actor' +import { ActorFollowModel } from '../../../models/activitypub/actor-follow' +import { forwardVideoRelatedActivity } from '../send/utils' +import { getOrCreateVideoAndAccountAndChannel } from '../videos' +import { VideoShareModel } from '../../../models/video/video-share' +import { VideoRedundancyModel } from '../../../models/redundancy/video-redundancy' +import { APProcessorOptions } from '../../../typings/activitypub-processor.model' +import { MActorSignature } from '../../../typings/models' + +async function processUndoActivity (options: APProcessorOptions) { + const { activity, byActor } = options const activityToUndo = activity.object if (activityToUndo.type === 'Like') { - return processUndoLike(activity.actor, activityToUndo) - } else if (activityToUndo.type === 'Create' && activityToUndo.object.type === 'Dislike') { - return processUndoDislike(activity.actor, activityToUndo.object) - } else if (activityToUndo.type === 'Follow') { - return processUndoFollow(activity.actor, activityToUndo) + return retryTransactionWrapper(processUndoLike, byActor, activity) + } + + if (activityToUndo.type === 'Create') { + if (activityToUndo.object.type === 'Dislike') { + return retryTransactionWrapper(processUndoDislike, byActor, activity) + } else if (activityToUndo.object.type === 'CacheFile') { + return retryTransactionWrapper(processUndoCacheFile, byActor, activity) + } + } + + if (activityToUndo.type === 'Dislike') { + return retryTransactionWrapper(processUndoDislike, byActor, activity) + } + + if (activityToUndo.type === 'Follow') { + return retryTransactionWrapper(processUndoFollow, byActor, activityToUndo) + } + + if (activityToUndo.type === 'Announce') { + return retryTransactionWrapper(processUndoAnnounce, byActor, activityToUndo) } logger.warn('Unknown activity object type %s -> %s when undo activity.', activityToUndo.type, { activity: activity.id }) @@ -30,79 +54,106 @@ export { // --------------------------------------------------------------------------- -function processUndoLike (actor: string, likeActivity: ActivityLike) { - const options = { - arguments: [ actor, likeActivity ], - errorMessage: 'Cannot undo like with many retries.' - } +async function processUndoLike (byActor: MActorSignature, activity: ActivityUndo) { + const likeActivity = activity.object as ActivityLike - return retryTransactionWrapper(undoLike, options) + const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: likeActivity.object }) + + return sequelizeTypescript.transaction(async t => { + if (!byActor.Account) throw new Error('Unknown account ' + byActor.url) + + const rate = await AccountVideoRateModel.loadByAccountAndVideoOrUrl(byActor.Account.id, video.id, likeActivity.id, t) + if (!rate || rate.type !== 'like') throw new Error(`Unknown like by account ${byActor.Account.id} for video ${video.id}.`) + + await rate.destroy({ transaction: t }) + await video.decrement('likes', { transaction: t }) + + if (video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] + + await forwardVideoRelatedActivity(activity, t, exceptions, video) + } + }) } -function undoLike (actor: string, likeActivity: ActivityLike) { - return db.sequelize.transaction(async t => { - const byAccount = await db.Account.loadByUrl(actor, t) - if (!byAccount) throw new Error('Unknown account ' + actor) +async function processUndoDislike (byActor: MActorSignature, activity: ActivityUndo) { + const dislike = activity.object.type === 'Dislike' + ? activity.object + : activity.object.object as DislikeObject + + const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: dislike.object }) - const video = await db.Video.loadByUrlAndPopulateAccount(likeActivity.object) - if (!video) throw new Error('Unknown video ' + likeActivity.actor) + return sequelizeTypescript.transaction(async t => { + if (!byActor.Account) throw new Error('Unknown account ' + byActor.url) - const rate = await db.AccountVideoRate.load(byAccount.id, video.id, t) - if (!rate) throw new Error(`Unknown rate by account ${byAccount.id} for video ${video.id}.`) + const rate = await AccountVideoRateModel.loadByAccountAndVideoOrUrl(byActor.Account.id, video.id, dislike.id, t) + if (!rate || rate.type !== 'dislike') throw new Error(`Unknown dislike by account ${byActor.Account.id} for video ${video.id}.`) await rate.destroy({ transaction: t }) - await video.decrement('likes') + await video.decrement('dislikes', { transaction: t }) - if (video.isOwned()) await sendUndoLikeToVideoFollowers(byAccount, video, t) + if (video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] + + await forwardVideoRelatedActivity(activity, t, exceptions, video) + } }) } -function processUndoDislike (actor: string, dislikeCreateActivity: DislikeObject) { - const options = { - arguments: [ actor, dislikeCreateActivity ], - errorMessage: 'Cannot undo dislike with many retries.' - } +async function processUndoCacheFile (byActor: MActorSignature, activity: ActivityUndo) { + const cacheFileObject = activity.object.object as CacheFileObject - return retryTransactionWrapper(undoDislike, options) -} + const { video } = await getOrCreateVideoAndAccountAndChannel({ videoObject: cacheFileObject.object }) -function undoDislike (actor: string, dislike: DislikeObject) { - return db.sequelize.transaction(async t => { - const byAccount = await db.Account.loadByUrl(actor, t) - if (!byAccount) throw new Error('Unknown account ' + actor) + return sequelizeTypescript.transaction(async t => { + const cacheFile = await VideoRedundancyModel.loadByUrl(cacheFileObject.id) + if (!cacheFile) { + logger.debug('Cannot undo unknown video cache %s.', cacheFileObject.id) + return + } - const video = await db.Video.loadByUrlAndPopulateAccount(dislike.object) - if (!video) throw new Error('Unknown video ' + dislike.actor) + if (cacheFile.actorId !== byActor.id) throw new Error('Cannot delete redundancy ' + cacheFile.url + ' of another actor.') - const rate = await db.AccountVideoRate.load(byAccount.id, video.id, t) - if (!rate) throw new Error(`Unknown rate by account ${byAccount.id} for video ${video.id}.`) + await cacheFile.destroy() - await rate.destroy({ transaction: t }) - await video.decrement('dislikes') + if (video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] - if (video.isOwned()) await sendUndoDislikeToVideoFollowers(byAccount, video, t) + await forwardVideoRelatedActivity(activity, t, exceptions, video) + } }) } -function processUndoFollow (actor: string, followActivity: ActivityFollow) { - const options = { - arguments: [ actor, followActivity ], - errorMessage: 'Cannot undo follow with many retries.' - } +function processUndoFollow (follower: MActorSignature, followActivity: ActivityFollow) { + return sequelizeTypescript.transaction(async t => { + const following = await ActorModel.loadByUrlAndPopulateAccountAndChannel(followActivity.object, t) + const actorFollow = await ActorFollowModel.loadByActorAndTarget(follower.id, following.id, t) + + if (!actorFollow) throw new Error(`'Unknown actor follow ${follower.id} -> ${following.id}.`) - return retryTransactionWrapper(undoFollow, options) + await actorFollow.destroy({ transaction: t }) + + return undefined + }) } -function undoFollow (actor: string, followActivity: ActivityFollow) { - return db.sequelize.transaction(async t => { - const follower = await db.Account.loadByUrl(actor, t) - const following = await db.Account.loadByUrl(followActivity.object, t) - const accountFollow = await db.AccountFollow.loadByAccountAndTarget(follower.id, following.id, t) +function processUndoAnnounce (byActor: MActorSignature, announceActivity: ActivityAnnounce) { + return sequelizeTypescript.transaction(async t => { + const share = await VideoShareModel.loadByUrl(announceActivity.id, t) + if (!share) throw new Error(`Unknown video share ${announceActivity.id}.`) - if (!accountFollow) throw new Error(`'Unknown account follow ${follower.id} -> ${following.id}.`) + if (share.actorId !== byActor.id) throw new Error(`${share.url} is not shared by ${byActor.url}.`) - await accountFollow.destroy({ transaction: t }) + await share.destroy({ transaction: t }) - return undefined + if (share.Video.isOwned()) { + // Don't resend the activity to the sender + const exceptions = [ byActor ] + + await forwardVideoRelatedActivity(announceActivity, t, exceptions, share.Video) + } }) }