X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Flib%2Factivitypub%2Fprocess%2Fprocess-like.ts;h=1aee756d86d32b5d93b58dabfc30db8b7676ff6c;hb=7a4fd56ccd86518a6b14c407fc977c7904337448;hp=cd4e86cbb7e89ca98fc8f1f24d4b852547f6c14b;hpb=cf21b2cbef61929177b9c09b5e017c3b7eb8535d;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/lib/activitypub/process/process-like.ts b/server/lib/activitypub/process/process-like.ts index cd4e86cbb..1aee756d8 100644 --- a/server/lib/activitypub/process/process-like.ts +++ b/server/lib/activitypub/process/process-like.ts @@ -1,15 +1,16 @@ +import { VideoModel } from '@server/models/video/video' import { ActivityLike } from '../../../../shared/models/activitypub' -import { getAPId } from '../../../helpers/activitypub' import { retryTransactionWrapper } from '../../../helpers/database-utils' import { sequelizeTypescript } from '../../../initializers/database' +import { getAPId } from '../../../lib/activitypub/activity' import { AccountVideoRateModel } from '../../../models/account/account-video-rate' import { APProcessorOptions } from '../../../types/activitypub-processor.model' import { MActorSignature } from '../../../types/models' -import { forwardVideoRelatedActivity } from '../send/utils' -import { getOrCreateAPVideo } from '../videos' +import { federateVideoIfNeeded, getOrCreateAPVideo } from '../videos' async function processLikeActivity (options: APProcessorOptions) { const { activity, byActor } = options + return retryTransactionWrapper(processLikeVideo, byActor, activity) } @@ -27,17 +28,24 @@ async function processLikeVideo (byActor: MActorSignature, activity: ActivityLik const byAccount = byActor.Account if (!byAccount) throw new Error('Cannot create like with the non account actor ' + byActor.url) - const { video } = await getOrCreateAPVideo({ videoObject: videoUrl }) + const { video: onlyVideo } = await getOrCreateAPVideo({ videoObject: videoUrl, fetchType: 'only-video' }) + + // We don't care about likes of remote videos + if (!onlyVideo.isOwned()) return return sequelizeTypescript.transaction(async t => { + const video = await VideoModel.loadAndPopulateAccountAndServerAndTags(onlyVideo.id, t) + const existingRate = await AccountVideoRateModel.loadByAccountAndVideoOrUrl(byAccount.id, video.id, activity.id, t) if (existingRate && existingRate.type === 'like') return if (existingRate && existingRate.type === 'dislike') { await video.decrement('dislikes', { transaction: t }) + video.dislikes-- } await video.increment('likes', { transaction: t }) + video.likes++ const rate = existingRate || new AccountVideoRateModel() rate.type = 'like' @@ -47,11 +55,6 @@ async function processLikeVideo (byActor: MActorSignature, activity: ActivityLik await rate.save({ transaction: t }) - if (video.isOwned()) { - // Don't resend the activity to the sender - const exceptions = [ byActor ] - - await forwardVideoRelatedActivity(activity, t, exceptions, video) - } + await federateVideoIfNeeded(video, false, t) }) }