X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fhelpers%2Fyoutube-dl.ts;h=72d457bc1a0ae4d4cbdc31bc5382fea65a955e11;hb=2264c1ceedcf27998108b8f8b706e51ed910d4fb;hp=07c85797a7caa496302e75c85fed19fd6e410d24;hpb=d57d1d83c6a4d98a735b21f4e8e749a5c1e1a479;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/helpers/youtube-dl.ts b/server/helpers/youtube-dl.ts index 07c85797a..72d457bc1 100644 --- a/server/helpers/youtube-dl.ts +++ b/server/helpers/youtube-dl.ts @@ -1,25 +1,36 @@ -import { CONSTRAINTS_FIELDS, VIDEO_CATEGORIES } from '../initializers/constants' +import { CONSTRAINTS_FIELDS, VIDEO_CATEGORIES, VIDEO_LANGUAGES, VIDEO_LICENCES } from '../initializers/constants' import { logger } from './logger' import { generateVideoImportTmpPath } from './utils' +import { getEnabledResolutions } from '../lib/video-transcoding' import { join } from 'path' import { peertubeTruncate, root } from './core-utils' import { ensureDir, remove, writeFile } from 'fs-extra' import * as request from 'request' import { createWriteStream } from 'fs' import { CONFIG } from '@server/initializers/config' +import { HttpStatusCode } from '../../shared/core-utils/miscs/http-error-codes' +import { VideoResolution } from '../../shared/models/videos' export type YoutubeDLInfo = { name?: string description?: string category?: number + language?: string licence?: number nsfw?: boolean tags?: string[] thumbnailUrl?: string - fileExt?: string + ext?: string + mergeExt?: string originallyPublishedAt?: Date } +export type YoutubeDLSubs = { + language: string + filename: string + path: string +}[] + const processOptions = { maxBuffer: 1024 * 1024 * 10 // 10MB } @@ -27,13 +38,29 @@ const processOptions = { function getYoutubeDLInfo (url: string, opts?: string[]): Promise { return new Promise((res, rej) => { let args = opts || [ '-j', '--flat-playlist' ] + + if (CONFIG.IMPORT.VIDEOS.HTTP.FORCE_IPV4) { + args.push('--force-ipv4') + } + args = wrapWithProxyOptions(args) + args = [ '-f', getYoutubeDLVideoFormat() ].concat(args) safeGetYoutubeDL() .then(youtubeDL => { youtubeDL.getInfo(url, args, processOptions, (err, info) => { if (err) return rej(err) if (info.is_live === true) return rej(new Error('Cannot download a live streaming.')) + if (info.format_id?.includes('+')) { + // this is a merge format and its extension will be appended + if (info.ext === 'mp4') { + info.mergeExt = 'mp4' + } else if (info.ext === 'webm') { + info.mergeExt = 'webm' + } else { + info.mergeExt = 'mkv' + } + } const obj = buildVideoInfo(normalizeObject(info)) if (obj.name && obj.name.length < CONSTRAINTS_FIELDS.VIDEOS.NAME.min) obj.name += ' video' @@ -45,19 +72,87 @@ function getYoutubeDLInfo (url: string, opts?: string[]): Promise }) } -function downloadYoutubeDLVideo (url: string, extension: string, timeout: number) { - const path = generateVideoImportTmpPath(url, extension) +function getYoutubeDLSubs (url: string, opts?: object): Promise { + return new Promise((res, rej) => { + const cwd = CONFIG.STORAGE.TMP_DIR + const options = opts || { all: true, format: 'vtt', cwd } + + safeGetYoutubeDL() + .then(youtubeDL => { + youtubeDL.getSubs(url, options, (err, files) => { + if (err) return rej(err) + if (!files) return [] + + logger.debug('Get subtitles from youtube dl.', { url, files }) + + const subtitles = files.reduce((acc, filename) => { + const matched = filename.match(/\.([a-z]{2})\.(vtt|ttml)/i) + if (!matched || !matched[1]) return acc + + return [ + ...acc, + { + language: matched[1], + path: join(cwd, filename), + filename + } + ] + }, []) + + return res(subtitles) + }) + }) + .catch(err => rej(err)) + }) +} + +function getYoutubeDLVideoFormat () { + /** + * list of format selectors in order or preference + * see https://github.com/ytdl-org/youtube-dl#format-selection + * + * case #1 asks for a mp4 using h264 (avc1) and the exact resolution in the hope + * of being able to do a "quick-transcode" + * case #2 is the first fallback. No "quick-transcode" means we can get anything else (like vp9) + * case #3 is the resolution-degraded equivalent of #1, and already a pretty safe fallback + * + * in any case we avoid AV1, see https://github.com/Chocobozzz/PeerTube/issues/3499 + **/ + const enabledResolutions = getEnabledResolutions('vod') + const resolution = enabledResolutions.length === 0 + ? VideoResolution.H_720P + : Math.max(...enabledResolutions) + + return [ + `bestvideo[vcodec^=avc1][height=${resolution}]+bestaudio[ext=m4a]`, // case #1 + `bestvideo[vcodec!*=av01][vcodec!*=vp9.2][height=${resolution}]+bestaudio`, // case #2 + `bestvideo[vcodec^=avc1][height<=${resolution}]+bestaudio[ext=m4a]`, // case #3 + `bestvideo[vcodec!*=av01][vcodec!*=vp9.2]+bestaudio`, + 'best[vcodec!*=av01][vcodec!*=vp9.2]', // case fallback for known formats + 'best' // Ultimate fallback + ].join('/') +} + +function downloadYoutubeDLVideo (url: string, extension: string, timeout: number, mergeExtension?: string) { + let path = generateVideoImportTmpPath(url, extension) + + path = mergeExtension + ? path.replace(new RegExp(`${extension}$`), mergeExtension) + : path + let timer logger.info('Importing youtubeDL video %s to %s', url, path) - let options = [ '-f', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/best', '-o', path ] + let options = [ '-f', getYoutubeDLVideoFormat(), '-o', path ] options = wrapWithProxyOptions(options) if (process.env.FFMPEG_PATH) { options = options.concat([ '--ffmpeg-location', process.env.FFMPEG_PATH ]) } + logger.debug('YoutubeDL options for %s.', url, { options }) + return new Promise((res, rej) => { safeGetYoutubeDL() .then(youtubeDL => { @@ -97,7 +192,7 @@ async function updateYoutubeDLBinary () { const binDirectory = join(root(), 'node_modules', 'youtube-dl', 'bin') const bin = join(binDirectory, 'youtube-dl') const detailsPath = join(binDirectory, 'details') - const url = 'https://yt-dl.org/downloads/latest/youtube-dl' + const url = process.env.YOUTUBE_DL_DOWNLOAD_HOST || 'https://yt-dl.org/downloads/latest/youtube-dl' await ensureDir(binDirectory) @@ -108,7 +203,7 @@ async function updateYoutubeDLBinary () { return res() } - if (result.statusCode !== 302) { + if (result.statusCode !== HttpStatusCode.FOUND_302) { logger.error('youtube-dl update error: did not get redirect for the latest version link. Status %d', result.statusCode) return res() } @@ -118,12 +213,17 @@ async function updateYoutubeDLBinary () { const newVersion = /yt-dl\.org\/downloads\/(\d{4}\.\d\d\.\d\d(\.\d)?)\/youtube-dl/.exec(url)[1] downloadFile.on('response', result => { - if (result.statusCode !== 200) { + if (result.statusCode !== HttpStatusCode.OK_200) { logger.error('Cannot update youtube-dl: new version response is not 200, it\'s %d.', result.statusCode) return res() } - downloadFile.pipe(createWriteStream(bin, { mode: 493 })) + const writeStream = createWriteStream(bin, { mode: 493 }).on('error', err => { + logger.error('youtube-dl update error in write stream', { err }) + return res() + }) + + downloadFile.pipe(writeStream) }) downloadFile.on('error', err => { @@ -184,7 +284,9 @@ function buildOriginallyPublishedAt (obj: any) { export { updateYoutubeDLBinary, + getYoutubeDLVideoFormat, downloadYoutubeDLVideo, + getYoutubeDLSubs, getYoutubeDLInfo, safeGetYoutubeDL, buildOriginallyPublishedAt @@ -211,17 +313,19 @@ function normalizeObject (obj: any) { return newObj } -function buildVideoInfo (obj: any) { +function buildVideoInfo (obj: any): YoutubeDLInfo { return { name: titleTruncation(obj.title), description: descriptionTruncation(obj.description), category: getCategory(obj.categories), licence: getLicence(obj.license), + language: getLanguage(obj.language), nsfw: isNSFW(obj), tags: getTags(obj.tags), thumbnailUrl: obj.thumbnail || undefined, originallyPublishedAt: buildOriginallyPublishedAt(obj), - fileExt: obj.ext + ext: obj.ext, + mergeExt: obj.mergeExt } } @@ -261,6 +365,11 @@ function getLicence (licence: string) { if (licence.includes('Creative Commons Attribution')) return 1 + for (const key of Object.keys(VIDEO_LICENCES)) { + const peertubeLicence = VIDEO_LICENCES[key] + if (peertubeLicence.toLowerCase() === licence.toLowerCase()) return parseInt(key, 10) + } + return undefined } @@ -280,6 +389,10 @@ function getCategory (categories: string[]) { return undefined } +function getLanguage (language: string) { + return VIDEO_LANGUAGES[language] ? language : undefined +} + function wrapWithProxyOptions (options: string[]) { if (CONFIG.IMPORT.VIDEOS.HTTP.PROXY.ENABLED) { logger.debug('Using proxy for YoutubeDL')