X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fhelpers%2Fmiddlewares%2Faccounts.ts;h=13ae6cdf4dad02cc0b7375f50ea315554622a113;hb=1fa23d6f5e487f3c149e1f0001beadd919ee82fc;hp=9be80167c9f0c65cf4481d67331a2e0bc3aad4fb;hpb=afff310e50f2fa8419bb4242470cbde46ab54463;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/helpers/middlewares/accounts.ts b/server/helpers/middlewares/accounts.ts index 9be80167c..13ae6cdf4 100644 --- a/server/helpers/middlewares/accounts.ts +++ b/server/helpers/middlewares/accounts.ts @@ -1,8 +1,8 @@ import { Response } from 'express' +import { UserModel } from '@server/models/account/user' +import { HttpStatusCode } from '../../../shared/core-utils/miscs/http-error-codes' import { AccountModel } from '../../models/account/account' -import * as Bluebird from 'bluebird' import { MAccountDefault } from '../../types/models' -import { UserModel } from '@server/models/account/user' function doesAccountIdExist (id: number | string, res: Response, sendNotFound = true) { const promise = AccountModel.load(parseInt(id + '', 10)) @@ -22,14 +22,13 @@ function doesAccountNameWithHostExist (nameWithDomain: string, res: Response, se return doesAccountExist(promise, res, sendNotFound) } -async function doesAccountExist (p: Bluebird, res: Response, sendNotFound: boolean) { +async function doesAccountExist (p: Promise, res: Response, sendNotFound: boolean) { const account = await p if (!account) { if (sendNotFound === true) { - res.status(404) - .send({ error: 'Account not found' }) - .end() + res.status(HttpStatusCode.NOT_FOUND_404) + .json({ error: 'Account not found' }) } return false @@ -40,13 +39,12 @@ async function doesAccountExist (p: Bluebird, res: Response, se return true } -async function doesUserFeedTokenCorrespond (id: number | string, token: string, res: Response) { - const user = await UserModel.loadById(parseInt(id + '', 10)) +async function doesUserFeedTokenCorrespond (id: number, token: string, res: Response) { + const user = await UserModel.loadByIdWithChannels(parseInt(id + '', 10)) if (token !== user.feedToken) { - res.status(401) - .send({ error: 'User and token mismatch' }) - .end() + res.status(HttpStatusCode.FORBIDDEN_403) + .json({ error: 'User and token mismatch' }) return false }