X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fhelpers%2Fffmpeg-utils.ts;h=62002596664441c7f244311853119b2aee13f767;hb=1dae95d7e2405c7b819daa24acde8ac5a754baf5;hp=6f7c186d9b278c7ea533095e15a7caba154101d7;hpb=dd9c7929e605be0b7341b19ab5f4aa3eb0cc4524;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/helpers/ffmpeg-utils.ts b/server/helpers/ffmpeg-utils.ts index 6f7c186d9..620025966 100644 --- a/server/helpers/ffmpeg-utils.ts +++ b/server/helpers/ffmpeg-utils.ts @@ -1,10 +1,11 @@ +import { Job } from 'bull' import * as ffmpeg from 'fluent-ffmpeg' import { readFile, remove, writeFile } from 'fs-extra' import { dirname, join } from 'path' -import { FFMPEG_NICE, VIDEO_LIVE, VIDEO_TRANSCODING_ENCODERS } from '@server/initializers/constants' -import { VideoResolution } from '../../shared/models/videos' -import { checkFFmpegEncoders } from '../initializers/checker-before-init' +import { FFMPEG_NICE, VIDEO_LIVE } from '@server/initializers/constants' +import { AvailableEncoders, EncoderOptionsBuilder, EncoderProfile, VideoResolution } from '../../shared/models/videos' import { CONFIG } from '../initializers/config' +import { promisify0 } from './core-utils' import { computeFPS, getAudioStream, getVideoFileFPS } from './ffprobe-utils' import { processImage } from './image-utils' import { logger } from './logger' @@ -20,34 +21,44 @@ import { logger } from './logger' // Encoder options // --------------------------------------------------------------------------- -// Options builders +type StreamType = 'audio' | 'video' -export type EncoderOptionsBuilder = (params: { - input: string - resolution: VideoResolution - fps?: number - streamNum?: number -}) => Promise | EncoderOptions +// --------------------------------------------------------------------------- +// Encoders support +// --------------------------------------------------------------------------- -// Options types +// Detect supported encoders by ffmpeg +let supportedEncoders: Map +async function checkFFmpegEncoders (peertubeAvailableEncoders: AvailableEncoders): Promise> { + if (supportedEncoders !== undefined) { + return supportedEncoders + } -export interface EncoderOptions { - copy?: boolean - outputOptions: string[] -} + const getAvailableEncodersPromise = promisify0(ffmpeg.getAvailableEncoders) + const availableFFmpegEncoders = await getAvailableEncodersPromise() -// All our encoders + const searchEncoders = new Set() + for (const type of [ 'live', 'vod' ]) { + for (const streamType of [ 'audio', 'video' ]) { + for (const encoder of peertubeAvailableEncoders.encodersToTry[type][streamType]) { + searchEncoders.add(encoder) + } + } + } + + supportedEncoders = new Map() -export interface EncoderProfile { - [ profile: string ]: T + for (const searchEncoder of searchEncoders) { + supportedEncoders.set(searchEncoder, availableFFmpegEncoders[searchEncoder] !== undefined) + } + + logger.info('Built supported ffmpeg encoders.', { supportedEncoders, searchEncoders }) - default: T + return supportedEncoders } -export type AvailableEncoders = { - [ id in 'live' | 'vod' ]: { - [ encoder in 'libx264' | 'aac' | 'libfdk_aac' ]?: EncoderProfile - } +function resetSupportedEncoders () { + supportedEncoders = undefined } // --------------------------------------------------------------------------- @@ -55,10 +66,10 @@ export type AvailableEncoders = { // --------------------------------------------------------------------------- function convertWebPToJPG (path: string, destination: string): Promise { - const command = ffmpeg(path) + const command = ffmpeg(path, { niceness: FFMPEG_NICE.THUMBNAIL }) .output(destination) - return runCommand(command) + return runCommand({ command, silent: true }) } function processGIF ( @@ -66,12 +77,12 @@ function processGIF ( destination: string, newSize: { width: number, height: number } ): Promise { - const command = ffmpeg(path) + const command = ffmpeg(path, { niceness: FFMPEG_NICE.THUMBNAIL }) .fps(20) .size(`${newSize.width}x${newSize.height}`) .output(destination) - return runCommand(command) + return runCommand({ command }) } async function generateImageFromVideoFile (fromPath: string, folder: string, imageName: string, size: { width: number, height: number }) { @@ -124,6 +135,8 @@ interface BaseTranscodeOptions { resolution: VideoResolution isPortraitMode?: boolean + + job?: Job } interface HLSTranscodeOptions extends BaseTranscodeOptions { @@ -188,7 +201,7 @@ async function transcode (options: TranscodeOptions) { command = await builders[options.type](command, options) - await runCommand(command) + await runCommand({ command, job: options.job }) await fixHLSPlaylistIfNeeded(options) } @@ -240,8 +253,10 @@ async function getLiveTranscodingCommand (options: { const baseEncoderBuilderParams = { input, + availableEncoders, profile, + fps: resolutionFPS, resolution, streamNum: i, @@ -249,7 +264,8 @@ async function getLiveTranscodingCommand (options: { } { - const builderResult = await getEncoderBuilderResult(Object.assign({}, baseEncoderBuilderParams, { streamType: 'VIDEO' })) + const streamType: StreamType = 'video' + const builderResult = await getEncoderBuilderResult(Object.assign({}, baseEncoderBuilderParams, { streamType })) if (!builderResult) { throw new Error('No available live video encoder found') } @@ -258,14 +274,15 @@ async function getLiveTranscodingCommand (options: { addDefaultEncoderParams({ command, encoder: builderResult.encoder, fps: resolutionFPS, streamNum: i }) - logger.debug('Apply ffmpeg live video params from %s.', builderResult.encoder, builderResult) + logger.debug('Apply ffmpeg live video params from %s using %s profile.', builderResult.encoder, profile, builderResult) command.outputOption(`${buildStreamSuffix('-c:v', i)} ${builderResult.encoder}`) command.addOutputOptions(builderResult.result.outputOptions) } { - const builderResult = await getEncoderBuilderResult(Object.assign({}, baseEncoderBuilderParams, { streamType: 'AUDIO' })) + const streamType: StreamType = 'audio' + const builderResult = await getEncoderBuilderResult(Object.assign({}, baseEncoderBuilderParams, { streamType })) if (!builderResult) { throw new Error('No available live audio encoder found') } @@ -274,7 +291,7 @@ async function getLiveTranscodingCommand (options: { addDefaultEncoderParams({ command, encoder: builderResult.encoder, fps: resolutionFPS, streamNum: i }) - logger.debug('Apply ffmpeg live audio params from %s.', builderResult.encoder, builderResult) + logger.debug('Apply ffmpeg live audio params from %s using %s profile.', builderResult.encoder, profile, builderResult) command.outputOption(`${buildStreamSuffix('-c:a', i)} ${builderResult.encoder}`) command.addOutputOptions(builderResult.result.outputOptions) @@ -477,8 +494,11 @@ function getHLSVideoPath (options: HLSTranscodeOptions | HLSFromTSTranscodeOptio // Transcoding presets // --------------------------------------------------------------------------- +// Run encoder builder depending on available encoders +// Try encoders by priority: if the encoder is available, run the chosen profile or fallback to the default one +// If the default one does not exist, check the next encoder async function getEncoderBuilderResult (options: { - streamType: string + streamType: 'video' | 'audio' input: string availableEncoders: AvailableEncoders @@ -492,17 +512,32 @@ async function getEncoderBuilderResult (options: { }) { const { availableEncoders, input, profile, resolution, streamType, fps, streamNum, videoType } = options - const encodersToTry: string[] = VIDEO_TRANSCODING_ENCODERS[streamType] + const encodersToTry = availableEncoders.encodersToTry[videoType][streamType] + const encoders = availableEncoders.available[videoType] for (const encoder of encodersToTry) { - if (!(await checkFFmpegEncoders()).get(encoder) || !availableEncoders[videoType][encoder]) continue + if (!(await checkFFmpegEncoders(availableEncoders)).get(encoder)) { + logger.debug('Encoder %s not available in ffmpeg, skipping.', encoder) + continue + } + + if (!encoders[encoder]) { + logger.debug('Encoder %s not available in peertube encoders, skipping.', encoder) + continue + } - const builderProfiles: EncoderProfile = availableEncoders[videoType][encoder] + // An object containing available profiles for this encoder + const builderProfiles: EncoderProfile = encoders[encoder] let builder = builderProfiles[profile] if (!builder) { logger.debug('Profile %s for encoder %s not available. Fallback to default.', profile, encoder) builder = builderProfiles.default + + if (!builder) { + logger.debug('Default profile for encoder %s not available. Try next available encoder.', encoder) + continue + } } const result = await builder({ input, resolution: resolution, fps, streamNum }) @@ -535,11 +570,11 @@ async function presetVideo ( // Audio encoder const parsedAudio = await getAudioStream(input) - let streamsToProcess = [ 'AUDIO', 'VIDEO' ] + let streamsToProcess: StreamType[] = [ 'audio', 'video' ] if (!parsedAudio.audioStream) { localCommand = localCommand.noAudio() - streamsToProcess = [ 'VIDEO' ] + streamsToProcess = [ 'video' ] } for (const streamType of streamsToProcess) { @@ -559,11 +594,14 @@ async function presetVideo ( throw new Error('No available encoder found for stream ' + streamType) } - logger.debug('Apply ffmpeg params from %s.', builderResult.encoder, builderResult) + logger.debug( + 'Apply ffmpeg params from %s for %s stream of input %s using %s profile.', + builderResult.encoder, streamType, input, profile, builderResult + ) - if (streamType === 'VIDEO') { + if (streamType === 'video') { localCommand.videoCodec(builderResult.encoder) - } else if (streamType === 'AUDIO') { + } else if (streamType === 'audio') { localCommand.audioCodec(builderResult.encoder) } @@ -611,23 +649,35 @@ function getFFmpeg (input: string, type: 'live' | 'vod') { return command } -async function runCommand (command: ffmpeg.FfmpegCommand, onEnd?: Function) { +async function runCommand (options: { + command: ffmpeg.FfmpegCommand + silent?: boolean // false + job?: Job +}) { + const { command, silent = false, job } = options + return new Promise((res, rej) => { command.on('error', (err, stdout, stderr) => { - if (onEnd) onEnd() + if (silent !== true) logger.error('Error in ffmpeg.', { stdout, stderr }) - logger.error('Error in transcoding job.', { stdout, stderr }) rej(err) }) command.on('end', (stdout, stderr) => { logger.debug('FFmpeg command ended.', { stdout, stderr }) - if (onEnd) onEnd() - res() }) + if (job) { + command.on('progress', progress => { + if (!progress.percent) return + + job.progress(Math.round(progress.percent)) + .catch(err => logger.warn('Cannot set ffmpeg job progress.', { err })) + }) + } + command.run() }) } @@ -646,6 +696,8 @@ export { transcode, runCommand, + resetSupportedEncoders, + // builders buildx264VODCommand }