X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fhelpers%2Fcustom-validators%2Fvideos.ts;h=9e8177f77a58f001eb4dcb529285fe58695a49ae;hb=f713f36bdf6f696ab0fe8a309035a09e864a48ca;hp=c893d2c7cf54c8b88f6f831380222e4cf71783df;hpb=8d468a16fd33ec2660c3c59b3f7def53eb0cc4a1;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/helpers/custom-validators/videos.ts b/server/helpers/custom-validators/videos.ts index c893d2c7c..9e8177f77 100644 --- a/server/helpers/custom-validators/videos.ts +++ b/server/helpers/custom-validators/videos.ts @@ -1,51 +1,56 @@ -import * as Bluebird from 'bluebird' -import { Response } from 'express' -import 'express-validator' -import { values } from 'lodash' -import 'multer' -import * as validator from 'validator' -import { VideoRateType } from '../../../shared' -import { CONSTRAINTS_FIELDS, VIDEO_CATEGORIES, VIDEO_LANGUAGES, VIDEO_LICENCES, VIDEO_RATE_TYPES } from '../../initializers' -import { database as db } from '../../initializers/database' -import { VideoInstance } from '../../models/video/video-interface' -import { logger } from '../logger' -import { isActivityPubUrlValid } from './activitypub/misc' -import { exists, isArray } from './misc' -import { VIDEO_PRIVACIES } from '../../initializers/constants' +import { UploadFilesForCheck } from 'express' +import magnetUtil from 'magnet-uri' +import validator from 'validator' +import { VideoFilter, VideoInclude, VideoPrivacy, VideoRateType } from '@shared/models' +import { + CONSTRAINTS_FIELDS, + MIMETYPES, + VIDEO_CATEGORIES, + VIDEO_LICENCES, + VIDEO_LIVE, + VIDEO_PRIVACIES, + VIDEO_RATE_TYPES, + VIDEO_STATES +} from '../../initializers/constants' +import { exists, isArray, isDateValid, isFileValid } from './misc' const VIDEOS_CONSTRAINTS_FIELDS = CONSTRAINTS_FIELDS.VIDEOS -const VIDEO_ABUSES_CONSTRAINTS_FIELDS = CONSTRAINTS_FIELDS.VIDEO_ABUSES -function isVideoCategoryValid (value: number) { - return VIDEO_CATEGORIES[value] !== undefined +function isVideoFilterValid (filter: VideoFilter) { + return filter === 'local' || filter === 'all-local' || filter === 'all' } -function isVideoUrlValid (value: string) { - return isActivityPubUrlValid(value) +function isVideoIncludeValid (include: VideoInclude) { + return exists(include) && validator.isInt('' + include) } -function isVideoLicenceValid (value: number) { - return VIDEO_LICENCES[value] !== undefined +function isVideoCategoryValid (value: any) { + return value === null || VIDEO_CATEGORIES[value] !== undefined } -function isVideoLanguageValid (value: number) { - return value === null || VIDEO_LANGUAGES[value] !== undefined +function isVideoStateValid (value: any) { + return exists(value) && VIDEO_STATES[value] !== undefined } -function isVideoNSFWValid (value: any) { - return typeof value === 'boolean' || (typeof value === 'string' && validator.isBoolean(value)) +function isVideoLicenceValid (value: any) { + return value === null || VIDEO_LICENCES[value] !== undefined +} + +function isVideoLanguageValid (value: any) { + return value === null || + (typeof value === 'string' && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.LANGUAGE)) } function isVideoDurationValid (value: string) { return exists(value) && validator.isInt(value + '', VIDEOS_CONSTRAINTS_FIELDS.DURATION) } -function isVideoTruncatedDescriptionValid (value: string) { - return exists(value) && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.TRUNCATED_DESCRIPTION) +function isVideoDescriptionValid (value: string) { + return value === null || (exists(value) && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.DESCRIPTION)) } -function isVideoDescriptionValid (value: string) { - return exists(value) && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.DESCRIPTION) +function isVideoSupportValid (value: string) { + return value === null || (exists(value) && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.SUPPORT)) } function isVideoNameValid (value: string) { @@ -56,70 +61,84 @@ function isVideoTagValid (tag: string) { return exists(tag) && validator.isLength(tag, VIDEOS_CONSTRAINTS_FIELDS.TAG) } -function isVideoTagsValid (tags: string[]) { - return isArray(tags) && - validator.isInt(tags.length.toString(), VIDEOS_CONSTRAINTS_FIELDS.TAGS) && - tags.every(tag => isVideoTagValid(tag)) -} - -function isVideoAbuseReasonValid (value: string) { - return exists(value) && validator.isLength(value, VIDEO_ABUSES_CONSTRAINTS_FIELDS.REASON) +function areVideoTagsValid (tags: string[]) { + return tags === null || ( + isArray(tags) && + validator.isInt(tags.length.toString(), VIDEOS_CONSTRAINTS_FIELDS.TAGS) && + tags.every(tag => isVideoTagValid(tag)) + ) } function isVideoViewsValid (value: string) { return exists(value) && validator.isInt(value + '', VIDEOS_CONSTRAINTS_FIELDS.VIEWS) } +const ratingTypes = new Set(Object.values(VIDEO_RATE_TYPES)) function isVideoRatingTypeValid (value: string) { - return values(VIDEO_RATE_TYPES).indexOf(value as VideoRateType) !== -1 + return value === 'none' || ratingTypes.has(value as VideoRateType) +} + +function isVideoFileExtnameValid (value: string) { + return exists(value) && (value === VIDEO_LIVE.EXTENSION || MIMETYPES.VIDEO.EXT_MIMETYPE[value] !== undefined) +} + +function isVideoFileMimeTypeValid (files: UploadFilesForCheck, field = 'videofile') { + return isFileValid({ + files, + mimeTypeRegex: MIMETYPES.VIDEO.MIMETYPES_REGEX, + field, + maxSize: null + }) } -function isVideoFile (files: { [ fieldname: string ]: Express.Multer.File[] } | Express.Multer.File[]) { - // Should have files - if (!files) return false - if (isArray(files)) return false +const videoImageTypes = CONSTRAINTS_FIELDS.VIDEOS.IMAGE.EXTNAME + .map(v => v.replace('.', '')) + .join('|') +const videoImageTypesRegex = `image/(${videoImageTypes})` - // Should have videofile file - const videofile = files['videofile'] - if (!videofile || videofile.length === 0) return false +function isVideoImageValid (files: UploadFilesForCheck, field: string, optional = true) { + return isFileValid({ + files, + mimeTypeRegex: videoImageTypesRegex, + field, + maxSize: CONSTRAINTS_FIELDS.VIDEOS.IMAGE.FILE_SIZE.max, + optional + }) +} + +function isVideoPrivacyValid (value: number) { + return VIDEO_PRIVACIES[value] !== undefined +} - // The file should exist - const file = videofile[0] - if (!file || !file.originalname) return false +function isScheduleVideoUpdatePrivacyValid (value: number) { + return value === VideoPrivacy.UNLISTED || value === VideoPrivacy.PUBLIC || value === VideoPrivacy.INTERNAL +} - return new RegExp('^video/(webm|mp4|ogg)$', 'i').test(file.mimetype) +function isVideoOriginallyPublishedAtValid (value: string | null) { + return value === null || isDateValid(value) } -function isVideoFileInfoHashValid (value: string) { +function isVideoFileInfoHashValid (value: string | null | undefined) { return exists(value) && validator.isLength(value, VIDEOS_CONSTRAINTS_FIELDS.INFO_HASH) } -function isVideoPrivacyValid (value: string) { - return VIDEO_PRIVACIES[value] !== undefined +function isVideoFileResolutionValid (value: string) { + return exists(value) && validator.isInt(value + '') } -function checkVideoExists (id: string, res: Response, callback: () => void) { - let promise: Bluebird - if (validator.isInt(id)) { - promise = db.Video.loadAndPopulateAccountAndServerAndTags(+id) - } else { // UUID - promise = db.Video.loadByUUIDAndPopulateAccountAndServerAndTags(id) - } +function isVideoFPSResolutionValid (value: string) { + return value === null || validator.isInt(value + '') +} - promise.then(video => { - if (!video) { - return res.status(404) - .json({ error: 'Video not found' }) - .end() - } +function isVideoFileSizeValid (value: string) { + return exists(value) && validator.isInt(value + '', VIDEOS_CONSTRAINTS_FIELDS.FILE_SIZE) +} - res.locals.video = video - callback() - }) - .catch(err => { - logger.error('Error in video request validator.', err) - return res.sendStatus(500) - }) +function isVideoMagnetUriValid (value: string) { + if (!exists(value)) return false + + const parsed = magnetUtil.decode(value) + return parsed && isVideoFileInfoHashValid(parsed.infoHash) } // --------------------------------------------------------------------------- @@ -128,19 +147,26 @@ export { isVideoCategoryValid, isVideoLicenceValid, isVideoLanguageValid, - isVideoNSFWValid, - isVideoTruncatedDescriptionValid, isVideoDescriptionValid, isVideoFileInfoHashValid, isVideoNameValid, - isVideoTagsValid, - isVideoAbuseReasonValid, - isVideoFile, + areVideoTagsValid, + isVideoFPSResolutionValid, + isScheduleVideoUpdatePrivacyValid, + isVideoOriginallyPublishedAtValid, + isVideoMagnetUriValid, + isVideoStateValid, + isVideoIncludeValid, isVideoViewsValid, isVideoRatingTypeValid, + isVideoFileExtnameValid, + isVideoFileMimeTypeValid, isVideoDurationValid, isVideoTagValid, - isVideoUrlValid, isVideoPrivacyValid, - checkVideoExists + isVideoFileResolutionValid, + isVideoFileSizeValid, + isVideoImageValid, + isVideoSupportValid, + isVideoFilterValid }