X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Fclient.ts;h=f17f2a5d29cb0d1bc4e56aeb5a74706742ed4a04;hb=2f1548fda32c3ba9e53913270394eedfacd55986;hp=352d45fbf9341c1044618c50cb59b1e73dbdef0d;hpb=e032aec9b92be25a996923361f83a96a89505254;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/controllers/client.ts b/server/controllers/client.ts index 352d45fbf..f17f2a5d2 100644 --- a/server/controllers/client.ts +++ b/server/controllers/client.ts @@ -2,9 +2,10 @@ import * as express from 'express' import { join } from 'path' import { root } from '../helpers/core-utils' import { ACCEPT_HEADERS, STATIC_MAX_AGE } from '../initializers' -import { asyncMiddleware } from '../middlewares' +import { asyncMiddleware, embedCSP } from '../middlewares' import { buildFileLocale, getCompleteLocale, is18nLocale, LOCALE_FILES } from '../../shared/models/i18n/i18n' import { ClientHtml } from '../lib/client-html' +import { logger } from '../helpers/logger' const clientsRouter = express.Router() @@ -15,26 +16,25 @@ const testEmbedPath = join(distPath, 'standalone', 'videos', 'test-embed.html') // Special route that add OpenGraph and oEmbed tags // Do not use a template engine for a so little thing -clientsRouter.use('/videos/watch/:id', - asyncMiddleware(generateWatchHtmlPage) -) +clientsRouter.use('/videos/watch/:id', asyncMiddleware(generateWatchHtmlPage)) -clientsRouter.use('' + +clientsRouter.use( '/videos/embed', - (req: express.Request, res: express.Response, next: express.NextFunction) => { + embedCSP, + (req: express.Request, res: express.Response) => { res.removeHeader('X-Frame-Options') res.sendFile(embedPath) } ) -clientsRouter.use('' + - '/videos/test-embed', (req: express.Request, res: express.Response, next: express.NextFunction) => { - res.sendFile(testEmbedPath) -}) +clientsRouter.use( + '/videos/test-embed', + (req: express.Request, res: express.Response) => res.sendFile(testEmbedPath) +) // Static HTML/CSS/JS client files const staticClientFiles = [ - 'manifest.json', + 'manifest.webmanifest', 'ngsw-worker.js', 'ngsw.json' ] @@ -66,9 +66,14 @@ clientsRouter.use('/client/*', (req: express.Request, res: express.Response, nex // Always serve index client page (the client is a single page application, let it handle routing) // Try to provide the right language index.html -clientsRouter.use('/(:language)?', function (req, res) { +clientsRouter.use('/(:language)?', async function (req, res) { if (req.accepts(ACCEPT_HEADERS) === 'html') { - return generateHTMLPage(req, res, req.params.language) + try { + await generateHTMLPage(req, res, req.params.language) + return + } catch (err) { + logger.error('Cannot generate HTML page.', err) + } } return res.status(404).end() @@ -83,7 +88,7 @@ export { // --------------------------------------------------------------------------- async function generateHTMLPage (req: express.Request, res: express.Response, paramLang?: string) { - const html = await ClientHtml.getIndexHTML(req, res) + const html = await ClientHtml.getDefaultHTMLPage(req, res, paramLang) return sendHTML(html, res) }