X-Git-Url: https://git.immae.eu/?a=blobdiff_plain;f=server%2Fcontrollers%2Fclient.ts;h=eb1ee6cbd6e8e6e546cbb118003a9599ea071dc6;hb=c756bae079e02873f6433582ca14a092fec0db27;hp=557cbfdfb278afde68b50b816138a2f6c4f58594;hpb=03aa518e54e3e1a5223f84bb305df640b633fc2f;p=github%2FChocobozzz%2FPeerTube.git diff --git a/server/controllers/client.ts b/server/controllers/client.ts index 557cbfdfb..eb1ee6cbd 100644 --- a/server/controllers/client.ts +++ b/server/controllers/client.ts @@ -2,7 +2,9 @@ import * as express from 'express' import { constants, promises as fs } from 'fs' import { readFile } from 'fs-extra' import { join } from 'path' +import { logger } from '@server/helpers/logger' import { CONFIG } from '@server/initializers/config' +import { Hooks } from '@server/lib/plugins/hooks' import { HttpStatusCode } from '@shared/core-utils' import { buildFileLocale, getCompleteLocale, is18nLocale, LOCALE_FILES } from '@shared/core-utils/i18n' import { root } from '../helpers/core-utils' @@ -17,16 +19,18 @@ const testEmbedPath = join(distPath, 'standalone', 'videos', 'test-embed.html') // Special route that add OpenGraph and oEmbed tags // Do not use a template engine for a so little thing -clientsRouter.use('/videos/watch/playlist/:id', asyncMiddleware(generateWatchPlaylistHtmlPage)) -clientsRouter.use('/videos/watch/:id', asyncMiddleware(generateWatchHtmlPage)) -clientsRouter.use('/accounts/:nameWithHost', asyncMiddleware(generateAccountHtmlPage)) -clientsRouter.use('/video-channels/:nameWithHost', asyncMiddleware(generateVideoChannelHtmlPage)) +clientsRouter.use([ '/w/p/:id', '/videos/watch/playlist/:id' ], asyncMiddleware(generateWatchPlaylistHtmlPage)) +clientsRouter.use([ '/w/:id', '/videos/watch/:id' ], asyncMiddleware(generateWatchHtmlPage)) +clientsRouter.use([ '/accounts/:nameWithHost', '/a/:nameWithHost' ], asyncMiddleware(generateAccountHtmlPage)) +clientsRouter.use([ '/video-channels/:nameWithHost', '/c/:nameWithHost' ], asyncMiddleware(generateVideoChannelHtmlPage)) +clientsRouter.use('/@:nameWithHost', asyncMiddleware(generateActorHtmlPage)) const embedMiddlewares = [ CONFIG.CSP.ENABLED ? embedCSP : (req: express.Request, res: express.Response, next: express.NextFunction) => next(), + // Set headers (req: express.Request, res: express.Response, next: express.NextFunction) => { res.removeHeader('X-Frame-Options') @@ -74,7 +78,7 @@ clientsRouter.use('/client', express.static(distPath, { maxAge: STATIC_MAX_AGE.C // 404 for static files not found clientsRouter.use('/client/*', (req: express.Request, res: express.Response) => { - res.sendStatus(HttpStatusCode.NOT_FOUND_404) + res.status(HttpStatusCode.NOT_FOUND_404).end() }) // Always serve index client page (the client is a single page application, let it handle routing) @@ -101,10 +105,28 @@ function serveServerTranslations (req: express.Request, res: express.Response) { return res.sendFile(path, { maxAge: STATIC_MAX_AGE.SERVER }) } - return res.sendStatus(HttpStatusCode.NOT_FOUND_404) + return res.status(HttpStatusCode.NOT_FOUND_404).end() } async function generateEmbedHtmlPage (req: express.Request, res: express.Response) { + const hookName = req.originalUrl.startsWith('/video-playlists/') + ? 'filter:html.embed.video-playlist.allowed.result' + : 'filter:html.embed.video.allowed.result' + + const allowParameters = { req } + + const allowedResult = await Hooks.wrapFun( + isEmbedAllowed, + allowParameters, + hookName + ) + + if (!allowedResult || allowedResult.allowed !== true) { + logger.info('Embed is not allowed.', { allowedResult }) + + return sendHTML(allowedResult?.html || '', res) + } + const html = await ClientHtml.getEmbedHTML() return sendHTML(html, res) @@ -134,6 +156,12 @@ async function generateVideoChannelHtmlPage (req: express.Request, res: express. return sendHTML(html, res) } +async function generateActorHtmlPage (req: express.Request, res: express.Response) { + const html = await ClientHtml.getActorHTMLPage(req.params.nameWithHost, req, res) + + return sendHTML(html, res) +} + async function generateManifest (req: express.Request, res: express.Response) { const manifestPhysicalPath = join(root(), 'client', 'dist', 'manifest.webmanifest') const manifestJson = await readFile(manifestPhysicalPath, 'utf8') @@ -158,3 +186,10 @@ function serveClientOverride (path: string) { } } } + +type AllowedResult = { allowed: boolean, html?: string } +function isEmbedAllowed (_object: { + req: express.Request +}): AllowedResult { + return { allowed: true } +}